Skip to content

fix: display selectable prompt text on detail pages - #124

Merged
aashu2006 merged 2 commits into
paro-studio:mainfrom
sridharkalaibala:fix/show-prompt-detail-text
Sep 13, 2026
Merged

aashu2006 merged 2 commits into
paro-studio:mainfrom
sridharkalaibala:fix/show-prompt-detail-text

Conversation

@sridharkalaibala

Copy link
Copy Markdown
Contributor

Fixes #78.

Display the full prompt above the Copy button in a labelled, selectable region. Preserve line breaks, wrap long unbroken text, and constrain the block height with scrolling. The region is keyboard focusable with a visible focus ring; the content flex item can shrink at narrow widths. Copy behavior is unchanged.

Validation:

  • Chromium at 320, 768 and 1440px using the actual detail component and compiled CSS, with backend data and surrounding layout/dialog components mocked: full text and selection match; multiline content and a 500-character unbroken token wrap without page overflow; the last line remains reachable; PageDown scrolls the focused region; Copy receives the original complete text. Mobile and desktop screenshots inspected. External network/fonts blocked in this fixture.
  • The same fixture against the original component fails because the prompt region is absent.
  • All 102 existing tests pass. Typecheck and production build pass; lint passes with 26 existing warnings. git diff --check passes.
  • Schema check passes in the unchanged LF worktree; no SQL changes (the Windows CRLF checkout otherwise reports unrelated generated-schema drift).

No live backend or production account was used. Prepared with AI assistance.

@strix-security

strix-security Bot commented Sep 13, 2026 •

Copy link
Copy Markdown

Strix Security Review

Warning

This pull request has 3 commits after the last Strix review (61255c5). Strix has not reviewed these changes.
Automatic review on push is off for this repository. To review the latest changes, tag @strix-security in a comment, or turn on re-review on push.

No security issues found.

Updated for 61255c5.


Reviewed by Strix
Re-run review · Configure security review settings

@aashu2006
aashu2006 merged commit a916387 into paro-studio:main Sep 13, 2026
7 checks passed
aashu2006 added a commit that referenced this pull request Sep 13, 2026
@sridharkalaibala

Copy link
Copy Markdown
Contributor Author

I noticed #128 reverted this change. Could you share whether it was a regression or a preference for a different prompt-reading interaction? I'll keep the revert intact. If there was a bug, the affected device or steps would help me reproduce it and prepare the right correction.

@aashu2006

Copy link
Copy Markdown
Member

@sridharkalaibala I reverted that feature we didn't wanted to go with that after few discussions (also this has been reverted via #128 got merged)

@sridharkalaibala

Copy link
Copy Markdown
Contributor Author

Thanks for clarifying. Understood—this was a product decision after discussion. I'll leave the feature reverted and keep the follow-up fixes aligned with the current main branch.

@aashu2006

Copy link
Copy Markdown
Member

Thanks for all of this @sridharkalaibala , the 4 PRs I merged were genuinely good work.

I can't review this many large changes at once, so I'm going to take them one at a time. I'll start with this one (#126), since it's the P0. Please hold off on claiming anything new until these are through.

Going forward, please wait until I've assigned an issue to you before starting on it, especially P0 and P1 ones. #126 changes how likes, saves and follows work across 11 files, and I'd have liked to agree on the approach in #80 before the code was written. I'm adding this to CONTRIBUTING.md so it's clear for everyone.

@sridharkalaibala

Copy link
Copy Markdown
Contributor Author

Understood, and thank you for being clear about the review workload. I’m sorry for sending several large changes before we had agreed on their approaches.

I’ll stop claiming or starting new Paro issues while the current queue is reviewed, wait for explicit assignment going forward, and agree the approach first for P0/P1 or larger changes. I’ve read the updated CONTRIBUTING.md, including the two-open-PR limit. I’ll focus on answering your review of #126 and keep the other existing PRs available for your chosen order.

This branch was successfully deployed

1 active deployment
Preview — 36cf768e Deployed Sep 13, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug: prompt detail page never shows the prompt text

2 participants