fix: remove unsupported email authentication - #125
Conversation
Strix Security ReviewWarning This pull request has 6 commits after the last Strix review ( No security issues found. Updated for Reviewed by Strix |
|
Thanks, @sridharkalaibala! We really appreciate your interest in contributing 🙌 We’ve also added priority labels such as |
|
Thanks for pointing me toward the P0/P1 issues. I'll prioritize reviewing those next, check existing claims and PRs, and start with a focused issue I can reproduce and validate. I'll follow up on the selected issue with the proposed scope before starting. |
Fixes #88.
Remove the email/password form, mode-switch controls, unused Zod schemas, and stub signIn/signUp methods from the auth context. Login and signup entry points retain their headings and offer Continue with Google. Correct both README and contributor setup instructions to configure Google OAuth and its allowed return URL.
Five tests render the actual modal with AuthProvider and the auth service, mocking only the Supabase client and toast boundary. They cover both entry modes, the existing Google provider/options and return URL, preservation of the pending route, disabled state while redirecting, and retry after returned or thrown OAuth errors. Before the fix, the two dead-form regressions fail and the three OAuth checks pass.
Validation: all 107 tests pass; typecheck and production build pass; lint passes with 26 existing warnings; git diff --check passes. The unchanged schema check passes in the LF validation worktree (the Windows checkout has unrelated CRLF schema drift). No schema or OAuth service/navigation code changed.
No live Google consent flow or production account was used. The tests verify the application request and preserved return-route state, not a live provider round trip. Prepared with AI assistance.