Skip to content

fix: remove unsupported email authentication - #125

Merged
klprakhar merged 2 commits into
paro-studio:mainfrom
sridharkalaibala:fix/google-only-auth
Sep 13, 2026
Merged

klprakhar merged 2 commits into
paro-studio:mainfrom
sridharkalaibala:fix/google-only-auth

Conversation

@sridharkalaibala

Copy link
Copy Markdown
Contributor

Fixes #88.

Remove the email/password form, mode-switch controls, unused Zod schemas, and stub signIn/signUp methods from the auth context. Login and signup entry points retain their headings and offer Continue with Google. Correct both README and contributor setup instructions to configure Google OAuth and its allowed return URL.

Five tests render the actual modal with AuthProvider and the auth service, mocking only the Supabase client and toast boundary. They cover both entry modes, the existing Google provider/options and return URL, preservation of the pending route, disabled state while redirecting, and retry after returned or thrown OAuth errors. Before the fix, the two dead-form regressions fail and the three OAuth checks pass.

Validation: all 107 tests pass; typecheck and production build pass; lint passes with 26 existing warnings; git diff --check passes. The unchanged schema check passes in the LF validation worktree (the Windows checkout has unrelated CRLF schema drift). No schema or OAuth service/navigation code changed.

No live Google consent flow or production account was used. The tests verify the application request and preserved return-route state, not a live provider round trip. Prepared with AI assistance.

@strix-security

strix-security Bot commented Sep 13, 2026 •

Copy link
Copy Markdown

Strix Security Review

Warning

This pull request has 6 commits after the last Strix review (3e34dce). Strix has not reviewed these changes.
Automatic review on push is off for this repository. To review the latest changes, tag @strix-security in a comment, or turn on re-review on push.

No security issues found.

Updated for 3e34dce.


Reviewed by Strix
Re-run review · Configure security review settings

@klprakhar
klprakhar merged commit e5391d3 into paro-studio:main Sep 13, 2026
7 checks passed
@sridharkalaibala

Copy link
Copy Markdown
Contributor Author

Thanks for reviewing and merging this, and the prompt image/text fixes in #122–#124.

@aashu2006

Copy link
Copy Markdown
Member

Thanks, @sridharkalaibala! We really appreciate your interest in contributing 🙌

We’ve also added priority labels such as P0 and P1 to the issues. It would be great if you could take a look at those and consider working on them, as they are particularly valuable to the project.

@sridharkalaibala

Copy link
Copy Markdown
Contributor Author

Thanks for pointing me toward the P0/P1 issues. I'll prioritize reviewing those next, check existing claims and PRs, and start with a focused issue I can reproduce and validate. I'll follow up on the selected issue with the proposed scope before starting.

This branch was successfully deployed

1 active deployment
Preview — d054f198 Deployed Sep 13, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug: remove the email and password sign in form, it does not work

3 participants