[alnr]

Removes the Mailchimp newsletter tooling, which no longer works: the Mailchimp account behind MAILCHIMP_API_KEY is deactivated, and "Draft newsletter" has failed with 403 User Disabled on every release since v1.3.3, including v1.3.4-pre.0 (run).

Removed

• CI: the Draft newsletter, Pending approval Slack notification, and Send newsletter jobs.
• ory dev newsletter and ory dev release notify (draft/send), plus the Mailchimp mail template (view/) and the github.com/ory/gochimp3 dependency.
• --include-changelog-since on ory dev release publish, along with its "are you sure?" prompt.

Why --include-changelog-since can go

The flag only appended Bumps from v<since> to the release pin commit. The only code that parsed that line was ory dev release notify draft, which used it to widen the newsletter's changelog range. GitHub release notes don't depend on it: ory/ci's releaser always runs conventional-changelog -r 2, so a final release's notes include the changes of the pre-release before it with or without the flag. The one visible difference is that the Bumps from vX.Y.Z-pre.0 line no longer appears under the pin commit's "Code Generation" entry.

Release with ory dev release publish vX.Y.Z; passing the old flag now fails as an unknown flag before anything runs.

Checked: go build ./..., go vet and go test for ./cmd/dev/... and ./cmd/pkg/... pass, and go mod tidy leaves go.mod/go.sum unchanged.

Supersedes #468.

🤖 Generated with Claude Code

https://claude.ai/code/session_01DUBUDqE7fMHh9gNQ3mFxhj

Summary by CodeRabbit

• Changes
  • Removed the release newsletter drafting and sending tools and their automated CI workflow.
  • Release publishing no longer supports specifying a previous version for changelog generation. Release notes are now taken from the tag message when provided.

[coderabbitai]

No actionable comments were generated in the recent review.

Walkthrough

The changes remove newsletter commands, Mailchimp newsletter generation and delivery, and related CI jobs. Release publishing no longer accepts a changelog starting version or passes a previous version to Git tagging.

Changes: Release workflow

Layer / File(s)	Summary
Remove newsletter commands and delivery cmd/dev/main.go, cmd/dev/newsletter/*, cmd/dev/release/main.go, cmd/dev/release/notify/*, view/*, .github/workflows/ci.yaml, go.mod	The developer newsletter and release notification commands, Mailchimp implementation, email template, related tests, and newsletter CI jobs are removed.
Remove previous-version changelog handling cmd/pkg/git.go, cmd/dev/release/publish.go	Release publishing no longer accepts --include-changelog-since or passes a previous version to GitTagRelease. The previous-version commit marker and tag check are removed.

Estimated code review effort: 3 (Moderate) | ~25 minutes

Change: Other

Merge Risk: Minimal · up to 604af

This change removes the broken Mailchimp newsletter tooling and the related release flag. No actionable merge-blocking risk remains. The old --include-changelog-since flag now fails as unknown, which the PR intends.

Pre-merge checks: 3 · 1

Failed checks: 1 inconclusive

Check name	Status	Explanation	Resolution
Description check		The description states the reason for the removal (the Mailchimp account is deactivated and the Draft newsletter job fails with 403 User Disabled). It lists the removed CI jobs, commands, template, de…	Add a '## Related Issue or Design Document' section. If no issue exists, state that the change is a removal and needs no design document. Complete the checklist, or mark the items that apply. Add a BREAKING CHANGES block for the removal of …

Passed checks: 3 passed

Check name	Status	Explanation
Title check		The title names the main change: removing the newsletter and release notify commands. It follows the conventional commit style and matches the changeset, which deletes the newsletter command tree, the…
Linked Issues check		Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check		Check skipped because no linked issues were found for this pull request.

Full details: Title check

Explanation

The title names the main change: removing the newsletter and release notify commands. It follows the conventional commit style and matches the changeset, which deletes the newsletter command tree, the release notify command, and the Mailchimp template. It is short and specific.

Full details: Description check

Explanation

The description states the reason for the removal (the Mailchimp account is deactivated and the Draft newsletter job fails with 403 User Disabled). It lists the removed CI jobs, commands, template, dependency, and the --include-changelog-since flag. It explains why the flag can be removed and gives the release command to use now. It reports the build, vet, and test checks. The template asks for a Related Issue or Design Document section and a checklist. The description has no Related Issue section, does not state whether the checklist items were completed, and has no BREAKING CHANGES block. The flag removal is a breaking change for users of ory dev release publish, and the description does not label it as one. The description also lacks a Further comments section, which is optional.

Resolution

Add a '## Related Issue or Design Document' section. If no issue exists, state that the change is a removal and needs no design document. Complete the checklist, or mark the items that apply. Add a BREAKING CHANGES block for the removal of the --include-changelog-since flag from ory dev release publish, and for the removal of the ory dev newsletter and ory dev release notify commands. Keep the existing explanation.

Finishing Touches

Generate unit tests (beta)

• Commit to this branch
• Create a new PR

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

• X
• Mastodon
• Reddit
• LinkedIn

Recent review info

Run configuration

• Source mode: Auto
• Repository: Unavailable
• Branch: Unavailable
• File: No configuration file from this repository applied
• Commit: Unavailable
• Layers: Organization UI
• Review profile: CHILL
• Plan: Advanced
• Run ID: f7fe5d59-f0ee-46fa-9c88-af3e4f9c5b0a

Commits

Reviewing files that changed from the base of the PR and between 6376a55 and 604af63.

Files ignored due to path filters: 1

• go.sum is excluded by !**/*.sum

Files selected for processing: 19

• .github/workflows/ci.yaml
• cmd/dev/main.go
• cmd/dev/newsletter/.snapshots/TestRenderMarkdownLong.html
• cmd/dev/newsletter/draft.go
• cmd/dev/newsletter/main.go
• cmd/dev/newsletter/pkg.go
• cmd/dev/newsletter/render_test.go
• cmd/dev/newsletter/send.go
• cmd/dev/newsletter/stub/changelog.md.expected
• cmd/dev/release/main.go
• cmd/dev/release/notify/draft.go
• cmd/dev/release/notify/draft_test.go
• cmd/dev/release/notify/main.go
• cmd/dev/release/notify/send.go
• cmd/dev/release/publish.go
• cmd/pkg/git.go
• go.mod
• view/mail-body.html
• view/view.go

Files with no reviewable changes: 15

• .github/workflows/ci.yaml
• cmd/dev/main.go
• cmd/dev/newsletter/draft.go
• cmd/dev/newsletter/main.go
• cmd/dev/newsletter/pkg.go
• cmd/dev/newsletter/render_test.go
• cmd/dev/newsletter/send.go
• cmd/dev/newsletter/stub/changelog.md.expected
• cmd/dev/release/main.go
• cmd/dev/release/notify/draft.go
• cmd/dev/release/notify/draft_test.go
• cmd/dev/release/notify/main.go
• cmd/dev/release/notify/send.go
• view/mail-body.html
• view/view.go

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.