Skip to content

ci: remove the newsletter jobs - #468

Closed
alnr wants to merge 1 commit into
masterfrom
ci/remove-newsletter
Closed

alnr wants to merge 1 commit into
masterfrom
ci/remove-newsletter

Conversation

@alnr

@alnr alnr commented Nov 13, 2026 •

Copy link
Copy Markdown
Collaborator

Removes the three newsletter jobs from ci.yaml: Draft newsletter, Pending approval Slack notification, and Send newsletter.

The Mailchimp account behind MAILCHIMP_API_KEY is deactivated. "Draft newsletter" fails on every release with:

{"title":"User Disabled","status":403,"detail":"This account has been deactivated."}

It has failed the same way since v1.3.3 / v1.3.3-pre.0 (August) and again on v1.3.4-pre.0 (run), marking otherwise successful release runs as failed. The other two jobs only run after the draft, so they go too. Nothing else depended on them; release and npm-publish are unchanged.

The MAILCHIMP_API_KEY and SLACK_WEBHOOK_URL secrets are org-level secrets, so this PR leaves them alone.

🤖 Generated with Claude Code

https://claude.ai/code/session_01DUBUDqE7fMHh9gNQ3mFxhj

Summary by CodeRabbit

  • Chores
    • Tagged releases no longer trigger newsletter drafts, approval notifications in Slack, or newsletter sends.

The Mailchimp account behind MAILCHIMP_API_KEY is deactivated, so
"Draft newsletter" has failed with "403 User Disabled" on every release
since v1.3.3, and marks otherwise successful release runs as failed.
"Send newsletter" and the Slack approval notification only run after
the draft, so they go too.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01DUBUDqE7fMHh9gNQ3mFxhj
@coderabbitai

coderabbitai Bot commented Nov 13, 2026 •

Copy link
Copy Markdown

Explain Change →

No actionable comments were generated in the recent review.

Walkthrough

The CI workflow removes the tag-triggered newsletter draft job, its dependent Slack approval notification, and the newsletter-send job.

Changes: CI newsletter workflow

Layer / File(s) Summary
Remove newsletter jobs
.github/workflows/ci.yaml
Removes the newsletter draft job and its Mailchimp configuration, the dependent Slack approval notification, and the production newsletter-send job.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Other

Suggested reviewers: icyphox

Merge Risk: Minimal · up to a06d2

This removes the failing newsletter jobs from the release workflow. The release and npm publish jobs are unaffected and have no dangling dependencies. The change is safe to merge.

Pre-merge checks: Passed 4

Check name Status Explanation
Title check Passed The title "ci: remove the newsletter jobs" matches the changeset, which removes the Draft newsletter, Pending approval Slack notification, and Send newsletter jobs from ci.yaml. It is short, specific,…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Description check Passed The description states the change clearly: it removes the Draft newsletter, Pending approval Slack notification, and Send newsletter jobs from ci.yaml. It gives the reason (a deactivated Mailchimp acc…
Full details: Title check

Explanation

The title "ci: remove the newsletter jobs" matches the changeset, which removes the Draft newsletter, Pending approval Slack notification, and Send newsletter jobs from ci.yaml. It is short, specific, and follows the conventional commit style. It does not name the reason (the deactivated Mailchimp account), but that detail is not required for the title to convey the main change.

Full details: Description check

Explanation

The description states the change clearly: it removes the Draft newsletter, Pending approval Slack notification, and Send newsletter jobs from ci.yaml. It gives the reason (a deactivated Mailchimp account returning a 403 'User Disabled' error on every release since v1.3.3), cites a failing run, and explains the impact on the dependent jobs and on release and npm-publish. It also notes that the org-level secrets are unchanged. The template asks for a Related Issue or Design Document section and a completed checklist. The description has neither, and it does not include the template's further comments. These are non-critical for a CI-only removal, so the description is mostly complete.

Finishing Touches

Generate unit tests (beta)

  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

Recent review info

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: d84e3144-c878-4b46-8b8f-12c7bf1d0d6b
Commits

Reviewing files that changed from the base of the PR and between 6376a55 and a06d2bf.

Files selected for processing: 1

  • .github/workflows/ci.yaml
Files with no reviewable changes: 1

  • .github/workflows/ci.yaml

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

@alnr

alnr commented Nov 13, 2026

Copy link
Copy Markdown
Collaborator Author

Superseded by #469, which also removes the newsletter commands and the --include-changelog-since flag.

@alnr alnr closed this Nov 13, 2026
@alnr
alnr deleted the ci/remove-newsletter branch November 13, 2026 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant