fix(ios): show GitHub vaults as owner/repo, not a container path#160
Merged
Conversation
A materialized GitHub vault lives at an opaque app-container path (.../GitHubVaults/owner/refslug/repo), which is what the file-list header and the vault switcher showed — so you couldn't tell a GitHub vault from a local folder, and the path was unreadable. - VaultStore.githubSlug → "owner/repo" (+ "@ref" for a non-default branch), built from the manifest sidecar; rootDisplayPath returns it for GitHub vaults. - StoredVault persists the slug (migration-safe decodeIfPresent) so the switcher shows it for remembered vaults too. - VaultSwitcherView: GitHub vaults get a code-branch icon + the repo slug as the title (dropping the cryptic path subtitle); local folders unchanged. app simulator build ✓. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
oratis
force-pushed
the
ux/github-vault-visual
branch
from
e334940 to
f3c6df8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Item 3/4 (iOS half) — make GitHub vaults legible in the UI.
Problem
A materialized GitHub vault lives at an opaque app-container path (
…/GitHubVaults/owner/refslug/repo). That's what the file-list header and the vault switcher displayed — so you couldn't tell a GitHub vault from a local folder, and the path was unreadable.Fix
VaultStore.githubSlug→owner/repo(+@reffor a non-default branch), built from the manifest sidecar;rootDisplayPathreturns it for GitHub vaults.StoredVaultpersists the slug (migration-safedecodeIfPresent) so the switcher shows it for remembered vaults too.VaultSwitcherView: GitHub vaults get a code-branch icon + the repo slug as the title (no more cryptic path subtitle); local folders unchanged.Verify
App simulator build ✓.
Desktop half + dedupe/clear-cache follow.
🤖 Generated with Claude Code