fix(desktop): show GitHub vaults as ⎇ owner/repo@ref in the title breadcrumb#161
Merged
Conversation
oratis
force-pushed
the
ux/desktop-github-vault-badge
branch
from
6fc01a2 to
88e8000
Compare
…adcrumb The title-bar breadcrumb showed only the vault's folder basename, so a GitHub vault was indistinguishable from a local folder and the branch wasn't visible. When the open vault is a materialized GitHub repo, the breadcrumb now renders a branch marker + `owner/repo@ref` (with a "GitHub vault · …" tooltip) instead of the bare basename. Local folders are unchanged. `githubVault` is already tracked in App.tsx; it's just passed to the Toolbar. tsc ✓ · vitest (9, +1) ✓ · biome ✓ · build ✓. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
oratis
force-pushed
the
ux/desktop-github-vault-badge
branch
from
88e8000 to
3d18f76
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Item 3/4 (desktop half) — the counterpart of #160.
Problem
The title-bar breadcrumb showed only the vault's folder basename, so a GitHub vault was indistinguishable from a local folder and the branch wasn't visible.
Fix
When the open vault is a materialized GitHub repo, the breadcrumb renders a branch marker +
owner/repo@ref(with a "GitHub vault · …" tooltip) instead of the bare basename. Local folders unchanged.githubVaultis already tracked inApp.tsx; it's just passed intoToolbar.Verify
tsc✓ ·vitest9 (+1) ✓ ·biome✓ ·build✓.Last item (dedupe re-open + clear-cache) follows.
🤖 Generated with Claude Code