Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 8 additions & 11 deletions sound/mpd/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -6,12 +6,12 @@
include $(TOPDIR)/rules.mk

PKG_NAME:=mpd
PKG_VERSION:=0.23.17
PKG_RELEASE:=2
PKG_VERSION:=0.24.15

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mpd-full: [warn] Version check (/usr/bin/mpd)
  exception: Background threads were detected before MPD could initialize. This is likely caused by a misbehaving library. Aborting to prevent erroneous behavior. Please report.
mpd-full: No executables in the package provided version 0.24.15
mpd-full: Generic tests failed

0.24 aborts in main() before parsing --version whenever /proc/self/status reports more than one thread (Main.cxx:705-711), so mpd-full/mpd-mini fail the runtime test on aarch64_generic, arm_cortex-a15_neon-vfpv4 and mips_24kc while the native x86_64/i386 runs pass. This looks like the qemu-user helper thread rather than a real defect, but test.sh (and the generic check) will stay red on emulated targets unless they skip or tolerate this abort there.


Generated by Claude Code

PKG_RELEASE:=1

PKG_SOURCE:=$(PKG_NAME)-$(PKG_VERSION).tar.xz
PKG_SOURCE_URL:=https://www.musicpd.org/download/mpd/0.23
PKG_HASH:=a86f4fe811695743b08db82a9f1a840b8918bb4f46b06f48aa1d8d1b5386dff2
PKG_SOURCE_URL:=https://www.musicpd.org/download/mpd/0.24
PKG_HASH:=524c70bce3fcd268016156bdc97abcf5be1904f0c6fd622688999123e3c4c457

PKG_MAINTAINER:=Alexandru Ardelean <ardeleanalex@gmail.com>
PKG_LICENSE:=GPL-2.0-or-later
Expand All @@ -33,7 +33,7 @@ define Package/mpd/Default
CATEGORY:=Sound
TITLE:=Music Player Daemon
URL:=https://www.musicpd.org/
DEPENDS:= +zlib +libcurl +libpthread +libmpdclient +boost $(ICONV_DEPENDS) +libfmt \
DEPENDS:=+zlib +libcurl +libpthread +libmpdclient $(ICONV_DEPENDS) +libfmt \
+PACKAGE_audio-support:alsa-lib +libexpat +libflac +libid3tag +libfaad2 +libopus
USERID:=mpd:mpd
endef
Expand All @@ -48,7 +48,7 @@ endef
define Package/mpd-full
$(call Package/mpd/Default)
TITLE+= (full)
DEPENDS+= +PACKAGE_audio-support:pulseaudio +libvorbis +libmms +libnpupnp +libshout +yajl \
DEPENDS+= +PACKAGE_audio-support:pulseaudio +libvorbis +libmms +libnpupnp +libshout \

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

0.24 also dropped Boost (NEWS:259, "remove Boost dependency"); meson no longer looks for it, and the only remaining #include <boost/...> is a fallback in src/util/Math.hxx for a libstdc++ without C99 math. Should +boost in Package/mpd/Default DEPENDS go along with +yajl?


Generated by Claude Code

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed, thanks


Generated by Claude Code

+libffmpeg +lame-lib +libsoxr +!BUILD_PATENTED:libmad
PROVIDES:=mpd
VARIANT:=full
Expand Down Expand Up @@ -129,6 +129,7 @@ MESON_ARGS += \
-Dnfs=disabled \
-Dsmbclient=disabled \
-Dqobuz=disabled \
-Dnlohmann_json=disabled \
-Dbzip2=disabled \
-Diso9660=disabled \
-Dzzip=disabled \
Expand Down Expand Up @@ -181,7 +182,6 @@ ifeq ($(BUILD_VARIANT),full)
-Dupnp=npupnp \
-Dmms=enabled \
-Ddsd=true \
-Dsoundcloud=enabled \
-Dffmpeg=enabled \
-Dmad=$(if $(CONFIG_BUILD_PATENTED),dis,en)abled \
-Dtremor=disabled \
Expand All @@ -191,12 +191,11 @@ ifeq ($(BUILD_VARIANT),full)
-Dpulse=$(if $(CONFIG_PACKAGE_audio-support),en,dis)abled \
-Drecorder=true \
-Dshout=enabled \
-Dyajl=enabled \
-Dvorbisenc=enabled \
-Dlame=enabled \
-Dsoxr=enabled

ifeq ($(CONFIG_PACKAGE_audio-support),y)
ifneq ($(CONFIG_PACKAGE_audio-support),)
TARGET_LDFLAGS += -Wl,-rpath-link=$(STAGING_DIR)/usr/lib/pulseaudio
endif
endif
Expand All @@ -208,7 +207,6 @@ ifeq ($(BUILD_VARIANT),mini)
-Dupnp=disabled \
-Dmms=disabled \
-Ddsd=false \
-Dsoundcloud=disabled \
-Dffmpeg=disabled \
-Dmad=enabled \
-Dtremor=enabled \
Expand All @@ -218,7 +216,6 @@ ifeq ($(BUILD_VARIANT),mini)
-Dpulse=disabled \
-Drecorder=false \
-Dshout=disabled \
-Dyajl=disabled \
-Dsoxr=disabled
endif

Expand Down
20 changes: 0 additions & 20 deletions sound/mpd/patches/010-fmt.patch

This file was deleted.

Loading