mpd: update to 0.24.15 - #30673
Open
commodo wants to merge 2 commits into
Open
mpd: update to 0.24.15#30673commodo wants to merge 2 commits into
commodo wants to merge 2 commits into
Conversation
openwrt-ai
reviewed
Oct 3, 2026
| $(call Package/mpd/Default) | ||
| TITLE+= (full) | ||
| DEPENDS+= +PACKAGE_audio-support:pulseaudio +libvorbis +libmms +libnpupnp +libshout +yajl \ | ||
| DEPENDS+= +PACKAGE_audio-support:pulseaudio +libvorbis +libmms +libnpupnp +libshout \ |
Collaborator
There was a problem hiding this comment.
0.24 also dropped Boost (NEWS:259, "remove Boost dependency"); meson no longer looks for it, and the only remaining #include <boost/...> is a fallback in src/util/Math.hxx for a libstdc++ without C99 math. Should +boost in Package/mpd/Default DEPENDS go along with +yajl?
Generated by Claude Code
Collaborator
There was a problem hiding this comment.
openwrt-ai
reviewed
Oct 5, 2026
-Dpulse= is derived with $(if $(CONFIG_PACKAGE_audio-support)), true for =m as well, while the rpath-link that lets the linker find libpulsecommon was guarded by ifeq(...,y). Selecting audio-support as a module built pulse support without the flag, leaving every pa_* symbol undefined. Test the same way the option does. Signed-off-by: Alexandru Ardelean <alex@shruggie.ro>
Refresh PKG_HASH and point PKG_SOURCE_URL at the 0.24 release directory. 0.24 removed the SoundCloud plugin and replaced yajl with nlohmann/json, so -Dsoundcloud= and -Dyajl= are no longer meson options and yajl leaves DEPENDS. Pin -Dnlohmann_json=disabled rather than leave the new option at auto: its only users here, qobuz and snapcast, are both disabled. 0.24 also dropped the Boost dependency: meson no longer looks for it and the one remaining include is a header-only lround fallback for a libstdc++ built without C99 math. Nothing links a boost library, so drop +boost too. Drop 010-fmt.patch. It was added in 0.23.16 to fix compilation against fmt 11.1, and 0.24 rewrote Response.hxx, dropping the FMT_VERSION ladder the patch edited. src/client/Response.cxx compiles against the feed's fmt 12.1.0 unpatched. Signed-off-by: Alexandru Ardelean <alex@shruggie.ro>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📦 Package Details
Maintainer: me
Description:
Refresh PKG_HASH and point PKG_SOURCE_URL at the 0.24 release directory.
0.24 removed the SoundCloud plugin and replaced yajl with nlohmann/json, so -Dsoundcloud= and -Dyajl= are no longer meson options and yajl leaves DEPENDS. Pin -Dnlohmann_json=disabled rather than leave the new option at auto: its only users here, qobuz and snapcast, are both disabled.
Drop 010-fmt.patch. It was added in 0.23.16 to fix compilation against fmt 11.1, and 0.24 rewrote Response.hxx, dropping the FMT_VERSION ladder the patch edited. src/client/Response.cxx compiles against the feed's fmt 12.1.0 unpatched.
🧪 Run Testing Details
✅ Formalities