Repository navigation
Conversation
Ekhorn
force-pushed
the
feature/configuration-template-parameters
branch
from
November 10, 2026 21:58
7b33be2 to
b5653dc
Compare
Ekhorn
changed the base branch from
main
to
feature/import-export-asset-attribute-configuration
November 10, 2026 22:34
4 tasks
Ekhorn
marked this pull request as ready for review
November 10, 2026 22:46
Ekhorn
force-pushed
the
feature/configuration-template-parameters
branch
from
November 11, 2026 10:46
9a6b347 to
d8c9dec
Compare
Ekhorn
force-pushed
the
feature/configuration-template-parameters
branch
from
November 19, 2026 08:35
d8c9dec to
43c062c
Compare
Base automatically changed from
feature/import-export-asset-attribute-configuration
to
main
November 19, 2026 18:47
- Ask for a template parameter per agent and apply it to every linked attribute - Block import until an agent of the link type exists
Ekhorn
force-pushed
the
feature/configuration-template-parameters
branch
from
November 19, 2026 18:49
43c062c to
39d4e77
Compare
MartinaeyNL
reviewed
Nov 20, 2026
MartinaeyNL
left a comment
Member
There was a problem hiding this comment.
Initial AI-assisted review 😉
| }; | ||
|
|
||
| const refreshAgents = async () => { | ||
| agents = [...(await loadAgents())]; |
Member
There was a problem hiding this comment.
loadAgents() queries manager.displayRealm, so "agents in the asset's realm" (acceptance criteria 5)
holds only because the asset viewer always runs in the display realm. Worth a comment
stating that assumption, or filtering against asset.realm if that invariant could
ever break.
- Show the unknown agent error while no agent is picked, since the agent is only preset when the template's agent exists - Drop the unused asset argument of getParameterGroups - Test that the Modbus unit ID is a template parameter
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Description
Adds a parameter step to configuration template import for the values that differ per asset, so one template can be reused across assets and instances.
Changelog
@JsonSchemaTemplateParameterto mark template parameters in the generated schema.AgentLink.idandModbusAgentLink.unitIdwith@JsonSchemaTemplateParameter.@JsonSchemaTitlelabels for Agent ID and Unit IDJSONSchemaUtilTestChecklist