Skip to content

Add configuration template import and export - #3380

Merged
Ekhorn merged 22 commits into
mainfrom
feature/import-export-asset-attribute-configuration
Nov 19, 2026
Merged

Ekhorn merged 22 commits into
mainfrom
feature/import-export-asset-attribute-configuration

Conversation

@Ekhorn

@Ekhorn Ekhorn commented Oct 4, 2026 •

Copy link
Copy Markdown
Contributor

Description

Adds Import and Export to the Attributes header of the asset Modify view, so the attribute configuration of one asset can be saved as a configuration template and applied to similar assets.

Changelog

  • Add GET asset/{assetId}/configurationTemplate to export the type and configuration items of the selected attributes
  • Add POST asset/{assetId}/configurationTemplate/import to check a template against the open draft and preview the patched attributes
  • Add the export and import dialogs to the Modify view, except on agents
  • Keep access metadata and attributeLinks with each asset on export and import
  • Add the config-template setup to try it out
  • Add ConfigurationTemplateUtilTest and ConfigurationTemplateTest

Checklist

  • 1. Acceptance criteria of the linked issue(s) are met
  • 2. Tests are written and all tests pass
  • 3. Changes are manually tested by you and the reviewer
  • 4. Documentation is written or updated

@Ekhorn Ekhorn self-assigned this Oct 4, 2026
@Ekhorn
Ekhorn force-pushed the feature/import-export-asset-attribute-configuration branch from 4c60293 to 0f5c80c Compare October 5, 2026 07:02
@Ekhorn

This comment was marked as outdated.

MartinaeyNL

This comment was marked as low quality.

@Ekhorn
Ekhorn force-pushed the feature/import-export-asset-attribute-configuration branch 2 times, most recently from 046f32a to cbdf8e1 Compare October 14, 2026 15:10
@Ekhorn
Ekhorn force-pushed the feature/import-export-asset-attribute-configuration branch 2 times, most recently from 48651f1 to df12724 Compare October 26, 2026 12:38
@Ekhorn Ekhorn changed the title Feature/import export asset attribute configuration Add import/export asset attribute configuration Oct 26, 2026
@Ekhorn
Ekhorn force-pushed the feature/import-export-asset-attribute-configuration branch 3 times, most recently from acf49ba to 76add6a Compare October 30, 2026 09:07
@Ekhorn
Ekhorn force-pushed the feature/import-export-asset-attribute-configuration branch 2 times, most recently from b006346 to 6aad4f2 Compare November 9, 2026 13:51
@Ekhorn
Ekhorn force-pushed the feature/import-export-asset-attribute-configuration branch 3 times, most recently from bde5507 to 7b33be2 Compare November 10, 2026 15:23
@Ekhorn Ekhorn changed the title Add import/export asset attribute configuration Add configuration template import and export Nov 10, 2026
@Ekhorn
Ekhorn force-pushed the feature/import-export-asset-attribute-configuration branch 2 times, most recently from b5653dc to 70f7125 Compare November 10, 2026 22:33
@Ekhorn
Ekhorn marked this pull request as ready for review November 10, 2026 22:43
@Ekhorn

Ekhorn commented Nov 10, 2026

Copy link
Copy Markdown
Contributor Author

Configuration templates can carry credentials

Export writes every agent link as stored. Agents themselves are not exported, so their own credentials stay behind, but some agent link fields can still hold secrets:

  • HTTP: headers and queryParameters, such as an Authorization header or an API key
  • Websocket: the headers, uri and body of its subscriptions

A template should therefore be shared like the configuration it holds, and not with untrusted users.

How do we want to handle this?

  1. Document it and leave the export as is.
  2. Warn in the export dialog when a selected attribute has such a link (needs a design).
  3. Leave those fields out of the export, or ask for them on import as template parameters.

@richturner
richturner self-requested a review November 12, 2026 09:40
Name the metadata item in deserialization error paths, so the import reads metadata at once, and show where an import fails as a list of parts.
@Ekhorn
Ekhorn requested a review from richturner November 13, 2026 15:30
richturner
richturner previously approved these changes Nov 16, 2026

@richturner richturner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am happy with all the backend code, I have not reviewed the UI code or run the UI. My assumption is that has been heavily manually tested during dev but considering deploying to a test server for people to try it out?

@Ekhorn

Ekhorn commented Nov 16, 2026

Copy link
Copy Markdown
Contributor Author

considering deploying to a test server for people to try it out?

Yes, good point. It's on test2 we discussed it might be good to run through it with @wborn and maybe @pankalog.

@Ekhorn
Ekhorn force-pushed the feature/import-export-asset-attribute-configuration branch from 278ab39 to 0ac0676 Compare November 16, 2026 17:24
@Ekhorn
Ekhorn requested a review from a team November 17, 2026 15:42
Comment thread ui/app/shared/locales/nl/or.json Resolved
- Replace the deprecated dialog renderer directives with slotted content
- Bind checked, indeterminate and modified as boolean attributes, and the template name as an attribute
- Document template bindings in ui/AGENTS.md
@Ekhorn
Ekhorn requested a review from MartinaeyNL November 18, 2026 17:10
@sonarqubecloud

Copy link
Copy Markdown

@MartinaeyNL
MartinaeyNL added this pull request to the merge queue Nov 19, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Nov 19, 2026
@MartinaeyNL
MartinaeyNL added this pull request to the merge queue Nov 19, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Nov 19, 2026
@Ekhorn
Ekhorn added this pull request to the merge queue Nov 19, 2026
Merged via the queue into main with commit 9cab6ca Nov 19, 2026
24 checks passed
@Ekhorn
Ekhorn deleted the feature/import-export-asset-attribute-configuration branch November 19, 2026 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Import and export configuration templates

3 participants