Repository navigation
fix: trust the Swift Linux release checkout - #84
Merged
Merged
Conversation
|
🦞👀 Pull request received. I will update this pull request when review starts. |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Swift CLI Linux container rejects the Actions checkout as differently owned, so imsg release dry run 39180075983 failed at the Package.resolved diff with exit 129. Trust the exact quoted GITHUB_WORKSPACE before dependency preparation and caller scripts; no wildcard or parent-directory trust is added.
The executable regression runs the production preparation shell with isolated Git configuration and GIT_TEST_ASSUME_DIFFERENT_OWNER. It reproduces exit 129 before the fix, then proves caller scripts and unchanged lockfiles succeed, lockfile drift still returns 1, paths with spaces work, and unrelated checkouts remain untrusted. Package installation and Swift resolution are stubbed.
Prepare compatible patch 1.11.8 with dated notes and an empty Unreleased section, following RELEASING.md.
Validation: focused ownership and Swift workflow contract tests passed; actionlint passed. Independent Codex autoreview found no actionable P0–P2 findings. Full
scripts/validate-workflows.shpassed on AWS Crabbox leasecbx_bb374957f943(run); its missing actionlint and Ruby prerequisites were installed before the successful gate. PR CI supplies integration and native macOS proof.