Repository navigation
ci: pin the Swift release checkout ownership fix - #355
Conversation
|
🦞👀 Pull request received. I will update this pull request when review starts. ClawSweeper review completeClawSweeper finished reviewing this revision. The review result is being finalized. |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Codex review: needs maintainer review before merge. What this changesThis PR advances imsg’s immutable shared release-workflow pin to the Linux checkout ownership fix and updates its assertion and documentation. Example: Run the imsg 0.17.0 release dry run inside the Swift Linux container.
Review scores
ProductKind: Bug fix · Worth it: Yes · Fix scope: Complete Merge readiness✅ Ready for maintainer review Keep open: this maintainer-authored PR supplies a necessary pin update still absent from main, with no actionable defects found. Priority: P2 Before mergeNone. FindingsNone. Tests
Agent review detailsHow this fits togetherThe release caller passes version, artifact, signing, and platform settings to a shared workflow that builds, verifies, and publishes release payloads. flowchart LR
A[Release dispatch] --> B[imsg release caller]
B --> C[Pinned shared workflow]
C --> D[Frozen Linux checkout]
D --> E[Dependency preparation and lockfile check]
E --> F[Linux archive build]
Technical reviewBest possible solution: Land the immutable caller update after the recorded upstream release verification gate, then rehearse the release from merged main. Do we have a high-confidence way to reproduce the issue? The failed release job, upstream diagnosis, and source-verified ownership regression establish the failure path; no target code was executed during this review. Is this the best way to solve the issue? Updating the existing immutable pin is the smallest complete caller fix because the shared workflow already owns dependency preparation. AGENTS.md: found and applied where relevant. Codex review notes: model internal, reasoning medium; reviewed against 8b16d157b425. Provenance checked
TestingProof path: in-process harness. SecurityNone. EvidenceWhat I checked:
LabelsLabel changes:
Label justifications:
Rating scale6/6 🦀 challenger crab · 5/6 🦞 diamond lobster · 4/6 🐚 platinum hermit · 3/6 🦐 gold shrimp · 2/6 🦪 silver shellfish · 1/6 🧂 unranked krab. Overall follows the weaker of proof and patch quality; ✨ marks media proof (a screenshot, video, or linked artifact) that directly shows the changed behavior. WorkflowClawSweeper edits this one comment on every review. Comment Reviewed October 18, 2026, 11:47 PM ET / October 19, 2026, 03:47 UTC. |
imsg pins the reusable Swift release workflow by immutable commit, so moving the upstream compatibility tag cannot fix its Linux release job. Advance the caller to release-workflows v1.11.8 at fc49859568b3781af7663bee48c003fd987dc08b, which trusts only the exact container checkout before dependency preparation and retains the Package.resolved drift check.
Update the existing packaging assertion to the same SHA and document the pinning contract. The imsg version remains 0.17.0.
Independent Codex autoreview found no actionable P0–P2 issues; actionlint and diff checks passed. The documented
scripts/check-linux.shgate passed on AWS Crabbox leasecbx_fea60230328e(run), including Linux tests, the standalone archive smoke check, and docs tests. CI supplies full macOS proof. This PR will merge after upstream release verification and exact-head CI, followed by an imsg release dry run on merged main.