Repository navigation
Update ProcessRuntimeResource to be entity aware - #20631
Merged
trask merged 5 commits intoOct 21, 2026
Merged
Conversation
Pull request dashboard statusMerged · refreshed 2026-10-21 21:41 UTC Status above doesn't look right?
|
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The focused changes preserve existing attributes, include entity assertions, and have no identified blocking issues.
0 open findings
What changed in this PR
Makes ProcessRuntimeResource entity-aware while preserving existing runtime attributes.
Changes:
- Emits a
process.runtimeentity when a runtime name or version is available. - Preserves an attribute-only resource when neither identifier is available.
- Adds entity assertions to resource and declarative configuration tests.
| File | Description |
|---|---|
| instrumentation/resources/library/src/test/java/io/opentelemetry/instrumentation/resources/ProcessRuntimeResourceTest.java | Verifies entity identity, description, schema, and attribute association. |
| instrumentation/resources/library/src/test/java/io/opentelemetry/instrumentation/resources/internal/ResourceDeclarativeConfigTest.java | Verifies entity presence through declarative configuration. |
| instrumentation/resources/library/src/main/java/io/opentelemetry/instrumentation/resources/ProcessRuntimeResource.java | Creates the runtime entity with an attribute-only fallback. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
trask
reviewed
Oct 16, 2026
breedx-splk
approved these changes
Oct 16, 2026
breedx-splk
left a comment
breedx-splk
left a comment
Contributor
There was a problem hiding this comment.
LGTM! It's exciting to see it starting to come together. 🥹
Member
Author
|
Done |
…y-java-instrumentation into entity-aware-process-runtime
Member
Author
trask
approved these changes
Oct 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update the ProcessRuntimeResource provider to emit the process.runtime entity when
process.runtime.nameandprocess.runtime.versionare available.