Skip to content

Align built-in resource schemas with SDK 1.67.0 - #20917

Merged
laurit merged 4 commits into
mainfrom
copilot/task-fix-resource-schema-conflicts
Oct 26, 2026
Merged

laurit merged 4 commits into
mainfrom
copilot/task-fix-resource-schema-conflicts

Conversation

Copilot AI commented Oct 23, 2026 •

Copy link
Copy Markdown
Contributor

SDK 1.67.0 produces service resources with schema 1.40.0, while built-in host, OS, and process resources used 1.24.0, causing merges to drop the schema URL.

  • Schema alignment: Update those resource schemas and the ProcessRuntimeResource missing-property fallback to 1.40.0; preserve its entity behavior and process command-attribute opt-in.
  • Regression coverage: Verify auto-configuration retains service and detector attributes, emits schema 1.40.0, and logs no schema conflict with either otel.service.name=configured-service or otel.resource.attributes=service.name=configured-service.

@opentelemetry-pr-dashboard

opentelemetry-pr-dashboard Bot commented Oct 23, 2026 •

Copy link
Copy Markdown

Pull request dashboard status

Merged · refreshed 2026-10-26 06:41 UTC

Status above doesn't look right?
  • Anything look wrong? Report it with what you expected; it helps us improve the dashboard.

Co-authored-by: trask <218610+trask@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix built-in resource schema conflicts introduced by SDK 1.67.0 Align built-in resource schemas with SDK 1.67.0 Oct 23, 2026
Copilot AI requested a review from trask October 23, 2026 22:16
@trask
trask requested a balanced review from Copilot October 23, 2026 22:20

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The narrowly scoped schema updates preserve detector behavior, and the added regression coverage addresses both service-name configuration paths with no unresolved blocking findings.

No open issues 🎉

What changed in this PR

Aligns built-in resource schema URLs with SDK 1.67.0 so merging detector resources with configured service resources preserves schema 1.40.0.

Changes:

  • Updates host, OS, process, and process-runtime fallback schemas without changing entity behavior or command-attribute opt-in.
  • Adds auto-configuration regression coverage for both service-name configuration forms, checking retained attributes, schema URL, and absence of conflict logs.
  • Updates detector assertions and adds test dependencies.
File Description
instrumentation/​resources/​library/​src/​test/​java/​io/​opentelemetry/​instrumentation/​resources/​ResourceProviderRegistrationTest.java Adds service-resource merge regression coverage.
instrumentation/​resources/​library/​src/​test/​java/​io/​opentelemetry/​instrumentation/​resources/​ProcessRuntimeResourceTest.java Updates the fallback schema assertion.
instrumentation/​resources/​library/​src/​test/​java/​io/​opentelemetry/​instrumentation/​resources/​ProcessResourceTest.java Expects process schema 1.40.0.
instrumentation/​resources/​library/​src/​test/​java/​io/​opentelemetry/​instrumentation/​resources/​OsResourceTest.java Expects schema 1.40.0 across OS cases.
instrumentation/​resources/​library/​src/​test/​java/​io/​opentelemetry/​instrumentation/​resources/​HostResourceTest.java Expects host schema 1.40.0.
instrumentation/​resources/​library/​src/​main/​java/​io/​opentelemetry/​instrumentation/​resources/​ProcessRuntimeResource.java Aligns the missing-property fallback schema.
instrumentation/​resources/​library/​src/​main/​java/​io/​opentelemetry/​instrumentation/​resources/​ProcessResource.java Aligns the process resource schema.
instrumentation/​resources/​library/​src/​main/​java/​io/​opentelemetry/​instrumentation/​resources/​OsResource.java Aligns the OS resource schema.
instrumentation/​resources/​library/​src/​main/​java/​io/​opentelemetry/​instrumentation/​resources/​HostResource.java Aligns the host resource schema.
instrumentation/​resources/​library/​build.gradle.kts Adds log-capture and auto-configuration test dependencies.

Review effort: Balanced

Co-authored-by: trask <218610+trask@users.noreply.github.com>
Copilot AI requested a review from trask October 23, 2026 22:45
@trask
trask requested a balanced review from Copilot October 23, 2026 22:48

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The focused schema updates preserve collection behavior and include regression coverage for both service-name configuration paths, with no blocking issues identified.

No open issues 🎉

Review effort: Balanced

Co-authored-by: trask <218610+trask@users.noreply.github.com>
Copilot AI requested a review from trask October 23, 2026 23:08
@trask
trask requested a balanced review from Copilot October 23, 2026 23:10
@trask
trask marked this pull request as ready for review October 23, 2026 23:11
@trask
trask requested a review from a team as a code owner October 23, 2026 23:12

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The supplied changes are narrowly scoped, preserve detector behavior, and cover both service-name configuration paths with no unresolved findings.

No open issues 🎉

Review effort: Balanced

@laurit
laurit merged commit b17de97 into main Oct 26, 2026
127 of 129 checks passed
@laurit
laurit deleted the copilot/task-fix-resource-schema-conflicts branch October 26, 2026 06:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants