feat: assert no error event during ready -> stale -> ready

[toddbaert]

This PR

Adds an assertion to the ready -> stale -> ready scenario in gherkin/events.feature that the error event handler is not executed.

Closes #387

Related

• Default retryGracePeriod and retryBackoffMaxMs are pathological flagd#2027

Notes

The existing ready -> stale -> ready scenario registered an error handler but never asserted it stayed silent, so a spurious ERROR during a short (< grace period) disconnect went uncaught. This is the gap called out in flagd#2027.

the error event handler should not have been executed is a new step; provider step definitions will need to implement the negative assertion when they bump to a testbed release containing this change.

[coderabbitai]

Warning

Review limit reached

@toddbaert, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 51 minutes

Limit details: You’ve used all 1 included review currently available under your plan.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 34a29350-95c8-429e-9d7b-7650b59df82a

📥 Commits

Reviewing files that changed from the base of the PR and between 9a74cb0 and 59104d9.

📒 Files selected for processing (1)

• gherkin/events.feature

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 1f2c44c0-b98f-4916-83da-86ae29ff24fb

📥 Commits

Reviewing files that changed from the base of the PR and between 692ce74 and 9a74cb0.

📒 Files selected for processing (1)

• gherkin/events.feature

Included review availability: Your plan includes up to 1 review per rolling hour; 0 remain after this review.

---

📝 Walkthrough

Walkthrough

The event scenarios now use updated connection-loss durations. The ready -> stale -> ready scenario waits 3 seconds and verifies that the error event handler was not executed.

Changes

Provider event lifecycle

Layer / File(s)	Summary
Connection-loss timing and assertions gherkin/events.feature	The error-transition scenarios wait 8 seconds for connection loss. The stale-to-ready scenario waits 3 seconds and asserts that the error event handler was not executed.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: ⚪ Minimal · up to 9a74c

This change adds a negative assertion to the ready–stale–ready event scenario without altering runtime behavior or timing. No actionable merge-blocking risk remains beyond normal checks and review.

Suggested reviewers: bacherfl, james-milligan, lukas-reining

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly identifies the main change: asserting that no error event occurs during the ready-to-stale-to-ready flow.
Description check	✅ Passed	The description accurately explains the new negative assertion, its purpose, and its relationship to the changed scenario.
Linked Issues check	✅ Passed	The changes satisfy issue #387 by adding the required assertion that the error event handler does not execute during recovery.
Out of Scope Changes check	✅ Passed	The duration updates support the stated goal of reducing reconnect-related test flakiness and are within the linked issue scope.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}