Skip to content

fix: increase simulated downtime - #390

Merged
toddbaert merged 1 commit into
mainfrom
fix/increase-simulated-downtime
Aug 19, 2026
Merged

fix: increase simulated downtime#390
toddbaert merged 1 commit into
mainfrom
fix/increase-simulated-downtime

Conversation

@toddbaert

Copy link
Copy Markdown
Member

* increases downtime to reliably test error/stale/grace
* missed in #386

Signed-off-by: Todd Baert <todd.baert@dynatrace.com>
@toddbaert
toddbaert requested a review from a team as a code owner August 19, 2026 20:36
@coderabbitai

coderabbitai Bot commented Aug 19, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 8bdb0d2e-5be1-48cf-8b93-aef1117694e2

📥 Commits

Reviewing files that changed from the base of the PR and between 6dea1da and fe53f16.

📒 Files selected for processing (2)
  • gherkin/config.feature
  • gherkin/connection.feature

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.


📝 Walkthrough

Walkthrough

The Gherkin specifications update retry defaults and increase connection-loss wait durations in provider and TargetUri reconnection scenarios.

Changes

Retry and reconnection timing

Layer / File(s) Summary
Retry default expectations
gherkin/config.feature
The documented and expected retryBackoffMaxMs value changes to 5000. The retryGracePeriod value changes to 10.
Reconnection wait durations
gherkin/connection.feature
Provider and TargetUri reconnection scenarios now wait 8 seconds for connection loss.

Estimated code review effort: 1 (Trivial) | ~3 minutes

Merge Risk: ⚪ Minimal · up to fe53f

This PR only adjusts simulated downtime in two test scenarios to make error, stale, and grace behavior more reliable; no actionable merge-blocking risk remains after normal checks and review.

Possibly related PRs

Suggested reviewers: bacherfl, james-milligan, lukas-reining

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly summarizes the increased simulated downtime used to improve reconnection and retry tests.
Description check ✅ Passed The description directly explains the increased downtime and its purpose in testing error, stale, and grace behavior.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@toddbaert
toddbaert requested a review from JamieSinn August 19, 2026 20:37
@toddbaert
toddbaert merged commit 218aa94 into main Aug 19, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants