Skip to content

fix(docs): keep stars in landing.json when the GitHub call fails #413

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vite-hub merged 1 commit into from
Nov 12, 2026
Merged

fix(docs): keep stars in landing.json when the GitHub call fails #413

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions docs/landing.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -234,7 +234,8 @@ const cards: Demo[] = (await loadExamples(packageOrder)).map((example) => {
};
});

// The repository's stars, read once per build. Offline or rate-limited, the button just says GitHub.
// The repository's stars, read once per build. Offline or rate-limited, the button just says GitHub. The field stays in
// landing.json as null then, so the type LandingHero.vue reads from it keeps `stars`.
const stars = await fetch("https://api.github.com/repos/onmax/comark-ui", {
headers: { accept: "application/vnd.github+json" },
signal: AbortSignal.timeout(5000),
Expand All @@ -250,7 +251,7 @@ for (const demo of deal([...cards, ...extra])) demos.push(await demoCard(demo));
mkdirSync(new URL(".generated/", docs), { recursive: true });
writeFileSync(
new URL(".generated/landing.json", docs),
`${JSON.stringify({ packages, stars }, null, 2)}\n`,
`${JSON.stringify({ packages, stars: stars ?? null }, null, 2)}\n`,
);
writeFileSync(
new URL("canvas-cards.json", publicDir),
Expand Down
Loading