Repository navigation
fix(docs): keep stars in landing.json when the GitHub call fails - #413
Conversation
|
The workflow's GitHub's error |
Codex Review Summary: ❌ FailedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
comark-annotate
comark-badge
comark-cards
comark-carousel
comark-cast
comark-charts
comark-chat
comark-chips
comark-cjk
comark-code
comark-code-notes
comark-colors
comark-comments
comark-critic
comark-deflist
comark-details
comark-diagrams
comark-diff
comark-embed
comark-fields
comark-figure
comark-file-tree
comark-footnotes
comark-github
comark-icon
comark-include
comark-keys
comark-links
comark-linter
comark-magic-move
comark-mark
markdown-it-to-comark
marked-to-comark
comark-mathml
comark-media
comark-metrics
migrate-to-comark
comark-outline
comark-properties
comark-qr
comark-quiz
comark-reading-time
remark-to-comark
comark-sources
comark-steps
comark-table
comark-tabs
comark-tests
comark-time
comark-ui
comark-xref
comark-zoom
commit: |
Latest result Pull request merged. Final answersSession Pull request merged. |

When the docs build can't reach the GitHub API (offline, rate-limited or a 5 s timeout),
pnpm --filter comark-ui-docs typecheckfails withLandingHero.vue(38,11): error TS2339: Property 'stars' does not exist. It hit CI once on #411 and passed on a rerun.docs/landing.tswritesstars: undefinedin that case, andJSON.stringifydrops the field, so the typevue-tscinfers from.generated/landing.jsonhas nostars. This PR writesstars: nullinstead.LandingHero.vuealready checkslanding.stars == null, so the page looks the same: the button just says GitHub.To check it, I ran
landing.tswithfetchtoapi.github.comrejected, thenvue-tsc -b --noEmit. Onmainthat gives 3 errors onstars; with this PR,"stars": nulland it passes. Node 24.21.0, Linux.