Skip to content

fix(docs): keep stars in landing.json when the GitHub call fails - #413

Merged
vite-hub[bot] merged 1 commit into
mainfrom
fix/landing-stars-null
Nov 12, 2026
Merged

vite-hub[bot] merged 1 commit into
mainfrom
fix/landing-stars-null

Conversation

@onmax

@onmax onmax commented Nov 12, 2026

Copy link
Copy Markdown
Owner

When the docs build can't reach the GitHub API (offline, rate-limited or a 5 s timeout), pnpm --filter comark-ui-docs typecheck fails with LandingHero.vue(38,11): error TS2339: Property 'stars' does not exist. It hit CI once on #411 and passed on a rerun.

docs/landing.ts writes stars: undefined in that case, and JSON.stringify drops the field, so the type vue-tsc infers from .generated/landing.json has no stars. This PR writes stars: null instead. LandingHero.vue already checks landing.stars == null, so the page looks the same: the button just says GitHub.

To check it, I ran landing.ts with fetch to api.github.com rejected, then vue-tsc -b --noEmit. On main that gives 3 errors on stars; with this PR, "stars": null and it passes. Node 24.21.0, Linux.

@pullfrog

pullfrog Bot commented Nov 12, 2026 •

Copy link
Copy Markdown

The workflow's Verify CLIProxy completion step failed, so Pullfrog never ran. That step runs before Pullfrog in this repo's workflow, so the fix is in the workflow or that step's own setup.

GitHub's error
Process completed with exit code 22.

View the step's logs →

Pullfrog  | Rerun failed job ➔ | View workflow run | via Pullfrog

@chatgpt-codex-connector

Copy link
Copy Markdown
Codex Review Summary: ❌ Failed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ❌ Failed 2026-11-12T11:35:30.801521Z
We couldn’t complete this review. Comment @codex review to try again.
729f22d PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.

@pkg-pr-new

pkg-pr-new Bot commented Nov 12, 2026

Copy link
Copy Markdown

Open in StackBlitz

comark-annotate

pnpm add https://pkg.pr.new/comark-annotate@413

comark-badge

pnpm add https://pkg.pr.new/comark-badge@413

comark-cards

pnpm add https://pkg.pr.new/comark-cards@413

comark-carousel

pnpm add https://pkg.pr.new/comark-carousel@413

comark-cast

pnpm add https://pkg.pr.new/comark-cast@413

comark-charts

pnpm add https://pkg.pr.new/comark-charts@413

comark-chat

pnpm add https://pkg.pr.new/comark-chat@413

comark-chips

pnpm add https://pkg.pr.new/comark-chips@413

comark-cjk

pnpm add https://pkg.pr.new/comark-cjk@413

comark-code

pnpm add https://pkg.pr.new/comark-code@413

comark-code-notes

pnpm add https://pkg.pr.new/comark-code-notes@413

comark-colors

pnpm add https://pkg.pr.new/comark-colors@413

comark-comments

pnpm add https://pkg.pr.new/comark-comments@413

comark-critic

pnpm add https://pkg.pr.new/comark-critic@413

comark-deflist

pnpm add https://pkg.pr.new/comark-deflist@413

comark-details

pnpm add https://pkg.pr.new/comark-details@413

comark-diagrams

pnpm add https://pkg.pr.new/comark-diagrams@413

comark-diff

pnpm add https://pkg.pr.new/comark-diff@413

comark-embed

pnpm add https://pkg.pr.new/comark-embed@413

comark-fields

pnpm add https://pkg.pr.new/comark-fields@413

comark-figure

pnpm add https://pkg.pr.new/comark-figure@413

comark-file-tree

pnpm add https://pkg.pr.new/comark-file-tree@413

comark-footnotes

pnpm add https://pkg.pr.new/comark-footnotes@413

comark-github

pnpm add https://pkg.pr.new/comark-github@413

comark-icon

pnpm add https://pkg.pr.new/comark-icon@413

comark-include

pnpm add https://pkg.pr.new/comark-include@413

comark-keys

pnpm add https://pkg.pr.new/comark-keys@413

comark-links

pnpm add https://pkg.pr.new/comark-links@413

comark-linter

pnpm add https://pkg.pr.new/comark-linter@413

comark-magic-move

pnpm add https://pkg.pr.new/comark-magic-move@413

comark-mark

pnpm add https://pkg.pr.new/comark-mark@413

markdown-it-to-comark

pnpm add https://pkg.pr.new/markdown-it-to-comark@413

marked-to-comark

pnpm add https://pkg.pr.new/marked-to-comark@413

comark-mathml

pnpm add https://pkg.pr.new/comark-mathml@413

comark-media

pnpm add https://pkg.pr.new/comark-media@413

comark-metrics

pnpm add https://pkg.pr.new/comark-metrics@413

migrate-to-comark

pnpm add https://pkg.pr.new/migrate-to-comark@413

comark-outline

pnpm add https://pkg.pr.new/comark-outline@413

comark-properties

pnpm add https://pkg.pr.new/comark-properties@413

comark-qr

pnpm add https://pkg.pr.new/comark-qr@413

comark-quiz

pnpm add https://pkg.pr.new/comark-quiz@413

comark-reading-time

pnpm add https://pkg.pr.new/comark-reading-time@413

remark-to-comark

pnpm add https://pkg.pr.new/remark-to-comark@413

comark-sources

pnpm add https://pkg.pr.new/comark-sources@413

comark-steps

pnpm add https://pkg.pr.new/comark-steps@413

comark-table

pnpm add https://pkg.pr.new/comark-table@413

comark-tabs

pnpm add https://pkg.pr.new/comark-tabs@413

comark-tests

pnpm add https://pkg.pr.new/comark-tests@413

comark-time

pnpm add https://pkg.pr.new/comark-time@413

comark-ui

pnpm add https://pkg.pr.new/comark-ui@413

comark-xref

pnpm add https://pkg.pr.new/comark-xref@413

comark-zoom

pnpm add https://pkg.pr.new/comark-zoom@413

commit: 729f22d

@vite-hub

vite-hub Bot commented Nov 12, 2026 •

Copy link
Copy Markdown
Contributor
Session Status Started Duration
Pending Completed Not started —

Latest result

Pull request merged.

Final answers

Session

Pull request merged.

@vite-hub
vite-hub Bot merged commit 700d07b into main Nov 12, 2026
5 of 6 checks passed
@vite-hub
vite-hub Bot deleted the fix/landing-stars-null branch November 12, 2026 13:11
This was referenced Nov 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant