Skip to content

feat(media): copy a link at the player's second and the frame on screen - #411

Merged
vite-hub[bot] merged 4 commits into
mainfrom
feat/media-copy
Nov 12, 2026
Merged

vite-hub[bot] merged 4 commits into
mainfrom
feat/media-copy

Conversation

@onmax

@onmax onmax commented Nov 12, 2026 •

Copy link
Copy Markdown
Owner

A review doc has no way to point someone at 0:12 of a recording, or to grab the frame a comment is about. The browser's "Copy video address" doesn't help when the host plays the file from a blob: URL, as Drop does in its sandboxed frame.

This adds two actions under the settings panel's speed and loop rows. Copy link copies the file's address with #t= and the second the player is at, and its label follows the time ("Copy link at 0:12"). The address comes from the fallback <a> inside the <video>, so it stays the file's own when a host swaps src. Copy frame pauses a video and copies the frame on screen as a PNG. A file from another host without CORS says it can't. Both send a cancelable comark-media-copy event first, so a host can copy another way.

Tested with e2e/media.e2e.ts (19 pass, one new test for both actions, the event, and the icons' width), the media unit tests, and pnpm run doctor, and in Drop's sandboxed doc frame through vite-hub/drop#187. Locally pnpm ready stops at remark-to-comark's CLI test, which times out on this machine; CI passes it.

Before/after on Drop

The settings panel gets Copy link, which copies the file's address with #t= and the second the player is at, and a video's Copy frame, which copies the frame on screen as a PNG. The address comes from the fallback link inside the media element, so a host that plays the file from a blob: URL still copies the real one. Both send a cancelable comark-media-copy event first, for hosts that copy another way.
@pullfrog

pullfrog Bot commented Nov 12, 2026 •

Copy link
Copy Markdown

The workflow's Verify CLIProxy completion step failed, so Pullfrog never ran. That step runs before Pullfrog in this repo's workflow, so the fix is in the workflow or that step's own setup.

GitHub's error
Process completed with exit code 22.

View the step's logs →

Pullfrog  | Rerun failed job ➔ | View workflow run | via Pullfrog

@chatgpt-codex-connector

Copy link
Copy Markdown
Codex Review Summary: ❌ Failed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ❌ Failed 2026-11-12T09:18:19.334436Z
We couldn’t complete this review. Comment @codex review to try again.
3aa237f PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.

@vite-hub

vite-hub Bot commented Nov 12, 2026 •

Copy link
Copy Markdown
Contributor
Session Status Started Duration
Pending Completed Not started —

Latest result

Pull request merged.

Final answers

Session

Pull request merged.

Session

Updated the branch with main because main changed AGENTS.md after its checks ran; waiting for checks on the new head.

Session

Updated the branch with main because main changed AGENTS.md after its checks ran; waiting for checks on the new head.

Session

Updated the branch with main because main changed AGENTS.md after its checks ran; waiting for checks on the new head.

Session

Updated the branch with main because main changed AGENTS.md after its checks ran; waiting for checks on the new head.

Session

Updated the branch with main because main changed AGENTS.md after its checks ran; waiting for checks on the new head.

Session

Updated the branch with main because main changed AGENTS.md after its checks ran; waiting for checks on the new head.

Session

Updated the branch with main because main changed AGENTS.md after its checks ran; waiting for checks on the new head.

Session

Updated the branch with main because main changed AGENTS.md after its checks ran; waiting for checks on the new head.

Session

Waiting for review checks before the next pass.

Session

Waiting for review checks before the next pass.

@pkg-pr-new

pkg-pr-new Bot commented Nov 12, 2026 •

Copy link
Copy Markdown

Open in StackBlitz

comark-annotate

pnpm add https://pkg.pr.new/comark-annotate@411

comark-badge

pnpm add https://pkg.pr.new/comark-badge@411

comark-cards

pnpm add https://pkg.pr.new/comark-cards@411

comark-carousel

pnpm add https://pkg.pr.new/comark-carousel@411

comark-cast

pnpm add https://pkg.pr.new/comark-cast@411

comark-charts

pnpm add https://pkg.pr.new/comark-charts@411

comark-chat

pnpm add https://pkg.pr.new/comark-chat@411

comark-chips

pnpm add https://pkg.pr.new/comark-chips@411

comark-cjk

pnpm add https://pkg.pr.new/comark-cjk@411

comark-code

pnpm add https://pkg.pr.new/comark-code@411

comark-code-notes

pnpm add https://pkg.pr.new/comark-code-notes@411

comark-colors

pnpm add https://pkg.pr.new/comark-colors@411

comark-comments

pnpm add https://pkg.pr.new/comark-comments@411

comark-critic

pnpm add https://pkg.pr.new/comark-critic@411

comark-deflist

pnpm add https://pkg.pr.new/comark-deflist@411

comark-details

pnpm add https://pkg.pr.new/comark-details@411

comark-diagrams

pnpm add https://pkg.pr.new/comark-diagrams@411

comark-diff

pnpm add https://pkg.pr.new/comark-diff@411

comark-embed

pnpm add https://pkg.pr.new/comark-embed@411

comark-fields

pnpm add https://pkg.pr.new/comark-fields@411

comark-figure

pnpm add https://pkg.pr.new/comark-figure@411

comark-file-tree

pnpm add https://pkg.pr.new/comark-file-tree@411

comark-footnotes

pnpm add https://pkg.pr.new/comark-footnotes@411

comark-github

pnpm add https://pkg.pr.new/comark-github@411

comark-icon

pnpm add https://pkg.pr.new/comark-icon@411

comark-include

pnpm add https://pkg.pr.new/comark-include@411

comark-keys

pnpm add https://pkg.pr.new/comark-keys@411

comark-links

pnpm add https://pkg.pr.new/comark-links@411

comark-linter

pnpm add https://pkg.pr.new/comark-linter@411

comark-magic-move

pnpm add https://pkg.pr.new/comark-magic-move@411

comark-mark

pnpm add https://pkg.pr.new/comark-mark@411

markdown-it-to-comark

pnpm add https://pkg.pr.new/markdown-it-to-comark@411

marked-to-comark

pnpm add https://pkg.pr.new/marked-to-comark@411

comark-mathml

pnpm add https://pkg.pr.new/comark-mathml@411

comark-media

pnpm add https://pkg.pr.new/comark-media@411

comark-metrics

pnpm add https://pkg.pr.new/comark-metrics@411

migrate-to-comark

pnpm add https://pkg.pr.new/migrate-to-comark@411

comark-outline

pnpm add https://pkg.pr.new/comark-outline@411

comark-properties

pnpm add https://pkg.pr.new/comark-properties@411

comark-qr

pnpm add https://pkg.pr.new/comark-qr@411

comark-quiz

pnpm add https://pkg.pr.new/comark-quiz@411

comark-reading-time

pnpm add https://pkg.pr.new/comark-reading-time@411

remark-to-comark

pnpm add https://pkg.pr.new/remark-to-comark@411

comark-sources

pnpm add https://pkg.pr.new/comark-sources@411

comark-steps

pnpm add https://pkg.pr.new/comark-steps@411

comark-table

pnpm add https://pkg.pr.new/comark-table@411

comark-tabs

pnpm add https://pkg.pr.new/comark-tabs@411

comark-tests

pnpm add https://pkg.pr.new/comark-tests@411

comark-time

pnpm add https://pkg.pr.new/comark-time@411

comark-ui

pnpm add https://pkg.pr.new/comark-ui@411

comark-xref

pnpm add https://pkg.pr.new/comark-xref@411

comark-zoom

pnpm add https://pkg.pr.new/comark-zoom@411

commit: be8a53e

@vite-hub
vite-hub Bot merged commit f6e5998 into main Nov 12, 2026
5 of 6 checks passed
@vite-hub
vite-hub Bot deleted the feat/media-copy branch November 12, 2026 13:38
@github-actions github-actions Bot mentioned this pull request Nov 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant