Repository navigation
Conversation
Define the reviewed F/G engineering contracts and 32 ordered delivery candidates for managed storage, effective sandbox/network observation, independent installs and Reploy-owned recovery. Reuse typed destination overrides and existing runner/transports; preserve the systemd activation model and public mapped guards. Align the governing security/mail/E applicability notes, retain source-bound disposable proofs and conditional production/test forecasts, and refresh the affected document stamps and dependency closure. D/E implementation stays complete; runtime/native proof and exact-head PR approval remain separate gates. Keep the RDA cancellation request and backlog changes outside this design checkpoint. No production code, merge or release is included.
Code Review ✅ Approved🟡 Medium risk · The F/G design revises mapped-execution admission, storage, network, and recovery contracts; mistaken implementation could permit unintended retries or isolation gaps. Finalizes the F/G design documents for managed storage, sandbox/network observation, independent installs and Reploy-owned recovery, defining 32 ordered delivery candidates that reuse existing runner and transport paths. No production code is changed. No issues found. VerificationRules No rules evaluated Functional validation Not enabledFor more verification details, comment OptionsAuto-apply is off → Gitar will not commit updates to this branch. Comment with these commands to change the behavior for this request:
Was this helpful? React with 👍 / 👎 | Powered by Gitar — free for open source |
|
PR-cycle state — maintained automatically. Do not edit by hand. Mechanical PR-cycle state (JSON){
"approval": {
"candidate_revision_fingerprint": "sha256:536e9562667feaa1c65bb0c4b492a4c0a7a62d50af8cde55a0b27cefa723f2f2",
"evidence": {
"attestations": [
{
"baseline_identity": "sha256:284179960f35a7db15d62cf21421166c0738e48b66ff87d495ec3ede995267d9",
"closure_identity": "sha256:59eeba392fffe39013efdf92aa9c720e8911e82ff0d07a30ac947bf13f59ceae",
"document_identity": "sha256:078e63e84d432c2aad03120ca30e40ec4572a8970e6bf6be9d5008608a30f435",
"sidecar_identity": "sha256:fe94140fc892d31ec0eaf0cc96906842314d53ade1e99c913cd86dcad8ee51c6"
},
{
"baseline_identity": "sha256:284179960f35a7db15d62cf21421166c0738e48b66ff87d495ec3ede995267d9",
"closure_identity": "sha256:59eeba392fffe39013efdf92aa9c720e8911e82ff0d07a30ac947bf13f59ceae",
"document_identity": "sha256:7757ebe99b2135d9c7bf78ab29c844c2f1d956420a9fab6fea9dcdd0986f40a8",
"sidecar_identity": "sha256:d823048b6618dde3db3ac24cb37d0195f295d04ab3cc6e08c231877d042ee02a"
},
{
"baseline_identity": "sha256:284179960f35a7db15d62cf21421166c0738e48b66ff87d495ec3ede995267d9",
"closure_identity": "sha256:59eeba392fffe39013efdf92aa9c720e8911e82ff0d07a30ac947bf13f59ceae",
"document_identity": "sha256:78f9f1a1de6098b2b5653c5cd10096e7b0e5023230b1e9365638e317cc64fb95",
"sidecar_identity": "sha256:a5653caf76597556c5aa5fa75cc55a957901d9d658aff8dfd04dd776c5211389"
},
{
"baseline_identity": "sha256:284179960f35a7db15d62cf21421166c0738e48b66ff87d495ec3ede995267d9",
"closure_identity": "sha256:59eeba392fffe39013efdf92aa9c720e8911e82ff0d07a30ac947bf13f59ceae",
"document_identity": "sha256:f6049a45f86b96b5a7c6616926804871d77e8b86bf3305cc42d3910320fc5b76",
"sidecar_identity": "sha256:d35716f6647105764b587c353f36150e607bbed71f3cebebfdb575ed3abc23df"
},
{
"baseline_identity": "sha256:f42b08528a26c7ad252a8503cc9a13d6322ca0f53930e5dac2b56402fd450474",
"closure_identity": "sha256:59eeba392fffe39013efdf92aa9c720e8911e82ff0d07a30ac947bf13f59ceae",
"document_identity": "sha256:3013953a1cafa68f6b1175818a167fab5d61f406970a9f0c61621e23d8809e98",
"sidecar_identity": "sha256:ded569e9bb3812a1e4870c760952c2c3a7073c1d678a9e0b6c42184123097556"
},
{
"baseline_identity": "sha256:f42b08528a26c7ad252a8503cc9a13d6322ca0f53930e5dac2b56402fd450474",
"closure_identity": "sha256:59eeba392fffe39013efdf92aa9c720e8911e82ff0d07a30ac947bf13f59ceae",
"document_identity": "sha256:6f278d93ec80c42f9b905f990c585c1c9db7082cd7e7c2a827e9b840582b6c14",
"sidecar_identity": "sha256:1ede84337a6b0ac54483e68a688cd1b68bed3d05d7a288eb0ca3387c8e76d5eb"
},
{
"baseline_identity": "sha256:f42b08528a26c7ad252a8503cc9a13d6322ca0f53930e5dac2b56402fd450474",
"closure_identity": "sha256:59eeba392fffe39013efdf92aa9c720e8911e82ff0d07a30ac947bf13f59ceae",
"document_identity": "sha256:728d53f86612af0d6ba45c3d0fe84e61b41ac5e4f622b43132d2314775e389ab",
"sidecar_identity": "sha256:b47378d3869fc6c441ab078192b627767ddf96c725dbf70e456cf025f4dcef73"
},
{
"baseline_identity": "sha256:f42b08528a26c7ad252a8503cc9a13d6322ca0f53930e5dac2b56402fd450474",
"closure_identity": "sha256:59eeba392fffe39013efdf92aa9c720e8911e82ff0d07a30ac947bf13f59ceae",
"document_identity": "sha256:8a073c695effc36a3c2fd2baba3d8fcf85627e152968682154833270da627a5e",
"sidecar_identity": "sha256:28573c315f0e18d2fd966e0616d8d0f888a7ed956c211a95bc784c345acacca0"
}
],
"candidate_revision_fingerprint": "sha256:536e9562667feaa1c65bb0c4b492a4c0a7a62d50af8cde55a0b27cefa723f2f2",
"check_conclusions": [
{
"conclusion": "SUCCESS",
"name": "Bash native evidence checks",
"run_id": 124985540075
},
{
"conclusion": "SUCCESS",
"name": "Gitar",
"run_id": 124981429557
},
{
"conclusion": "SUCCESS",
"name": "Linux CI checks",
"run_id": 124981427928
},
{
"conclusion": "SUCCESS",
"name": "Target smoke (darwin-amd64)",
"run_id": 124981428099
},
{
"conclusion": "SUCCESS",
"name": "Target smoke (darwin-arm64)",
"run_id": 124981428103
},
{
"conclusion": "SUCCESS",
"name": "Target smoke (linux-amd64)",
"run_id": 124981428078
},
{
"conclusion": "SUCCESS",
"name": "Target smoke (linux-arm64)",
"run_id": 124981428165
},
{
"conclusion": "SUCCESS",
"name": "Windows host smoke (windows-amd64)",
"run_id": 124981428219
},
{
"conclusion": "SUCCESS",
"name": "Windows host smoke (windows-arm64)",
"run_id": 124981428140
}
],
"delivery_deferral_ledger_digest": "sha256:4f53cda18c2baa0c0354bb5f9a3ecbe5ed12ab4d8e11ba873c2f11161202b945",
"finding_dispositions_digest": "sha256:4f53cda18c2baa0c0354bb5f9a3ecbe5ed12ab4d8e11ba873c2f11161202b945",
"operation_identity": "sha256:0b52e41a74e3c54b1abee208f99384cd3bc97a9e4d0f3f9f66a26d3f43b37dfe",
"review_request": {
"body_digest": "sha256:fcccb6e7e06d854d6cab93dd85b6d935af96ea2758602613464224dd7d4ea779",
"id": 6564106196
},
"review_result": {
"body_digest": "sha256:b494f78478b2e54721bfc19dbc8b48fbc318db6d27017115e3b706f9b0211c50",
"id": 6564117505
}
},
"evidence_fingerprint": "sha256:177f3bcaab3bfa50dc51e60f104d4857e07337644f93e7e615d48ee95e3217f9",
"head_sha": "faf58d145caf48e82419d905f145b4d45c7b0fa4",
"operation_identity": "sha256:0b52e41a74e3c54b1abee208f99384cd3bc97a9e4d0f3f9f66a26d3f43b37dfe",
"review_request_id": 6564106196,
"review_result_id": 6564117505,
"status": "approved-evidence-recorded"
},
"candidate_revision_fingerprint": "sha256:536e9562667feaa1c65bb0c4b492a4c0a7a62d50af8cde55a0b27cefa723f2f2",
"check_conclusions": [
{
"conclusion": "SUCCESS",
"name": "Bash native evidence checks",
"run_id": 124985540075
},
{
"conclusion": "SUCCESS",
"name": "Gitar",
"run_id": 124981429557
},
{
"conclusion": "SUCCESS",
"name": "Linux CI checks",
"run_id": 124981427928
},
{
"conclusion": "SUCCESS",
"name": "Target smoke (darwin-amd64)",
"run_id": 124981428099
},
{
"conclusion": "SUCCESS",
"name": "Target smoke (darwin-arm64)",
"run_id": 124981428103
},
{
"conclusion": "SUCCESS",
"name": "Target smoke (linux-amd64)",
"run_id": 124981428078
},
{
"conclusion": "SUCCESS",
"name": "Target smoke (linux-arm64)",
"run_id": 124981428165
},
{
"conclusion": "SUCCESS",
"name": "Windows host smoke (windows-amd64)",
"run_id": 124981428219
},
{
"conclusion": "SUCCESS",
"name": "Windows host smoke (windows-arm64)",
"run_id": 124981428140
}
],
"check_observations": [
{
"checks": [
{
"conclusion": "SUCCESS",
"name": "Bash native evidence checks",
"run_id": 124985540075,
"run_status": "completed",
"status": "success",
"url": "https://github.com/omry/reploy/actions/runs/41351171397/job/124985540075"
},
{
"conclusion": "SUCCESS",
"name": "Gitar",
"run_id": 124981429557,
"run_status": "completed",
"status": "success",
"url": "https://github.com/omry/reploy/runs/124981429557"
},
{
"conclusion": "SUCCESS",
"name": "Linux CI checks",
"run_id": 124981427928,
"run_status": "completed",
"status": "success",
"url": "https://github.com/omry/reploy/actions/runs/41351171397/job/124981427928"
},
{
"conclusion": "SUCCESS",
"name": "Target smoke (darwin-amd64)",
"run_id": 124981428099,
"run_status": "completed",
"status": "success",
"url": "https://github.com/omry/reploy/actions/runs/41351171397/job/124981428099"
},
{
"conclusion": "SUCCESS",
"name": "Target smoke (darwin-arm64)",
"run_id": 124981428103,
"run_status": "completed",
"status": "success",
"url": "https://github.com/omry/reploy/actions/runs/41351171397/job/124981428103"
},
{
"conclusion": "SUCCESS",
"name": "Target smoke (linux-amd64)",
"run_id": 124981428078,
"run_status": "completed",
"status": "success",
"url": "https://github.com/omry/reploy/actions/runs/41351171397/job/124981428078"
},
{
"conclusion": "SUCCESS",
"name": "Target smoke (linux-arm64)",
"run_id": 124981428165,
"run_status": "completed",
"status": "success",
"url": "https://github.com/omry/reploy/actions/runs/41351171397/job/124981428165"
},
{
"conclusion": "SUCCESS",
"name": "Windows host smoke (windows-amd64)",
"run_id": 124981428219,
"run_status": "completed",
"status": "success",
"url": "https://github.com/omry/reploy/actions/runs/41351171397/job/124981428219"
},
{
"conclusion": "SUCCESS",
"name": "Windows host smoke (windows-arm64)",
"run_id": 124981428140,
"run_status": "completed",
"status": "success",
"url": "https://github.com/omry/reploy/actions/runs/41351171397/job/124981428140"
}
],
"head_sha": "faf58d145caf48e82419d905f145b4d45c7b0fa4",
"id": "sha256:4279ebbbb2a0f3581332074646adc657d908a99d914120ce6a56215f82d732a6",
"required_checks": [
"Bash native evidence checks",
"Gitar",
"Linux CI checks",
"Target smoke (darwin-amd64)",
"Target smoke (darwin-arm64)",
"Target smoke (linux-amd64)",
"Target smoke (linux-arm64)",
"Windows host smoke (windows-amd64)",
"Windows host smoke (windows-arm64)"
],
"status": "success"
}
],
"delivery_deferral_ledger_digest": "sha256:4f53cda18c2baa0c0354bb5f9a3ecbe5ed12ab4d8e11ba873c2f11161202b945",
"delivery_deferrals": [],
"findings": [],
"pr": {
"base_ref": "main",
"base_sha": "833e2d5b4c89a70f49f5ded3edb1190ba7b88a18",
"body_digest": "sha256:77aed85d24833ad8da0bb6f08a46b8d62fb0acb4384c47fcbf14e4f59b492e37",
"body_identity_version": 2,
"diff_digest": "sha256:cdc968db369fdf014d987340cda93127ff21d6a08ef0990173eaf5113499884c",
"head_ref": "pr318",
"head_sha": "faf58d145caf48e82419d905f145b4d45c7b0fa4",
"pr": 318,
"repository": "omry/reploy",
"scope_authority": [],
"title_digest": "sha256:b337e74610e5cac0f21a78d3ac7d4f203a8021bac998b46d9f00a31b27fc7d55"
},
"record_version": 4,
"review_observations": [],
"review_requests": [
{
"base_established_at": "2026-11-01T21:16:34Z",
"base_ref": "main",
"base_sha": "833e2d5b4c89a70f49f5ded3edb1190ba7b88a18",
"body_digest": "sha256:fcccb6e7e06d854d6cab93dd85b6d935af96ea2758602613464224dd7d4ea779",
"created_at": "2026-11-01T21:25:34Z",
"head_sha": "faf58d145caf48e82419d905f145b4d45c7b0fa4",
"id": 6564106196,
"kind": "regular-review"
}
],
"review_results": [
{
"base_ref": "main",
"base_sha": "833e2d5b4c89a70f49f5ded3edb1190ba7b88a18",
"body_digest": "sha256:b494f78478b2e54721bfc19dbc8b48fbc318db6d27017115e3b706f9b0211c50",
"commit_id": "faf58d145caf48e82419d905f145b4d45c7b0fa4",
"id": 6564117505,
"inline_message_ids": [],
"request_comment_id": 6564106196,
"result_kind": "clean",
"status": "result",
"submitted_at": "2026-11-01T21:26:33Z",
"unresolved_thread_ids": []
}
],
"revision_fingerprint": "sha256:536e9562667feaa1c65bb0c4b492a4c0a7a62d50af8cde55a0b27cefa723f2f2",
"rounds": [
{
"applied_fix_paths": [],
"disposition_changes": [],
"effective_diff_digest": "sha256:cdc968db369fdf014d987340cda93127ff21d6a08ef0990173eaf5113499884c",
"finding_ids": [],
"invariants": [
"Current approved F/G design scope, public mapped guards, independent destination authority and exact stamp closure preserved"
],
"outcome": "clean",
"proposed_fix_paths": [],
"resulting_head": "faf58d145caf48e82419d905f145b4d45c7b0fa4",
"review_observation_id": null,
"review_request_id": 6564106196,
"review_result_id": 6564117505,
"reviewed_head": "faf58d145caf48e82419d905f145b4d45c7b0fa4",
"root_cause": null,
"round": 1,
"unresolved_current_slice_findings": 0,
"unresolved_design_blockers": 0
}
],
"schema": "awd:swe:pr-cycle-state",
"version": 2
} |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Codex Review: Didn't find any major issues. Breezy! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Define the reviewed F/G engineering contracts and 32 ordered delivery candidates for managed storage, effective sandbox/network observation, independent installs and Reploy-owned recovery. Reuse typed destination overrides and existing runner/transports; preserve the systemd activation model and public mapped guards.
Align the governing security/mail/E applicability notes, retain source-bound disposable proofs and conditional production/test forecasts, and refresh the affected document stamps and dependency closure. D/E implementation stays complete; runtime/native proof and exact-head PR approval remain separate gates.
Keep the RDA cancellation request and backlog changes outside this design checkpoint. No production code, merge or release is included.