Skip to content

stream: more iter streams fixes - #66030

Open
jasnell wants to merge 7 commits into
nodejs:mainfrom
jasnell:jasnell/moar-iter-streams-2
Open

jasnell wants to merge 7 commits into
nodejs:mainfrom
jasnell:jasnell/moar-iter-streams-2

Conversation

@jasnell

@jasnell jasnell commented Sep 15, 2026

Copy link
Copy Markdown
Member

Another round of streams/iter fixes.

Builds on: #66028 ... The first four commits are from that PR. This will remain a draft until that one lands

@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/streams

@nodejs-github-bot nodejs-github-bot added lib / src Issues and PRs involving general changes in the lib/ or src/ directories. needs-ci PRs that need a full CI run. labels Sep 15, 2026
@jasnell
jasnell requested review from panva and trivikr September 15, 2026 03:54
@jasnell
jasnell marked this pull request as draft September 15, 2026 03:54
@codecov

codecov Bot commented Sep 15, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 89.27790% with 49 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.26%. Comparing base (fa95cd5) to head (d0ff99c).
⚠️ Report is 40 commits behind head on main.

Files with missing lines Patch % Lines
lib/internal/streams/iter/from.js 86.25% 32 Missing and 4 partials ⚠️
lib/internal/streams/iter/pull.js 88.23% 6 Missing ⚠️
lib/internal/streams/iter/share.js 90.32% 2 Missing and 1 partial ⚠️
lib/internal/streams/iter/utils.js 93.61% 3 Missing ⚠️
lib/internal/streams/iter/broadcast.js 97.14% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #66030      +/-   ##
==========================================
- Coverage   90.27%   90.26%   -0.01%     
==========================================
  Files         789      789              
  Lines      271623   271894     +271     
  Branches    51847    51911      +64     
==========================================
+ Hits       245196   245416     +220     
- Misses      16910    16951      +41     
- Partials     9517     9527      +10     
Files with missing lines Coverage Δ
lib/internal/streams/iter/consumers.js 97.09% <100.00%> (+0.14%) ⬆️
lib/internal/streams/iter/duplex.js 97.47% <100.00%> (+0.25%) ⬆️
lib/internal/streams/iter/broadcast.js 90.50% <97.14%> (+0.33%) ⬆️
lib/internal/streams/iter/share.js 89.32% <90.32%> (-0.20%) ⬇️
lib/internal/streams/iter/utils.js 97.04% <93.61%> (-1.36%) ⬇️
lib/internal/streams/iter/pull.js 83.82% <88.23%> (+0.06%) ⬆️
lib/internal/streams/iter/from.js 87.99% <86.25%> (-0.85%) ⬇️

... and 34 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@panva panva left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Asssisted-by: Codex

Comment thread lib/internal/streams/iter/share.js Outdated
Signed-off-by: James M Snell <jasnell@gmail.com>
Assisted-by: Opencode
Signed-off-by: James M Snell <jasnell@gmail.com>
Assisted-by: Opencode
Signed-off-by: James M Snell <jasnell@gmail.com>
Assisted-by: Opencode
Signed-off-by: James M Snell <jasnell@gmail.com>
Assisted-by: Opencode
…st paths

Signed-off-by: James M Snell <jasnell@gmail.com>
Assisted-by: Opencode
Signed-off-by: James M Snell <jasnell@gmail.com>
Assisted-by: Opencode
@jasnell
jasnell force-pushed the jasnell/moar-iter-streams-2 branch from 195c895 to a409c52 Compare September 17, 2026 06:08
@jasnell
jasnell marked this pull request as ready for review September 17, 2026 06:09
Signed-off-by: James M Snell <jasnell@gmail.com>
Assisted-by: Opencode
@jasnell jasnell added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Sep 17, 2026
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Sep 17, 2026
@nodejs-github-bot

This comment was marked as outdated.

@nodejs-github-bot

nodejs-github-bot commented Sep 18, 2026

Copy link
Copy Markdown
Collaborator

@jasnell jasnell added author ready PRs with CI started, the required approvals, and no outstanding review comments. commit-queue-rebase PRs the Commit Queue should land as multiple self-contained commits. labels Sep 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. commit-queue-rebase PRs the Commit Queue should land as multiple self-contained commits. lib / src Issues and PRs involving general changes in the lib/ or src/ directories. needs-ci PRs that need a full CI run.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants