Skip to content

stream: apply more stream/iter fixes, round 3 - #66079

Open
jasnell wants to merge 7 commits into
nodejs:mainfrom
jasnell:jasnell/moar-iter-streams-3
Open

jasnell wants to merge 7 commits into
nodejs:mainfrom
jasnell:jasnell/moar-iter-streams-3

Conversation

@jasnell

@jasnell jasnell commented Sep 17, 2026

Copy link
Copy Markdown
Member

See each individual commits.

Stacks on #66030 the first seven commits here are from there.. this will remain draft until that lands

@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/quic
  • @nodejs/streams

@nodejs-github-bot nodejs-github-bot added lib / src Issues and PRs involving general changes in the lib/ or src/ directories. needs-ci PRs that need a full CI run. labels Sep 17, 2026
Signed-off-by: James M Snell <jasnell@gmail.com>
Assisted-by: Opencode
@jasnell
jasnell force-pushed the jasnell/moar-iter-streams-3 branch from 8bc2e10 to 345be6c Compare September 22, 2026 16:26
Signed-off-by: James M Snell <jasnell@gmail.com>
Assisted-by: Opencode
Signed-off-by: James M Snell <jasnell@gmail.com>
Assisted-by: Opencode
Signed-off-by: James M Snell <jasnell@gmail.com>
Assisted-by: Opencode
Signed-off-by: James M Snell <jasnell@gmail.com>
Assisted-by: Opencode
Signed-off-by: James M Snell <jasnell@gmail.com>
Just say no to `new Promise(() => timer(...))` use
promisified timers

Signed-off-by: James M Snell <jasnell@gmail.com>
@jasnell
jasnell force-pushed the jasnell/moar-iter-streams-3 branch from 345be6c to 0b2fffe Compare September 22, 2026 16:27
@jasnell
jasnell marked this pull request as ready for review September 22, 2026 16:27
@codecov

codecov Bot commented Sep 22, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 87.93605% with 83 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.29%. Comparing base (c0ed28f) to head (0b2fffe).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
lib/internal/streams/iter/classic.js 85.97% 61 Missing and 7 partials ⚠️
lib/internal/streams/iter/transform.js 81.25% 14 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##             main   #66079    +/-   ##
========================================
  Coverage   90.29%   90.29%            
========================================
  Files         790      790            
  Lines      272883   273284   +401     
  Branches    52118    52214    +96     
========================================
+ Hits       246387   246757   +370     
- Misses      16943    16985    +42     
+ Partials     9553     9542    -11     
Files with missing lines Coverage Δ
lib/internal/quic/quic.js 100.00% <100.00%> (ø)
lib/internal/streams/iter/broadcast.js 90.55% <100.00%> (+0.04%) ⬆️
lib/internal/streams/iter/pull.js 83.87% <100.00%> (+0.05%) ⬆️
lib/internal/streams/iter/share.js 89.35% <100.00%> (+0.03%) ⬆️
lib/internal/streams/iter/transform.js 92.49% <81.25%> (-3.35%) ⬇️
lib/internal/streams/iter/classic.js 90.23% <85.97%> (+1.26%) ⬆️

... and 25 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lib / src Issues and PRs involving general changes in the lib/ or src/ directories. needs-ci PRs that need a full CI run.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants