Skip to content

fix(phone-connect): use detached version of runAsync() to launch file browser #254

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
jinliu wants to merge 1 commit into
base: main
Choose a base branch
from
+2 −2
Draft

fix(phone-connect): use detached version of runAsync() to launch file browser #254

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion phone-connect/plugin.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@

id = "icefish/phone-connect"
name = "Phone Connect"
version = "0.1.1"
version = "0.1.2"
plugin_api = 16
Comment on lines 13 to 16
author = "icefish"
license = "MIT"
Expand Down
2 changes: 1 addition & 1 deletion phone-connect/service.luau
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -603,7 +603,7 @@ local function handleCommand(cmd)
local first = (res.stdout or ""):match("'([^']+)'")
if first then dirPath = first end
end
noctalia.runAsync("xdg-open " .. shellQuote(dirPath), function() end)
noctalia.runAsync("xdg-open " .. shellQuote(dirPath))
noctalia.notify(t("notify.opening_browser"), dirPath)
end)
end)
Expand Down
Loading