fix(phone-connect): use detached version of runAsync() to launch file browser - #254
Draft
jinliu wants to merge 1 commit into
Draft
fix(phone-connect): use detached version of runAsync() to launch file browser#254jinliu wants to merge 1 commit into
jinliu wants to merge 1 commit into
Conversation
… browser Otherwise, it will be closed after the 5 seconds timeout.
Contributor
|
CC @CSY2569 |
There was a problem hiding this comment.
Pull request overview
This PR updates the icefish/phone-connect plugin to keep the “Browse” action’s file browser from being closed by switching the xdg-open launch to a fire-and-forget noctalia.runAsync() invocation.
Changes:
- Update the Browse handler to call
noctalia.runAsync("xdg-open ...")without a no-op callback. - Bump plugin version from
0.1.1to0.1.2.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| phone-connect/service.luau | Adjusts how the Browse action launches xdg-open to avoid premature termination/timeout behavior. |
| phone-connect/plugin.toml | Bumps the plugin version for the behavioral fix release. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
13
to
16
| id = "icefish/phone-connect" | ||
| name = "Phone Connect" | ||
| version = "0.1.1" | ||
| version = "0.1.2" | ||
| plugin_api = 16 |
ItsLemmy
marked this pull request as draft
August 5, 2026 21:40
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Plugin
icefish/phone-connectplugin.toml)What it does
To fix the bug that the file browser launched from the "Browse" button is closed after the 5 seconds timeout.
External dependencies
Unchanged.
Testing
Screenshots / Videos
Checklist
idafter the/inplugin.tomlexactly.plugin.toml,README.md,thumbnail.webp, andtranslations/en.json.README.mdfollows theREADME template, documents
every entry id and dependency, and includes exact panel IPC commands and launcher prefixes where applicable.
thumbnail.webpwith the thumbnail generator.versionfollows semver and is bumped in this PR;plugin_apiis the oldest API level this plugin requires.understand that language well enough to review and maintain it (no unreviewed machine/LLM translations).
catalog.toml; CI generates it.Code review attestation
Plugins run as trusted, unsandboxed Luau in the user's session. Confirm:
licensedeclared inplugin.toml.