Skip to content

fix(phone-connect): use detached version of runAsync() to launch file browser - #254

Draft
jinliu wants to merge 1 commit into
noctalia-dev:mainfrom
jinliu:fix/phone-connect-browse-timeout
Draft

fix(phone-connect): use detached version of runAsync() to launch file browser#254
jinliu wants to merge 1 commit into
noctalia-dev:mainfrom
jinliu:fix/phone-connect-browse-timeout

Conversation

@jinliu

@jinliu jinliu commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

Plugin

  • Id: icefish/phone-connect
  • New plugin
  • Update to an existing plugin (version bumped in plugin.toml)

What it does

To fix the bug that the file browser launched from the "Browse" button is closed after the 5 seconds timeout.

External dependencies

Unchanged.

Testing

  • Tested on Niri
  • Tested on Hyprland
  • Tested on Sway
  • Tested on another compositor:
  • Noctalia version tested against: 5.0
  • Plugin API level: 16

Screenshots / Videos

Checklist

  • The directory name matches the part of id after the / in plugin.toml exactly.
  • It ships plugin.toml, README.md, thumbnail.webp, and translations/en.json.
  • README.md follows the
    README template, documents
    every entry id and dependency, and includes exact panel IPC commands and launcher prefixes where applicable.
  • I created thumbnail.webp with the thumbnail generator.
  • version follows semver and is bumped in this PR; plugin_api is the oldest API level this plugin requires.
  • Every non-English translation in this PR uses a locale supported by Noctalia core, and I can read, write, and
    understand that language well enough to review and maintain it (no unreviewed machine/LLM translations).
  • I did not edit catalog.toml; CI generates it.
  • This PR touches exactly one plugin directory.

Code review attestation

Plugins run as trusted, unsandboxed Luau in the user's session. Confirm:

  • The code is readable and not obfuscated, minified, or generated.
  • It does not download and execute remote code.
  • Every network call, filesystem write, and spawned process is something the description above accounts for.
  • I have the right to publish this code under the license declared in plugin.toml.

… browser

Otherwise, it will be closed after the 5 seconds timeout.
Copilot AI lite review requested due to automatic review settings August 5, 2026 03:52
@github-actions

github-actions Bot commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

CC @CSY2569

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the icefish/phone-connect plugin to keep the “Browse” action’s file browser from being closed by switching the xdg-open launch to a fire-and-forget noctalia.runAsync() invocation.

Changes:

  • Update the Browse handler to call noctalia.runAsync("xdg-open ...") without a no-op callback.
  • Bump plugin version from 0.1.1 to 0.1.2.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
phone-connect/service.luau Adjusts how the Browse action launches xdg-open to avoid premature termination/timeout behavior.
phone-connect/plugin.toml Bumps the plugin version for the behavioral fix release.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread phone-connect/plugin.toml
Comment on lines 13 to 16
id = "icefish/phone-connect"
name = "Phone Connect"
version = "0.1.1"
version = "0.1.2"
plugin_api = 16
@ItsLemmy
ItsLemmy marked this pull request as draft August 5, 2026 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants