[wasud]

Decisions to review

• Labels (checklog): Odoo 18 warns when two fields share a label, and checklog-odoo fails CI on warnings. Our own fields get distinct labels:

  • ni.encounter: name keeps "Encounter No." and identifier becomes "Encounter Identifier" (the form header still reads "Encounter No."), location_history_count "Location Moves", participant_id "Current Participant", show_chief_complaint/show_participant "Show …".
  • ni.patient.encounter_id "Current Encounter".
  • res.partner.patient "Is a Patient".
  • ni.encounter.class.sequence_id "Identifier Sequence".
  • ni.location.encounter_active_* "Active Encounter(s)…".

  The Thai translations of these labels are distinct too: รหัสรับบริการ / เลขที่รับบริการ / รหัสรับบริการปัจจุบัน, รายการ/จำนวนรับบริการปัจจุบัน, ผู้ดูแลปัจจุบัน / แสดงผู้ดูแล, แสดงอาการสำคัญ, จำนวนการย้ายสถานที่. The one clash that isn't ours (res.users birthdate from partner_age vs hr's birthday, both "Date of Birth") gets a precise ignore line in checklog-odoo.cfg.

• Partner search: res.partner search now ORs core's _search_display_name with exact phone/mobile/identification number. Up to 17 it replaced core's partner name search; now email/ref/VAT also match, as [MIG 19.0][P1-2] ni_patient #137 recommends.

What changed

• ni_patient replayed from the 17.0 PR branch, then [MIG] ni_patient: Migration to 18.0.
• Migrator: tree → list and view_mode; removed migrations/17.0.1.0.0 (OCA keeps only the current version's scripts).
• Views:
  • <chatter/> in the patient and encounter forms.
  • Encounter kanban rewritten as an 18 card (highlight_color, menu template with kanban_color_picker, footer).
  • Patient kanban card restructured to aside/main.
  • The kanban button context uses id instead of active_id.
• Python:
  • _has_cycle() with odoo.exceptions.ValidationError (location, encounter class).
  • has_access("read") in the portal controller.
  • Cron without numbercall/doall.
  • Plain strings in _sql_constraints (_() at import time warns in 18).
  • Lazy logging and f-strings (newer ruff).
• Computes: stored and non-stored fields split into separate methods (18 warns otherwise): ni.patient encounter count/start, res.partner.patient_id, ni.location active encounters.
• ni.encounter.display_age: keeps showing the age at encounter start, through its own _compute_display_age (partner_age split that compute in [18.0][MIG] ni_period, ni_identifier, ni_coding, partner_age, partner_gender, partner_religion, uom_alias: Migration to 18.0 #148).
• ni.encounter._check_birthdate: disabled; birthdate is a read-only related field validated on the patient.
• JS: /** @odoo-module **/ dropped.
• Tests: the duplicate-patient test asserts IntegrityError under mute_logger("odoo.sql_db") (its expected SQL error would fail checklog).
• oe_structure id in the summary report; README and th.po updated.

Why

Part of #137 (P1-2, epic #131).

Migration notes

• Effort: L.
• What the migrator did: list views only.
• Surprises:
  • 18 checklog turns many deprecation/label warnings into CI failures.
  • The kanban card cannot evaluate Python % in t-att-src (it rendered NaN), so it uses t-attf-src.
  • The kanban button active_id fails view validation.

How tested

• Unit/integration tests: 32 tests pass on 18; the log has no WARNING/ERROR lines (checklog equivalent).
• Manual check (browser, Odoo 18 with demo data):
  • patient kanban (new card layout), list, and Archive from the list opening the archive wizard;
  • encounter kanban (patient image now loads) and form (chatter, age at encounter);
  • portal /my/home entry and /my/patients.
• pre-commit run -a clean.

Documentation

• Module README.md updated (partner search, computed fields)

Notes for reviewer

• Fix (2026-10-14): odoo-module-migrate 17 rewrote Thai text in XML (comments, string, placeholder) as &#NNNN; entities, and prettier then split one of them with spaces. The Thai text is back as UTF-8.
• Fix (2026-10-14): from 17.0, invisible="1" on a list field only hides the cells, so the column header still shows. Hidden list fields now use column_invisible="1". Found in the browser check of ni_observation ([MIG 19.0][P1-4] ni_observation #139).
• Stacked on [18.0][MIG] ni_period, ni_identifier, ni_coding, partner_age, partner_gender, partner_religion, uom_alias: Migration to 18.0 #148 (P1-1 18.0) and [17.0][MIG] ni_patient: Migration to 17.0 #153 (ni_patient 17.0).

[piruin]

Review

No blockers.

Minor

• ni.encounter.name is now labelled "Encounter Name", but the field holds the encounter number. That label shows in list headers, search and exports. Consider swapping, e.g. keep "Encounter No." on name and give identifier a distinct label.
• The new English labels are unique, but some of their Thai translations are still identical. The same-label warning only checks English, so Thai users will see two identical entries in the filter, group-by and export menus:
  • "Encounter Name" and "Current Encounter" are both รหัสรับบริการ.
  • "Active Encounters" and "Active Encounter Count" are both ข้อมูลรับบริการ.
  • "Show Participant" and "Current Participant" are both ผู้ดูแล.
• The PR body says location_history_count is labelled "Location History", but the code says "Location Moves". #155 also lists that rename as a 19.0 change.

Checked, OK

• _has_cycle() raises odoo.exceptions.ValidationError, has_access("read") is used in the portal controller, and the cron fields are removed.
• Stored and non-stored computes are split, and the browse(rec._get_encounter_active_ids()) call gets ids, so it's fine.
• _search_display_name ORs with core's search instead of replacing it.
• The duplicate-patient test asserts IntegrityError under mute_logger.
• CI is green, and the commit series ends with [IMP] pre-commit auto fixes + [MIG].

[wasud]

Thanks. Fixed in the [MIG] commit (now 1b80cdea) and replayed in #155:

• ni.encounter.name is back to "Encounter No.", and identifier is now "Encounter Identifier". The form header uses <label for="identifier" string="Encounter No."/>, so it still reads "Encounter No.".
• Thai translations of these labels are now distinct:
  • Encounter No. = รหัสรับบริการ, Encounter Identifier = เลขที่รับบริการ, Current Encounter = รหัสรับบริการปัจจุบัน
  • Active Encounters = รายการรับบริการปัจจุบัน, Active Encounter Count = จำนวนรับบริการปัจจุบัน
  • Current Participant = ผู้ดูแลปัจจุบัน, Show Participant = แสดงผู้ดูแล
  • I also fixed two other new labels that clashed within ni.encounter: Show Chief Complaint = แสดงอาการสำคัญ, Location Moves = จำนวนการย้ายสถานที่
  • I only edited the affected th.po blocks, taking the references from a fresh export.
• PR body: location_history_count is now "Location Moves" there too, and [19.0][MIG] ni_patient: Migration to 19.0 #155 no longer lists that rename as a 19.0 change.
• The ni_coding default-views test moved to ni_coding/tests/, as in [17.0][MIG] ni_patient: Migration to 17.0 #153.