[wasud]

Decisions to review

• Security: the read rules without a group on observation reference data are split into base.group_user + base.group_portal + base.group_public rows, the same as P1-1 ([MIG 19.0][P1-1] Foundation: ni_period, ni_identifier, ni_coding, partner_age, partner_gender, partner_religion, uom_alias #136). Access is unchanged, but the security file changes.

• Field labels: 18 warns on duplicate labels, and the template's checklog-odoo fails CI on any warning. Renamed labels:

  • "Value (Text)", "Value (Integer)", "Value (Decimal)", "Value (Code)";
  • "Effective Date" (effective_date), "Observation Code" (code_id);
  • "Sheet Name" (sheet name), "Sheet Created by/on" (wizard).

  Views that show a single value column keep the label "Value". Graph and pivot measures now show "Value (Decimal)"/"Value (Integer)".

• D7, list widget: re-ported from core account 18 (static template/components, this.columns, the new <attribute add> syntax).

What changed

• [IMP] pre-commit and [MIG] ni_observation: Migration to 18.0 on top of the 17.0 PR.
• Migrator: tree → list, kanban-box → card (rename only), unaccent=False removed, version.
• Kanban (manual):
  • Sheet kanban: no oe_kanban_global_click wrapper, kanban_image → many2one_avatar_user in a <footer>, quick_add removed (not a kanban attribute).
  • Sheet line cards (mobile): wrapper removed.
  • Latest-observation kanbans (report/):
    • rewritten with highlight_color, <templates> and <footer>;
    • the 16 view used <template> and kanban_color.
• Models:
  • group_operator → aggregator.
  • _check_recursion() → _has_cycle(), with odoo.exceptions.ValidationError.
  • Related display_class and the report value_type no longer redefine the selection (18 warnings).
  • Report sequence drops the inherited default ("Redundant default").
  • SQL views use SQL() and SQL.identifier.
• Other:
  • Cron without numbercall/doall.
  • default_period="year,year-1" (the 17 ids this_year,last_year fail validation on 18).
  • SCSS selector .o_kanban_record.
  • JS without the @odoo-module header.
• Bug fixed: _('Not found match value for "%s"!' % value) formatted the string before translating it. It now uses a named placeholder.
• th.po regenerated, 17.0 translations merged, distinct Thai labels for the renamed fields.

Why

Part of #139 (P1-4, epic #131).

Migration notes

• Effort: M.
• What the migrator did: tree/view_mode, the kanban-box rename, unaccent.
• Manual work:
  • Kanban cards.
  • aggregator, _has_cycle, cron.
  • Duplicate labels and selection warnings.
  • ACL groups, default_period, D7 renderer.
• Surprises:
  • The issue says ace → code_editor, but 18 and 19 have no code_editor widget; ace (alias code) is still registered, so it stays.
  • default_period ids changed again in 18.
  • Fresh install is clean, but -u showed "Redundant default" warnings, which the template checklog would catch.

How tested

• Unit/integration tests: 25 tests pass on 18 (fresh DB); install and -u log have no WARNING lines (checklog-equivalent).
• Manual check (browser, Odoo 18 with demo data):
  • sheet form: sections, value columns, interpretation, BP computes "150 / 95";
  • sheet kanban card (vital signs summary, recorder);
  • encounter Vital Signs tab, "New Vital Sign" (sheet with preset category);
  • Observation wizard with two categories → line list → Save;
  • mobile width: latest-observation cards in the encounter, sheet line cards;
  • no JS console errors.
• pre-commit clean on ni_observation.

Documentation

• Module README.md updated (18.0, field labels, security)

Notes for reviewer

• Added after review started (P1-6 pilot, [MIG 19.0][P1-6] Data migration pilot: OpenUpgrade 16→17→18→19 on Phase 1 modules #141): [FIX] ni_observation: pick the latest observation deterministically (same as [17.0][MIG] ni_observation: Migration to 17.0 #156): tie-breaker id DESC in both latest-observation views, plus a test.

• Stacked on [17.0][MIG] ni_observation: Migration to 17.0 #156 (17.0) and [18.0][MIG] ni_patient: Migration to 18.0 #154 (P1-2 18.0). Merge those first.

[piruin]

Review

No blockers.

Checked, OK

• The access rules that had no group become base.group_user + base.group_portal + base.group_public rows, which gives the same access as before.
• aggregator replaces group_operator, and _has_cycle() raises odoo.exceptions.ValidationError. The SQL views use SQL() / SQL.identifier.
• The translation bug _('…' % value) now uses a named placeholder.
• Dropping the selection list from the report's value_type is safe: it inherits the list from ni.observation.abstract.
• CI is green, and the series ends with [IMP] pre-commit auto fixes + [MIG].

Minor

• display_class (related) lost default="text", so a line with no interpretation now has False instead of "text". Please check that no view's decoration-* or class expression depended on "text".

[wasud]

Checked the display_class minor item: no change needed.

• display_class is a non-stored related field (interpretation_id.display_class). With no interpretation the related compute gives False on 16/17 as well, and the old default="text" only applied to a new record before the compute ran. So stored data and saved records behave the same.
• No view depends on "text": every decoration-* compares with danger/info/muted/primary/success/warning, and the only class expression (sheet kanban, ni_observation_sheet_views.xml:286) already treats 'text' and false the same (text-body).
• ni_questionnaire copies interpretation_id.display_class (the stored field on ni.observation.interpretation) into survey.grade.color_class, so it does not read this field.