Skip to content

add four new appreciation options to the dialog - #910

Open
ivannissimrch wants to merge 2 commits into
developfrom
ivannissimrch/872-appreciation-options
Open

add four new appreciation options to the dialog#910
ivannissimrch wants to merge 2 commits into
developfrom
ivannissimrch/872-appreciation-options

Conversation

@ivannissimrch

Copy link
Copy Markdown
Collaborator

Description

Adds the four new options to the Add Appreciation dialog: Need4Deed certificate, cap, notebook and city certificate. Previously, only tote bag, t-shirt, and benefit card were offered.

Blocked on the backend.
Saving one of the new options currently returns a 400. sdk-types.json in the backend still lists only the old three values, so the request is rejected during validation. Issue: 837. Everything else is in place; the database migration and the SDK both have all seven.

Related Issues

Closes #872

Changes

  • Four entries added to APPRECIATION_TYPES in AppreciationDialog.tsx
  • German cityCertificate corrected to Senatsurkunde

Screenshots / Demos

Screenshot from 2026-08-05 22-55-29

Checklist

  • WITHIN THE SCOPE OF AN ISSUE; No unnecessary files included
  • Tests added/updated
  • Documentation updated
  • CI passes

@ivannissimrch

Copy link
Copy Markdown
Collaborator Author

Note on order: this needs BE 845 to merge first. Until then, the four new options appear in the dialog, but saving one returns a 400, since the request validation schema still lists only the original three values.

@nadavosa

Copy link
Copy Markdown
Collaborator

Review

Small, clean addition — four new APPRECIATION_TYPES entries with matching translation keys, plus a German label correction (Senatsurkunde). Nothing concerning in the diff itself; the enum values already exist in the pinned SDK version and CI is green.

Good news on the blocker you noted: be#845 ("Unblocks #910") merged on 2026-08-07 and adds the four new values to the backend's request validation schema — be#837 is now closed. One thing worth checking before merging/testing this: as of right now the deployed be production commit is still from before that merge (nothing has auto-deployed since), so saving one of the new options will likely still 400 until that's actually live — worth confirming it's deployed before you rely on this working end-to-end.

@need4deed
need4deed requested a review from nadavosa August 10, 2026 20:22
@ivannissimrch

Copy link
Copy Markdown
Collaborator Author

Checked the deploy. Dev has it; dev.need4deed.org/swagger/json lists all four values, so this works end to end there. Production does not; main has not moved since 22 July and is now 109 commits behind develop.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add 4 new volunteer appreciation options to the Add Appreciation dialog

2 participants