fix: add new appreciation values to request validation schema - #845
Merged
need4deed merged 1 commit intoAug 7, 2026
Merged
Conversation
4 tasks
Contributor
Author
|
Fe 910 is open and waiting on this one. |
need4deed
approved these changes
Aug 7, 2026
need4deed
left a comment
need4deed
left a comment
Contributor
There was a problem hiding this comment.
@ivannissimrch thank you!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The four new appreciation options (Need4Deed certificate, cap, notebook, city certificate) cannot be saved. The API rejects them with a 400 before the handler runs.
be#795 added those values to the SDK and to the database migration, but the request validation schema in
sdk-types.jsonstill listed only the original three, so every request with a new value was thrown out at validation.Tested locally: with the values added, the four new options save and persist correctly.
Related Issues
Closes #837
Unblocks need4deed-org/fe#910
Changes
VolunteerStateAppreciationTypeinsrc/server/schema/sdk-types.jsonChecklist