Repository navigation
Match the asset's version the way the tag is parsed - #28
Merged
Merged
Conversation
A v1.8 tag decodes tolerantly to 1.8.0, and the asset was compared against "<repo>-1.8.0", so MyApp-1.8.dmg never matched. The release was skipped without an error, and every installed app treated it as nonexistent. Parse the version in the asset name with the same tolerant parser and compare versions instead of strings. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Lowercasing the asset version breaks matching for case-sensitive prerelease identifiers.
Review effort: Balanced
Findings: 1
Open (1)
What changed in this PR
Aligns asset-version matching with tolerant release-tag parsing.
Changes:
- Parses asset versions before comparison.
- Adds short-version and mismatch tests.
- Documents short-form asset names.
| File | Description |
|---|---|
AppUpdater.swift |
Matches parsed asset and tag versions. |
Tests/AppUpdaterTests/AppUpdaterTests.swift |
Adds regression coverage and tolerant decoding. |
README.md |
Documents short-version asset names. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
kageroumado
added a commit
to kageroumado/phosphene
that referenced
this pull request
Oct 7, 2026
A v1.8 tag decodes to 1.8.0, and AppUpdater 4.2.0 compared the asset name against "phosphene-1.8.0", so Phosphene-1.8.dmg was skipped without an error. 4.2.1 (mxcl/AppUpdater#28, #29) parses the asset's version the way it parses the tag. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
kageroumado
added a commit
to kageroumado/adrafinil
that referenced
this pull request
Oct 7, 2026
AppUpdater 4.2.0 decoded a v1.9 tag as 1.9.0 and compared the asset name against "adrafinil-1.9.0", so Adrafinil-1.9.dmg was skipped without an error. 4.2.1 (mxcl/AppUpdater#28, #29) parses the asset's version the way it parses the tag. Tracking the resolved file pins the updater a release is built with. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Releases are decoded with the tolerant
Versionparser, so av1.8tag becomes1.8.0.viableAsset(forRepo:)then compared the asset name, as a string, against"<repo>-\(tagName)", which ismyapp-1.8.0. An asset namedMyApp-1.8.dmgnever matched.check()skipped the release without an error, so every installed copy treated it as nonexistent. We shipped two-part versions for a while before noticing that no app had updated.This parses the version in the asset name with the same tolerant parser and compares it to the tag as a
Version:MyApp-2.1.dmgonv2.1matches. Before this change it did not.MyApp-2.1.0.dmgonv2.1.0matches, as before.MyApp-2.1.1.dmgonv2.1still does not match. A test covers this.OtherApp-2.0.0.dmgstill does not match.The
release(...)test helper now decodes with.tolerant, the wayfetchReleasesdoes, so it can build av2.1tag. Its other cases behave the same. The README sentence about asset names now mentions the short form.swift test: 83 tests pass. The new short-version test fails onmaster.🤖 Generated with Claude Code