Skip to content

Apply pre-commit formatting to existing files - #34

Merged
parkjinman98 merged 1 commit into
mainfrom
chore/precommit-baseline-formatting-20261105
Nov 5, 2026
Merged

parkjinman98 merged 1 commit into
mainfrom
chore/precommit-baseline-formatting-20261105

Conversation

@parkjinman98

Copy link
Copy Markdown
Contributor

Summary

  • Apply only the automatic output of pre-commit run --all-files to nine existing Python files on main after Add twelve published CLIP-ReID model configurations #33.
  • No manual source edits, behavior changes, config changes, version changes, tags, or releases.
  • Changes are line wrapping and blank-line spacing. All nine files have identical Python ASTs before and after formatting (ignoring source-location attributes).

Validation

  • pre-commit run --all-files: both pinned Ruff lint and Ruff formatting pass across all 157 Python files.
  • Repository-pinned Ruff v0.6.9 full-tree lint: passes.
  • Full offline CPU pytest: 1695 passed, 15 skipped, 19 deselected; network and hardware integration tests excluded.
  • git diff --check: passes.

🤖 Generated with Claude Code

Accept only the nine-file formatting output from the existing pinned hooks. All changed Python ASTs are identical to main.

Co-Authored-By: Claude Code <noreply@anthropic.com>
@parkjinman98

Copy link
Copy Markdown
Contributor Author

@codex review

Review exact head 11037645fe66eb7e24737d2c482755f25c9fcaa9 against main after #33 (baa7cf54c51fbbb447e1e6bc267eb6e01b577bd3).

Scope: nine existing Python files, changed only by automatic output of the repository’s pinned pre-commit run --all-files; no manual edits. Please check that this is formatting only, with no changed imports, strings, expressions, behavior, configs, or public APIs. Complete Python ASTs are identical for all nine files when source-location attributes are omitted.

Validation: all-files pre-commit Ruff lint and formatting green; pinned Ruff v0.6.9 full-tree lint green; full offline CPU pytest 1695 passed, 15 skipped, 19 deselected; diff-check green. No force-push, tag, or release. After an exact-head no-issues review this PR will be squash-merged; branch deletion will first check for dependent open PRs.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 5, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-05T01:44:25.157971Z 1103764 Manual request
🔒 Security Review ✅ Completed 2026-11-05T01:46:40.178379Z 1103764 Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Nice work!

Reviewed commit: 11037645fe

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@chatgpt-codex-connector

Copy link
Copy Markdown

🛡️ Codex Security Review · Automatically triggered

Security review completed. No security issues were found in this pull request.

Reviewed commit: 11037645fe

View security finding report

Only the user who started this review can view the report in Codex.

ℹ️ About Codex security reviews in GitHub

This is an experimental Codex feature. Security reviews are triggered when:

  • You comment "@codex security review"
  • A regular code review gets triggered (for example, "@codex review" or when a PR is opened), and you’re opted in so security review runs alongside code review

Once complete, Codex will leave suggestions, or a comment if no findings are found.

@parkjinman98
parkjinman98 merged commit 64e5a0d into main Nov 5, 2026
3 checks passed
@parkjinman98
parkjinman98 deleted the chore/precommit-baseline-formatting-20261105 branch November 5, 2026 02:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant