Skip to content

Fix cropping of planar 10 and 16 bit images #1350

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ddennedy merged 1 commit into from
Oct 25, 2026
Merged

Fix cropping of planar 10 and 16 bit images #1350

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 12 additions & 2 deletions src/modules/core/filter_crop.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,9 +125,19 @@ static int filter_get_image(mlt_frame frame,
int bpp;
mlt_image_format requested_format = *format;

if (requested_format == mlt_image_yuv420p) {
// The crop function does not support planar.
// The crop function does not support planar.
switch (requested_format) {
case mlt_image_yuv420p:
requested_format = mlt_image_yuv422;
break;
case mlt_image_yuv420p10:
case mlt_image_yuv444p10:
case mlt_image_yuv422p16:
// Keep the bit depth
requested_format = mlt_image_rgba64;
break;
default:
break;
}
if (requested_format == mlt_image_yuv422 && (left & 1 || right & 1)) {
// Subsampled YUV requires even dimensions. Use RGB for odd dimensions.
Expand Down
Loading