Repository navigation
Fix cropping of planar 10 and 16 bit images - #1350
Merged
ddennedy merged 1 commit intoOct 25, 2026
Merged
Conversation
crop() only handles packed formats, so the crop filter converts yuv420p to yuv422 first, but yuv420p10, yuv444p10 and yuv422p16 were cropped as if they were packed, which garbled the image, for example with Crop: Source when exporting with pix_fmt=yuv420p10le. Convert these formats to rgba64, which keeps the bit depth.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
crop() only handles packed formats, so the crop filter converts yuv420p to yuv422 first, but yuv420p10, yuv444p10 and yuv422p16 were cropped as if they were packed, which garbled the image, for example with Crop: Source when exporting with pix_fmt=yuv420p10le. Convert these formats to rgba64, which keeps the bit depth.
Reproduced: a 1280x720 clip with
-attach crop left=100 right=100in a 1080x720 profile, rendered withpix_fmt=yuv420p10le, was garbled on master (PSNR 11 dB against the 8-bit render) and correct with the fix (36 dB).