Skip to content

MOBILE-129: Add critical error for invalid operationDomain #708

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
enotniy merged 1 commit into from
Apr 28, 2026
Merged

MOBILE-129: Add critical error for invalid operationDomain #708

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion sdk/src/main/java/cloud/mindbox/mobile_sdk/SdkValidation.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ internal object SdkValidation {
EMPTY_ENDPOINT(true, "Endpoint must not be empty"),
INVALID_DEVICE_ID(false, "Invalid previous device UUID format"),
INVALID_INSTALLATION_ID(false, "Invalid UUID format of previous installationId"),
INVALID_OPERATIONS_DOMAIN(false, "The operationsDomain is not valid, it will be ignored");
INVALID_OPERATIONS_DOMAIN(true, "The operationsDomain is not valid");
Copy link

Copilot AI Apr 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

INVALID_OPERATIONS_DOMAIN is now marked critical=true, which changes runtime behavior: Mindbox.validateConfiguration() will throw InitializeMindboxException instead of logging and ignoring the invalid operationsDomain. Please add/adjust tests to cover this new contract (e.g., invalid operationsDomain causes initialization to fail, and valid values still pass).

Copilot uses AI. Check for mistakes.

override fun toString() = "$name(critical=$critical, message=$message)"
}
Expand Down
Loading