MOBILE-129: Add critical error for invalid operationDomain#708
MOBILE-129: Add critical error for invalid operationDomain#708
Conversation
There was a problem hiding this comment.
Pull request overview
Updates SDK configuration validation so an invalid operationsDomain is treated as a critical initialization error (instead of being silently ignored), aligning with the goal of preventing misconfigured operations routing.
Changes:
- Mark
INVALID_OPERATIONS_DOMAINascritical=true. - Update the associated validation error message to remove “it will be ignored”.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| INVALID_DEVICE_ID(false, "Invalid previous device UUID format"), | ||
| INVALID_INSTALLATION_ID(false, "Invalid UUID format of previous installationId"), | ||
| INVALID_OPERATIONS_DOMAIN(false, "The operationsDomain is not valid, it will be ignored"); | ||
| INVALID_OPERATIONS_DOMAIN(true, "The operationsDomain is not valid"); |
There was a problem hiding this comment.
INVALID_OPERATIONS_DOMAIN is now marked critical=true, which changes runtime behavior: Mindbox.validateConfiguration() will throw InitializeMindboxException instead of logging and ignoring the invalid operationsDomain. Please add/adjust tests to cover this new contract (e.g., invalid operationsDomain causes initialization to fail, and valid values still pass).
https://tracker.yandex.ru/MOBILE-129