Skip to content

fix: Give policy alerts without an owner activity's owner #352

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vvoytovych merged 1 commit into from
Nov 12, 2026
Merged

fix: Give policy alerts without an owner activity's owner #352

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 22 additions & 6 deletions config/components/observability/alerts/dlq-alerts.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,10 @@ spec:
labels:
severity: warning
component: activity-processor
team: '{{ if $labels.policy_team }}{{ $labels.policy_team }}{{ else }}sre{{ end }}'
# A policy that declares no owner falls back to activity's own: the catalog's owner of
# activity-system, service control-plane, team platform.
service: '{{ if $labels.service }}{{ $labels.service }}{{ else }}control-plane{{ end }}'
team: '{{ if $labels.policy_team }}{{ $labels.policy_team }}{{ else }}platform{{ end }}'
annotations:
summary: "Activity policy{{ if $labels.policy_name }} {{ $labels.policy_name }}{{ end }} is failing to generate activities"
description: "Activity processing{{ if $labels.cluster }} on {{ $labels.cluster }}{{ end }} is sending {{ $value }} {{ $labels.event_type }} events/sec for {{ $labels.api_group }}/{{ $labels.kind }} to the dead-letter queue after {{ $labels.error_type }} failures. This rate has persisted for 15 minutes. Check the activity policy and processor logs for the failing rule and event payload."
Expand All @@ -65,7 +68,8 @@ spec:
labels:
severity: warning
component: activity-processor
team: sre
service: control-plane
team: platform
annotations:
summary: "Events that failed activity processing cannot be saved for retry"
description: "The activity processor{{ if $labels.cluster }} on {{ $labels.cluster }}{{ end }} reports {{ $value }} errors/sec while saving failed {{ $labels.event_type }} events to the dead-letter queue (phase: {{ $labels.error_phase }}). Check processor logs and queue connectivity so events that failed activity policy processing can be retained for retry."
Expand All @@ -92,7 +96,10 @@ spec:
labels:
severity: warning
component: activity-processor
team: '{{ if $labels.policy_team }}{{ $labels.policy_team }}{{ else }}sre{{ end }}'
# A policy that declares no owner falls back to activity's own: the catalog's owner of
# activity-system, service control-plane, team platform.
service: '{{ if $labels.service }}{{ $labels.service }}{{ else }}control-plane{{ end }}'
team: '{{ if $labels.policy_team }}{{ $labels.policy_team }}{{ else }}platform{{ end }}'
annotations:
summary: "Activity policy{{ if $labels.policy_name }} {{ $labels.policy_name }}{{ end }} events keep failing retries"
description: "Activity policy retries{{ if $labels.cluster }} on {{ $labels.cluster }}{{ end }} for {{ $labels.api_group }}/{{ $labels.kind }} recorded {{ $value }} failures at or above the high retry threshold in the last hour. The count can include repeated attempts for the same event. Check the policy and processor logs for persistent evaluation or delivery failures."
Expand All @@ -119,7 +126,10 @@ spec:
labels:
severity: warning
component: activity-processor
team: '{{ if $labels.policy_team }}{{ $labels.policy_team }}{{ else }}sre{{ end }}'
# A policy that declares no owner falls back to activity's own: the catalog's owner of
# activity-system, service control-plane, team platform.
service: '{{ if $labels.service }}{{ $labels.service }}{{ else }}control-plane{{ end }}'
team: '{{ if $labels.policy_team }}{{ $labels.policy_team }}{{ else }}platform{{ end }}'
annotations:
summary: "Activity policy{{ if $labels.policy_name }} {{ $labels.policy_name }}{{ end }} has recurring activity generation failures"
description: "Activity processing{{ if $labels.cluster }} on {{ $labels.cluster }}{{ end }} sent {{ $value }} {{ $labels.event_type }} events for {{ $labels.api_group }}/{{ $labels.kind }} to the dead-letter queue in the last 6 hours with {{ $labels.error_type }} errors. Inspect the activity policy and failed payloads for event shapes its rules do not handle."
Expand Down Expand Up @@ -157,7 +167,10 @@ spec:
labels:
severity: warning
component: activity-processor
team: '{{ if $labels.policy_team }}{{ $labels.policy_team }}{{ else }}sre{{ end }}'
# A policy that declares no owner falls back to activity's own: the catalog's owner of
# activity-system, service control-plane, team platform.
service: '{{ if $labels.service }}{{ $labels.service }}{{ else }}control-plane{{ end }}'
team: '{{ if $labels.policy_team }}{{ $labels.policy_team }}{{ else }}platform{{ end }}'
subject: "{{ $labels.policy_name }}"
annotations:
summary: "Activity policy {{ $labels.policy_name }} keeps failing during retries"
Expand Down Expand Up @@ -195,7 +208,10 @@ spec:
labels:
severity: warning
component: activity-processor
team: '{{ if $labels.policy_team }}{{ $labels.policy_team }}{{ else }}sre{{ end }}'
# A policy that declares no owner falls back to activity's own: the catalog's owner of
# activity-system, service control-plane, team platform.
service: '{{ if $labels.service }}{{ $labels.service }}{{ else }}control-plane{{ end }}'
team: '{{ if $labels.policy_team }}{{ $labels.policy_team }}{{ else }}platform{{ end }}'
annotations:
summary: "Activity policy {{ $labels.policy_name }} is failing to generate activities"
description: "Activity policy {{ $labels.policy_name }} for {{ $labels.api_group }}/{{ $labels.kind }} is sending {{ $value }} events/sec to the dead-letter queue with {{ $labels.error_type }} errors. Check the policy's rules against failed event payloads in the activity-processor logs."
Expand Down
24 changes: 16 additions & 8 deletions test/observability/dlq-alerts.test.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,8 @@ tests:
error_type: cel_summary
severity: warning
component: activity-processor
team: sre
team: platform
service: control-plane
subject: networking.datumapis.com-httpproxy
exp_annotations:
summary: Activity policy networking.datumapis.com-httpproxy keeps failing during retries
Expand All @@ -49,7 +50,8 @@ tests:
error_type: cel_summary
severity: warning
component: activity-processor
team: sre
team: platform
service: control-plane
subject: another-policy
exp_annotations:
summary: Activity policy another-policy keeps failing during retries
Expand All @@ -65,7 +67,8 @@ tests:
error_type: cel_summary
severity: warning
component: activity-processor
team: sre
team: platform
service: control-plane
subject: networking.datumapis.com-httpproxy
exp_annotations:
summary: Activity policy networking.datumapis.com-httpproxy keeps failing during retries
Expand All @@ -81,7 +84,8 @@ tests:
error_type: cel_match
severity: warning
component: activity-processor
team: sre
team: platform
service: control-plane
subject: networking.datumapis.com-httpproxy
exp_annotations:
summary: Activity policy networking.datumapis.com-httpproxy keeps failing during retries
Expand Down Expand Up @@ -120,7 +124,8 @@ tests:
error_type: cel_summary
severity: warning
component: activity-processor
team: sre
team: platform
service: control-plane
subject: networking.datumapis.com-httpproxy
exp_annotations:
summary: Activity policy networking.datumapis.com-httpproxy keeps failing during retries
Expand Down Expand Up @@ -169,7 +174,8 @@ tests:
error_type: cel_summary
severity: warning
component: activity-processor
team: sre
team: platform
service: control-plane
subject: networking.datumapis.com-httpproxy
exp_annotations:
summary: Activity policy networking.datumapis.com-httpproxy keeps failing during retries
Expand Down Expand Up @@ -230,7 +236,8 @@ tests:
error_type: cel_summary
severity: warning
component: activity-processor
team: sre
team: platform
service: control-plane
subject: another-policy
exp_annotations:
summary: Activity policy another-policy keeps failing during retries
Expand All @@ -246,7 +253,8 @@ tests:
error_type: cel_summary
severity: warning
component: activity-processor
team: sre
team: platform
service: control-plane
subject: networking.datumapis.com-httpproxy
exp_annotations:
summary: Activity policy networking.datumapis.com-httpproxy keeps failing during retries
Expand Down
Loading