Repository navigation
fix: Give policy alerts without an owner activity's owner - #352
Merged
Merged
Conversation
A DLQ alert takes its service and team from the failing policy's owner. A policy that declares no owner fired with no service and team sre, which no route keys on, so the alert fell to the catch-all channel. It now falls back to activity's own owner, service control-plane and team platform, as the platform's catalog names the owner of activity-system. A policy that declares an owner keeps it. Key changes: - The five policy alerts fall back to service control-plane and team platform when the policy declares no owner - The processor alert for failed DLQ publishes names the same owner - The alert tests expect the fallback for policies without an owner
scotwells
approved these changes
Nov 12, 2026
ecv
approved these changes
Nov 12, 2026
ecv
left a comment
Contributor
There was a problem hiding this comment.
Approve.
Dead-letter alerts for a policy with no declared owner now go to the platform team's channel instead of the catch-all. A policy with an owner keeps routing to its own team.
- In the
unlessbranch the series has nopolicy_service, solabel_replace(..., "service", "$1", "policy_service", "(.*)")setsserviceto empty. That drops any scrape-timeservicelabel, so the template'scontrol-planefallback is what lands, not the Kubernetes Service name. - The tests cover both the fallback and a declared owner.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A dead-letter alert takes its service and team from the failing policy's owner, so a policy that declares no owner alerts with no service, which no route reaches, and the alert lands in the catch-all channel, as identity policies did in both environments over the last two weeks.
Such an alert now falls back to activity's own owner, the control plane service and the platform team, as the platform's catalog names the owner of the namespace activity runs in.
A policy that declares an owner keeps it, so its failures still reach its own team.
Changes
Test plan