Add es5-ext to moduleignore#315063
Conversation
There was a problem hiding this comment.
Pull request overview
Adds an npm overrides rule at the repository root to ensure any transitive es5-ext dependency is resolved to the community fork @unes/es5-ext (intended to avoid quarantine/protestware postinstall behavior and unblock hardened dependency prefetch/build pipelines).
Changes:
- Add
overrides.es5-ext = "npm:@unes/es5-ext@0.10.64-1"to force resolution to@unes/es5-ext. - Reformat the root
package.json(indentation/whitespace).
|
@microsoft-github-policy-service agree company="Red Hat" |
|
We can actually just add es5-ext to our moduleignore entirely. It is only consumed in |
|
Thanks @connor4312! That's much cleaner. Confirmed — browser.js checks This is consistent with your earlier comment on #310541 noting that I'll push the |
es5-ext (0.10.63 and 0.10.64) is quarantined by Nexus Firewall (sonatype-2022-2248) due to undisclosed postinstall code execution. es5-ext is only consumed in websocket's browser.js inside a try/catch with a globalThis fallback, so it is unnecessary in the browsers/runtimes VS Code supports. Adding it to .moduleignore strips it from the build output entirely. Fixes microsoft#310541 Co-authored-by: Cursor <cursoragent@cursor.com>
adea003 to
c4027af
Compare
|
Ah, sorry, our CI blocks external contribs to ./build. I'll reopen this under my account to unlock |
Summary
es5-ext(0.10.63 and 0.10.64) is quarantined by Nexus Firewall (sonatype-2022-2248) because its_postinstall.jsmakes network calls to geolocate the host and executes undisclosed code (protestware). Both versions are flagged; there is no clean upstream version.overridesentry to aliases5-extto@unes/es5-ext@0.10.64-1, a community fork that strips the postinstall script and rebases daily against upstream.gulp-sourcemaps→debug-fabulous→memoizee→es5-ext, and thed/es6-*/esniff/timers-extfamily, as well as@microsoft/dev-tunnels-connections→es5-ext+websocket→es5-ext.Fixes #310541
References
websocketpackage dropping es5-extMade with Cursor