Add es5-ext to .moduleignore to exclude quarantined module#315110
Merged
connor4312 merged 1 commit intomainfrom May 7, 2026
Merged
Add es5-ext to .moduleignore to exclude quarantined module#315110connor4312 merged 1 commit intomainfrom
connor4312 merged 1 commit intomainfrom
Conversation
es5-ext (0.10.63 and 0.10.64) is quarantined by Nexus Firewall (sonatype-2022-2248) due to undisclosed postinstall code execution. es5-ext is only consumed in websocket's browser.js inside a try/catch with a globalThis fallback, so it is unnecessary in the browsers/runtimes VS Code supports. Adding it to .moduleignore strips it from the build output entirely. Fixes #310541 Co-authored-by: Cursor <cursoragent@cursor.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the build packaging ignore list to exclude the es5-ext npm package from VS Code’s shipped production dependencies, motivated by supply-chain quarantine concerns.
Changes:
- Add an ignore rule for
es5-ext/**inbuild/.moduleignore. - Document rationale in-line, citing the quarantine advisory and an assumption about runtime usage.
Show a summary per file
| File | Description |
|---|---|
| build/.moduleignore | Excludes es5-ext from packaged node_modules and adds a comment explaining why. |
Copilot's findings
- Files reviewed: 1/1 changed files
- Comments generated: 1
dmitrivMS
approved these changes
May 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #315063