Repository navigation
Show inline map attribution as text and keep map tiles on the tile proxy (0.261.049) - #1614
Merged
Paul Lizer (paullizer) merged 1 commit intoOct 2, 2026
Conversation
The chat's inline map card escapes a tool result's tile attribution before OpenLayers renders it, and draws a result as a map only when its tile template points at /api/azure-maps/tile with {z}, {x} and {y}. Maps from the Azure Maps action are unchanged. Version 0.261.049.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The chat's inline map card now shows a tool result's tile attribution as plain text, and draws a result as a map only when its tiles come through SimpleChat's Azure Maps tile proxy. Maps from the Azure Maps action are unchanged.
Changes
chat-inline-maps.js: the attribution goes through the existingescapeHtmlhelper before OpenLayers, which renders attribution strings as HTML.isTileProxyTemplate: it accepts only/api/azure-maps/tile?templates that contain{z},{x}and{y}and have no whitespace, quotes, angle brackets or backslashes.isAzureMapsVisualizationnow requires it.Validation
functional_tests/test_chat_inline_map_attribution_text.py: 4 passed. It includes a Node run of the realisTileProxyTemplateagainst 12 templates.test_azure_maps_tile_token_refresh_fix.pyandtest_azure_maps_openlayers_plugin.py: passed.ui_tests/test_chat_inline_azure_maps_rendering.pyalready uses a proxied template.test_chat_local_openlayers_assets.py::test_csp_keeps_scripts_and_styles_localfails onDevelopmentboth with and without this change.Docs
docs/explanation/fixes/INLINE_MAP_ATTRIBUTION_TEXT_FIX.md.The V2 map card in #1612 handles attribution and tile templates the same way.