Skip to content

Show inline map attribution as text and keep map tiles on the tile proxy (0.261.049) - #1614

Merged
Paul Lizer (paullizer) merged 1 commit into
Developmentfrom
paullizer-classic-map-attribution-text
Oct 2, 2026
Merged

Paul Lizer (paullizer) merged 1 commit into
Developmentfrom
paullizer-classic-map-attribution-text

Conversation

@paullizer

Copy link
Copy Markdown
Contributor

Summary

The chat's inline map card now shows a tool result's tile attribution as plain text, and draws a result as a map only when its tiles come through SimpleChat's Azure Maps tile proxy. Maps from the Azure Maps action are unchanged.

Changes

  • chat-inline-maps.js: the attribution goes through the existing escapeHtml helper before OpenLayers, which renders attribution strings as HTML.
  • New isTileProxyTemplate: it accepts only /api/azure-maps/tile? templates that contain {z}, {x} and {y} and have no whitespace, quotes, angle brackets or backslashes. isAzureMapsVisualization now requires it.
  • Version 0.261.049.

Validation

  • New functional_tests/test_chat_inline_map_attribution_text.py: 4 passed. It includes a Node run of the real isTileProxyTemplate against 12 templates.
  • test_azure_maps_tile_token_refresh_fix.py and test_azure_maps_openlayers_plugin.py: passed. ui_tests/test_chat_inline_azure_maps_rendering.py already uses a proxied template.
  • test_chat_local_openlayers_assets.py::test_csp_keeps_scripts_and_styles_local fails on Development both with and without this change.
  • XSS sink checker on the changed lines: passed.

Docs

  • Fix doc: docs/explanation/fixes/INLINE_MAP_ATTRIBUTION_TEXT_FIX.md.
  • Release notes: 0.261.049.

The V2 map card in #1612 handles attribution and tile templates the same way.

The chat's inline map card escapes a tool result's tile attribution before OpenLayers renders it, and draws a result as a map only when its tile template points at /api/azure-maps/tile with {z}, {x} and {y}. Maps from the Azure Maps action are unchanged. Version 0.261.049.
@paullizer
Paul Lizer (paullizer) merged commit 815bde5 into Development Oct 2, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant