Repository navigation
Keep the Azure Maps tile token when tool results are redacted (0.261.050) - #1618
Merged
Paul Lizer (paullizer) merged 1 commit intoOct 2, 2026
Merged
Paul Lizer (paullizer) merged 1 commit into
Paul Lizer (paullizer) merged 1 commit into
Conversation
Tool results are redacted before they are stored as citations, and the token= rule replaced the map payload's tile proxy token with ***REDACTED***, so stored maps drew on blank tiles. The token is now kept only where it directly follows /api/azure-maps/tile?; every other secret is still redacted. Version 0.261.050.
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Maps an agent draws with the Azure Maps action load their tiles again. Tool results are redacted before they are stored as citations, and the
token=rule replaced the map's tile proxy token with***REDACTED***, so every stored map drew its markers and paths on blank tiles (tile requests returned 400).Changes
plugin_invocation_logger.py:_redact_secret_assignmentkeeps atoken=value only where it directly follows/api/azure-maps/tile?. That is wherebuild_tile_proxy_url_templatewrites the token.token=values, another key after the prefix, a token later in the query, absolute URLs and every other secret.Maps stored before this change keep the redacted token, which cannot be recovered, so they still show no tiles. Running the request again produces a working map.
This follows #1614, which escaped the map attribution and limited tile templates to the proxy. The same fix is in the V2 branch through #1612.
Validation
functional_tests/test_azure_maps_tile_token_redaction_fix.py: 3 passed. It loads the real invocation logger and Azure Maps helpers, checks that a map result keeps a token that still decodes (as an object and as JSON text), and checks that every other case is still redacted.test_chat_inline_map_attribution_text.py,test_azure_maps_tile_token_refresh_fix.pyandtest_azure_maps_openlayers_plugin.py: passed (14 with the new test).Docs
docs/explanation/fixes/AZURE_MAPS_TILE_TOKEN_REDACTION_FIX.md.