[Master] - Slice 641591: EUDR Certificate Capture for Items - #11217
[Master] - Slice 641591: EUDR Certificate Capture for Items#11217v-rohangarg20 wants to merge 13 commits into
Conversation
6f3ce28 to
948c447
Compare
f9e6140 to
69386f7
Compare
69386f7 to
d20bb6e
Compare
We’ve moved it to the Sustainability app. |
Good Sense Reviewer - Round 4Recommendation: AcceptWhat this PR doesThe latest commits fix the remaining compile blocker in the EUDR item tracking lookup. The helper now declares and uses The full change adds an EUDR flag and commodity on items, stores EUDR certificate data on lot information, carries EUDR state to purchase and sales document history, and prints lot certificate details on a dedicated sales invoice. The sales and purchase item-assignment subscribers use existing events that run after standard item values are assigned, so the copied EUDR state is captured at the right point when the item changes. Status of previous suggestions
New observations (commits since round 3)None. The new commits only fix the prior compile issue and clean up the item tracking lookup variable use. Risk assessment and necessityRisk: Medium. The feature touches item tracking setup, lot certificate data, purchase and sales posted-line state, and printed invoice output. The latest change is narrow and lowers risk by removing the unresolved compile problem; CI was still running at review time, with no completed failing check visible. Necessity: The change is needed so users can mark EUDR-relevant items, keep certificate data per lot, and print certificate information per invoiced lot. Without it, users do not have an in-app path for this certificate capture and invoice output flow.
|
Good Sense Reviewer - Round 5Recommendation: AcceptWhat this PR doesThe latest commits change only the test code: they add missing test initialization, payment-information setup, general posting setup for item tracking posting, and stable date values for the page test. The full feature still adds an EUDR flag and commodity on items, stores certificate data on lot information, carries the EUDR state to purchase and sales document history, and prints lot certificate details on a dedicated sales invoice. The base application publishers used by the subscribers exist and run after standard item values are assigned; posted-line transfer uses the matching field numbers, and the report reads the posted line state before loading lot certificate rows. Status of previous suggestions
New observations (commits since round 4)None. The new commits only strengthen the test setup and do not introduce a new production-code issue. Risk assessment and necessityRisk: Medium. The feature touches item tracking setup, lot certificate data, posted purchase and sales line state, and invoice report output. The latest round changed tests only; completed visible checks were successful, with some long-running unit-test buckets still in progress. Necessity: The change is needed so users can mark EUDR-relevant items, keep certificate information per lot, and print certificate details per invoiced lot. The scope matches that feature without replacing the default invoice report.
|
Fixes AB#641591
Issue
EUDR certificate information could not be captured and carried with item and lot tracking data. As a result, users could not reliably maintain the certificate reference needed for EUDR traceability across purchasing, sales, posted receipt lines, and the EUDR sales invoice report.
Cause
The Sustainability and EUDR data model and document flows did not expose a certificate field for items or propagate that information consistently when item tracking and lot information were created or transferred through purchase and sales documents. The related report and permissions also did not include the complete certificate-capture flow.
Solution
ItemTrackingCodein all relevant procedures, includingAssignEUDRItemTrackingCode.