Skip to content

Actions: Run --level pr on merge_group (for now) - #11186

Merged
vidplace7 merged 1 commit into
developfrom
only-develop-merge-queue
Jul 24, 2026
Merged

Actions: Run --level pr on merge_group (for now)#11186
vidplace7 merged 1 commit into
developfrom
only-develop-merge-queue

Conversation

@vidplace7

@vidplace7 vidplace7 commented Jul 24, 2026

Copy link
Copy Markdown
Member

merge_group jobs run individually and then push. For now treat them like PRs

Summary by CodeRabbit

  • Chores
    • Updated automated CI triggers to stop considering the pioarduino branch for merge_group and pull_request.
    • Refined CI to run on event/* and feature/* branches for push, while skipping changes limited to **.md and version.properties.
    • Adjusted scheduled CI timing (moved earlier) and unified PR-level build handling for both pull_request and merge_group.

@vidplace7 vidplace7 added the github_actions Pull requests that update GitHub Actions code label Jul 24, 2026
@coderabbitai

coderabbitai Bot commented Jul 24, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

📝 Walkthrough

Walkthrough

The main matrix workflow narrows branch triggers, ignores documentation and version-only pushes, moves the scheduled run earlier, and selects PR-level build matrices for pull request and merge group events.

Changes

CI workflow refinement

Layer / File(s) Summary
Update workflow event filters
.github/workflows/main_matrix.yml
Push triggers target event/* and feature/*, ignore **.md and version.properties, pull requests target master and develop, and scheduled runs move from 09:00 to 07:00 UTC.
Select PR-level build matrices
.github/workflows/main_matrix.yml
The setup job uses GITHUB_EVENT_NAME to select the narrowed --level pr matrix for pull_request and merge_group events; other events generate the full matrix.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related PRs

Suggested reviewers: thebentern, caveman99

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description is far shorter than the required template and omits the attestation checklist and other requested details. Replace the template text with a fuller PR description and complete the attestations/test checklist, including any device notes.
✅ Passed checks (4 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title matches the main change: treating merge_group jobs as PR-level builds.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch only-develop-merge-queue

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

Copy link
Copy Markdown
Contributor

⚡ Try this PR in the Web Flasher

Note

Building this pull request… the flash button, badges and supported-board
list will appear here automatically once CI finishes.

@vidplace7
vidplace7 force-pushed the only-develop-merge-queue branch from 8192380 to 2490db6 Compare July 24, 2026 01:36
@vidplace7
vidplace7 enabled auto-merge July 24, 2026 01:36
@vidplace7 vidplace7 changed the title Actions: Only use merge_group on develop branch Actions: Only use merge_group on develop/master branch Jul 24, 2026
Other branches aren't set up for this (yet?) so go back to the old behaviour for now.
@vidplace7
vidplace7 force-pushed the only-develop-merge-queue branch from 2490db6 to dd1f125 Compare July 24, 2026 01:58
@vidplace7
vidplace7 disabled auto-merge July 24, 2026 01:58
@vidplace7 vidplace7 changed the title Actions: Only use merge_group on develop/master branch Actions: Run --level pr on merge_group (for now) Jul 24, 2026

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In @.github/workflows/main_matrix.yml:
- Around line 6-15: Limit the merge_group trigger to develop by removing master
from merge_group.branches, and update the adjacent explanatory comment to
describe develop-only merge queue validation. Leave master entries in the
separate push and pull_request filters unchanged.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: e2a895a4-869b-4781-9a79-2be3e042ee41

📥 Commits

Reviewing files that changed from the base of the PR and between 2490db6 and dd1f125.

📒 Files selected for processing (1)
  • .github/workflows/main_matrix.yml

Comment thread .github/workflows/main_matrix.yml
@vidplace7
vidplace7 merged commit 372b751 into develop Jul 24, 2026
92 checks passed
@vidplace7
vidplace7 deleted the only-develop-merge-queue branch July 24, 2026 02:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

github_actions Pull requests that update GitHub Actions code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant