Skip to content

Remove board_check (now using normal matrix) - #11312

Merged
vidplace7 merged 1 commit into
developfrom
check-yourself
Aug 2, 2026
Merged

Remove board_check (now using normal matrix)#11312
vidplace7 merged 1 commit into
developfrom
check-yourself

Conversation

@vidplace7

@vidplace7 vidplace7 commented Jul 31, 2026

Copy link
Copy Markdown
Member

Forward-ported from #11151 (WIP)

This was being misused / misunderstood (most were a no-op already).

Depends on fixes in:

Summary by CodeRabbit

  • CI Improvements

    • Streamlined automated build validation with a unified target matrix.
    • Pull requests and merge queues now run focused checks, while other builds use the complete target set.
    • Improved platform and release-level filtering for more consistent validation.
  • Configuration

    • Simplified build settings across supported ESP32, nRF52, RP2040, and RP2350 hardware.
    • Standardized configuration handling and reduced unnecessary board-specific validation settings.
    • Improved consistency across supported device builds.

@vidplace7 vidplace7 added the github_actions Pull requests that update GitHub Actions code label Jul 31, 2026
@github-actions

Copy link
Copy Markdown
Contributor

⚡ Try this PR in the Web Flasher

Note

Building this pull request… the flash button, badges and supported-board
list will appear here automatically once CI finishes.

@coderabbitai

coderabbitai Bot commented Jul 31, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 9eff7f06-2887-4469-86ac-d55afaca711c

📥 Commits

Reviewing files that changed from the base of the PR and between d6428ee and 2bd1286.

📒 Files selected for processing (59)
  • .github/workflows/main_matrix.yml
  • bin/generate_ci_matrix.py
  • variants/esp32/diy/v1/platformio.ini
  • variants/esp32/m5stack_coreink/platformio.ini
  • variants/esp32/rak11200/platformio.ini
  • variants/esp32/tbeam/platformio.ini
  • variants/esp32/tlora_v2_1_16/platformio.ini
  • variants/esp32s2/nugget_s2_lora/platformio.ini
  • variants/esp32s3/elecrow_panel/platformio.ini
  • variants/esp32s3/hackaday-communicator/platformio.ini
  • variants/esp32s3/heltec_capsule_sensor_v3/platformio.ini
  • variants/esp32s3/heltec_sensor_hub/platformio.ini
  • variants/esp32s3/heltec_v3/platformio.ini
  • variants/esp32s3/heltec_v4/platformio.ini
  • variants/esp32s3/heltec_v4_r8/platformio.ini
  • variants/esp32s3/icarus/platformio.ini
  • variants/esp32s3/m5stack_cardputer_adv/platformio.ini
  • variants/esp32s3/m5stack_cores3/platformio.ini
  • variants/esp32s3/mini-epaper-s3/platformio.ini
  • variants/esp32s3/picomputer-s3/platformio.ini
  • variants/esp32s3/rak3312/platformio.ini
  • variants/esp32s3/rak_wismesh_tap_v2/platformio.ini
  • variants/esp32s3/seeed-sensecap-indicator/platformio.ini
  • variants/esp32s3/seeed_xiao_s3/platformio.ini
  • variants/esp32s3/station-g2/platformio.ini
  • variants/esp32s3/station-g3/platformio.ini
  • variants/esp32s3/t-beam-1w/platformio.ini
  • variants/esp32s3/t-beam-bpf/platformio.ini
  • variants/esp32s3/t-deck-pro-v1_1/platformio.ini
  • variants/esp32s3/t-deck-pro/platformio.ini
  • variants/esp32s3/t-deck/platformio.ini
  • variants/esp32s3/t-eth-elite/platformio.ini
  • variants/esp32s3/t-watch-s3/platformio.ini
  • variants/esp32s3/t5s3_epaper/platformio.ini
  • variants/esp32s3/tbeam-s3-core/platformio.ini
  • variants/esp32s3/tlora-pager/platformio.ini
  • variants/esp32s3/tlora_t3s3_epaper/platformio.ini
  • variants/esp32s3/tlora_t3s3_v1/platformio.ini
  • variants/esp32s3/visualizer-hub75/platformio.ini
  • variants/nrf52840/ELECROW-ThinkNode-M1/platformio.ini
  • variants/nrf52840/ELECROW-ThinkNode-M3/platformio.ini
  • variants/nrf52840/ELECROW-ThinkNode-M4/platformio.ini
  • variants/nrf52840/ELECROW-ThinkNode-M6/platformio.ini
  • variants/nrf52840/ELECROW-ThinkNode-M8/platformio.ini
  • variants/nrf52840/gat562_mesh_trial_tracker/platformio.ini
  • variants/nrf52840/heltec_mesh_node_t114-inkhud/platformio.ini
  • variants/nrf52840/meshlink/platformio.ini
  • variants/nrf52840/r1-neo/platformio.ini
  • variants/nrf52840/rak2560/platformio.ini
  • variants/nrf52840/rak3401_1watt/platformio.ini
  • variants/nrf52840/rak4631/platformio.ini
  • variants/nrf52840/rak4631_eth_gw/platformio.ini
  • variants/nrf52840/rak4631_nomadstar_meteor_pro/platformio.ini
  • variants/nrf52840/rak_wismeshtag/platformio.ini
  • variants/nrf52840/t-echo-lite/platformio.ini
  • variants/nrf52840/t-echo-plus/platformio.ini
  • variants/nrf52840/t-echo/platformio.ini
  • variants/rp2040/rpipicow/platformio.ini
  • variants/rp2350/rpipico2w/platformio.ini
💤 Files with no reviewable changes (57)
  • variants/esp32/rak11200/platformio.ini
  • variants/esp32s3/elecrow_panel/platformio.ini
  • variants/esp32s3/m5stack_cores3/platformio.ini
  • variants/nrf52840/t-echo/platformio.ini
  • variants/esp32s3/icarus/platformio.ini
  • variants/esp32s3/heltec_v4_r8/platformio.ini
  • variants/esp32/diy/v1/platformio.ini
  • variants/esp32/tlora_v2_1_16/platformio.ini
  • variants/esp32s3/tbeam-s3-core/platformio.ini
  • variants/esp32s3/heltec_sensor_hub/platformio.ini
  • variants/nrf52840/ELECROW-ThinkNode-M8/platformio.ini
  • variants/esp32s3/rak3312/platformio.ini
  • variants/esp32s3/t-deck/platformio.ini
  • variants/esp32s3/picomputer-s3/platformio.ini
  • variants/esp32s3/t-watch-s3/platformio.ini
  • variants/esp32s3/tlora-pager/platformio.ini
  • variants/esp32s3/heltec_v3/platformio.ini
  • variants/esp32s3/t-beam-1w/platformio.ini
  • variants/esp32s3/station-g3/platformio.ini
  • variants/esp32/tbeam/platformio.ini
  • variants/nrf52840/rak3401_1watt/platformio.ini
  • variants/rp2040/rpipicow/platformio.ini
  • variants/esp32s3/hackaday-communicator/platformio.ini
  • variants/nrf52840/t-echo-lite/platformio.ini
  • variants/nrf52840/rak_wismeshtag/platformio.ini
  • variants/esp32s3/t-deck-pro/platformio.ini
  • variants/esp32s3/tlora_t3s3_epaper/platformio.ini
  • variants/nrf52840/gat562_mesh_trial_tracker/platformio.ini
  • variants/nrf52840/ELECROW-ThinkNode-M6/platformio.ini
  • variants/esp32s3/t-beam-bpf/platformio.ini
  • variants/esp32s3/station-g2/platformio.ini
  • variants/esp32s3/t-eth-elite/platformio.ini
  • variants/nrf52840/r1-neo/platformio.ini
  • variants/nrf52840/rak4631_nomadstar_meteor_pro/platformio.ini
  • variants/nrf52840/ELECROW-ThinkNode-M3/platformio.ini
  • variants/esp32s3/seeed_xiao_s3/platformio.ini
  • variants/esp32s3/seeed-sensecap-indicator/platformio.ini
  • variants/esp32s3/m5stack_cardputer_adv/platformio.ini
  • variants/esp32s3/t5s3_epaper/platformio.ini
  • variants/esp32s3/rak_wismesh_tap_v2/platformio.ini
  • variants/nrf52840/heltec_mesh_node_t114-inkhud/platformio.ini
  • variants/nrf52840/rak4631/platformio.ini
  • variants/nrf52840/rak2560/platformio.ini
  • variants/nrf52840/rak4631_eth_gw/platformio.ini
  • variants/nrf52840/t-echo-plus/platformio.ini
  • variants/rp2350/rpipico2w/platformio.ini
  • variants/esp32s3/visualizer-hub75/platformio.ini
  • variants/esp32s3/t-deck-pro-v1_1/platformio.ini
  • variants/esp32s3/heltec_capsule_sensor_v3/platformio.ini
  • variants/nrf52840/ELECROW-ThinkNode-M4/platformio.ini
  • variants/esp32s3/mini-epaper-s3/platformio.ini
  • variants/nrf52840/meshlink/platformio.ini
  • variants/esp32s3/heltec_v4/platformio.ini
  • variants/nrf52840/ELECROW-ThinkNode-M1/platformio.ini
  • variants/esp32/m5stack_coreink/platformio.ini
  • variants/esp32s2/nugget_s2_lora/platformio.ini
  • variants/esp32s3/tlora_t3s3_v1/platformio.ini
🚧 Files skipped from review as they are similar to previous changes (1)
  • .github/workflows/main_matrix.yml

📝 Walkthrough

Walkthrough

The PR removes board_check metadata from PlatformIO environments and matrix generation. CI now produces one unified matrix and runs the check job only for pull requests and merge queues.

Changes

CI matrix unification

Layer / File(s) Summary
Platform metadata cleanup
variants/esp32/*, variants/esp32s2/*, variants/esp32s3/*, variants/nrf52840/*, variants/rp2040/*, variants/rp2350/*
Removed board_check settings from the affected PlatformIO environments.
Matrix generation
bin/generate_ci_matrix.py
Removed board_check collection and dedicated check-platform filtering.
Workflow matrix consumption
.github/workflows/main_matrix.yml
Replaced separate matrices with one all matrix. Pull requests and merge queues use --level pr. The check job runs only for those events.

Estimated code review effort: 3 (Moderate) | ~20 minutes

Possibly related PRs

Suggested labels: cleanup, tech debt

Suggested reviewers: thebentern, nomdetom

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description states the change and dependencies but omits the required testing attestations and hardware regression information. Add the required testing attestations, affected-device regression results, and any hardware testing limitations.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly identifies removal of board_check and adoption of the normal matrix.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch check-yourself

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@bin/generate_ci_matrix.py`:
- Around line 68-77: Update the conditional block that filters environments in
the CI matrix generation logic to use four-space indentation consistently,
including the nested comments, conditions, and outlist.append calls, so it
passes Flake8 E111 without changing behavior.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 8ef2cbf3-1c38-47db-a0cd-a19bcf0d556f

📥 Commits

Reviewing files that changed from the base of the PR and between 5bfad25 and 628ec3d.

📒 Files selected for processing (59)
  • .github/workflows/main_matrix.yml
  • bin/generate_ci_matrix.py
  • variants/esp32/diy/v1/platformio.ini
  • variants/esp32/m5stack_coreink/platformio.ini
  • variants/esp32/rak11200/platformio.ini
  • variants/esp32/tbeam/platformio.ini
  • variants/esp32/tlora_v2_1_16/platformio.ini
  • variants/esp32s2/nugget_s2_lora/platformio.ini
  • variants/esp32s3/elecrow_panel/platformio.ini
  • variants/esp32s3/hackaday-communicator/platformio.ini
  • variants/esp32s3/heltec_capsule_sensor_v3/platformio.ini
  • variants/esp32s3/heltec_sensor_hub/platformio.ini
  • variants/esp32s3/heltec_v3/platformio.ini
  • variants/esp32s3/heltec_v4/platformio.ini
  • variants/esp32s3/heltec_v4_r8/platformio.ini
  • variants/esp32s3/icarus/platformio.ini
  • variants/esp32s3/m5stack_cardputer_adv/platformio.ini
  • variants/esp32s3/m5stack_cores3/platformio.ini
  • variants/esp32s3/mini-epaper-s3/platformio.ini
  • variants/esp32s3/picomputer-s3/platformio.ini
  • variants/esp32s3/rak3312/platformio.ini
  • variants/esp32s3/rak_wismesh_tap_v2/platformio.ini
  • variants/esp32s3/seeed-sensecap-indicator/platformio.ini
  • variants/esp32s3/seeed_xiao_s3/platformio.ini
  • variants/esp32s3/station-g2/platformio.ini
  • variants/esp32s3/station-g3/platformio.ini
  • variants/esp32s3/t-beam-1w/platformio.ini
  • variants/esp32s3/t-beam-bpf/platformio.ini
  • variants/esp32s3/t-deck-pro-v1_1/platformio.ini
  • variants/esp32s3/t-deck-pro/platformio.ini
  • variants/esp32s3/t-deck/platformio.ini
  • variants/esp32s3/t-eth-elite/platformio.ini
  • variants/esp32s3/t-watch-s3/platformio.ini
  • variants/esp32s3/t5s3_epaper/platformio.ini
  • variants/esp32s3/tbeam-s3-core/platformio.ini
  • variants/esp32s3/tlora-pager/platformio.ini
  • variants/esp32s3/tlora_t3s3_epaper/platformio.ini
  • variants/esp32s3/tlora_t3s3_v1/platformio.ini
  • variants/esp32s3/visualizer-hub75/platformio.ini
  • variants/nrf52840/ELECROW-ThinkNode-M1/platformio.ini
  • variants/nrf52840/ELECROW-ThinkNode-M3/platformio.ini
  • variants/nrf52840/ELECROW-ThinkNode-M4/platformio.ini
  • variants/nrf52840/ELECROW-ThinkNode-M6/platformio.ini
  • variants/nrf52840/ELECROW-ThinkNode-M8/platformio.ini
  • variants/nrf52840/gat562_mesh_trial_tracker/platformio.ini
  • variants/nrf52840/heltec_mesh_node_t114-inkhud/platformio.ini
  • variants/nrf52840/meshlink/platformio.ini
  • variants/nrf52840/r1-neo/platformio.ini
  • variants/nrf52840/rak2560/platformio.ini
  • variants/nrf52840/rak3401_1watt/platformio.ini
  • variants/nrf52840/rak4631/platformio.ini
  • variants/nrf52840/rak4631_eth_gw/platformio.ini
  • variants/nrf52840/rak4631_nomadstar_meteor_pro/platformio.ini
  • variants/nrf52840/rak_wismeshtag/platformio.ini
  • variants/nrf52840/t-echo-lite/platformio.ini
  • variants/nrf52840/t-echo-plus/platformio.ini
  • variants/nrf52840/t-echo/platformio.ini
  • variants/rp2040/rpipicow/platformio.ini
  • variants/rp2350/rpipico2w/platformio.ini
💤 Files with no reviewable changes (57)
  • variants/esp32/rak11200/platformio.ini
  • variants/esp32/diy/v1/platformio.ini
  • variants/esp32s3/station-g2/platformio.ini
  • variants/esp32s3/icarus/platformio.ini
  • variants/esp32s3/m5stack_cardputer_adv/platformio.ini
  • variants/esp32s3/station-g3/platformio.ini
  • variants/nrf52840/ELECROW-ThinkNode-M4/platformio.ini
  • variants/esp32s3/t-eth-elite/platformio.ini
  • variants/nrf52840/ELECROW-ThinkNode-M3/platformio.ini
  • variants/esp32s3/tlora-pager/platformio.ini
  • variants/esp32s3/heltec_capsule_sensor_v3/platformio.ini
  • variants/esp32s3/t-beam-1w/platformio.ini
  • variants/esp32s3/tlora_t3s3_v1/platformio.ini
  • variants/esp32s3/heltec_v4_r8/platformio.ini
  • variants/esp32s3/seeed-sensecap-indicator/platformio.ini
  • variants/esp32s3/rak3312/platformio.ini
  • variants/nrf52840/rak3401_1watt/platformio.ini
  • variants/esp32/m5stack_coreink/platformio.ini
  • variants/esp32s3/heltec_sensor_hub/platformio.ini
  • variants/esp32s3/t-deck/platformio.ini
  • variants/esp32/tlora_v2_1_16/platformio.ini
  • variants/esp32s3/tlora_t3s3_epaper/platformio.ini
  • variants/rp2350/rpipico2w/platformio.ini
  • variants/rp2040/rpipicow/platformio.ini
  • variants/nrf52840/ELECROW-ThinkNode-M8/platformio.ini
  • variants/nrf52840/t-echo-lite/platformio.ini
  • variants/esp32s3/rak_wismesh_tap_v2/platformio.ini
  • variants/esp32s3/t-deck-pro-v1_1/platformio.ini
  • variants/nrf52840/rak4631_nomadstar_meteor_pro/platformio.ini
  • variants/esp32/tbeam/platformio.ini
  • variants/esp32s3/seeed_xiao_s3/platformio.ini
  • variants/nrf52840/gat562_mesh_trial_tracker/platformio.ini
  • variants/esp32s3/mini-epaper-s3/platformio.ini
  • variants/esp32s3/hackaday-communicator/platformio.ini
  • variants/nrf52840/rak_wismeshtag/platformio.ini
  • variants/esp32s2/nugget_s2_lora/platformio.ini
  • variants/nrf52840/ELECROW-ThinkNode-M6/platformio.ini
  • variants/nrf52840/rak4631/platformio.ini
  • variants/nrf52840/t-echo/platformio.ini
  • variants/nrf52840/r1-neo/platformio.ini
  • variants/esp32s3/tbeam-s3-core/platformio.ini
  • variants/esp32s3/visualizer-hub75/platformio.ini
  • variants/esp32s3/elecrow_panel/platformio.ini
  • variants/esp32s3/heltec_v4/platformio.ini
  • variants/esp32s3/m5stack_cores3/platformio.ini
  • variants/nrf52840/ELECROW-ThinkNode-M1/platformio.ini
  • variants/nrf52840/heltec_mesh_node_t114-inkhud/platformio.ini
  • variants/esp32s3/picomputer-s3/platformio.ini
  • variants/nrf52840/t-echo-plus/platformio.ini
  • variants/esp32s3/heltec_v3/platformio.ini
  • variants/nrf52840/rak2560/platformio.ini
  • variants/nrf52840/meshlink/platformio.ini
  • variants/esp32s3/t-deck-pro/platformio.ini
  • variants/esp32s3/t5s3_epaper/platformio.ini
  • variants/nrf52840/rak4631_eth_gw/platformio.ini
  • variants/esp32s3/t-beam-bpf/platformio.ini
  • variants/esp32s3/t-watch-s3/platformio.ini

Comment thread bin/generate_ci_matrix.py
@vidplace7
vidplace7 requested review from NomDeTom and thebentern July 31, 2026 23:08
@vidplace7
vidplace7 force-pushed the check-yourself branch 2 times, most recently from dc46408 to 8e51c5e Compare August 1, 2026 19:17
@vidplace7 vidplace7 changed the title Remove board_check (now using normal matrix), run checks on PR/MQ Remove board_check (now using normal matrix) Aug 1, 2026
This was being misused / misunderstood (most were a no-op already).
@vidplace7
vidplace7 enabled auto-merge August 2, 2026 00:29
@vidplace7
vidplace7 disabled auto-merge August 2, 2026 01:03
@vidplace7
vidplace7 merged commit 8d3ad2a into develop Aug 2, 2026
62 checks passed
@vidplace7
vidplace7 deleted the check-yourself branch August 2, 2026 01:42
Manuel1910 pushed a commit to Manuel1910/firmware that referenced this pull request Aug 2, 2026
This was being misused / misunderstood (most were a no-op already).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

github_actions Pull requests that update GitHub Actions code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant