Remove board_check (now using normal matrix) - #11312
Conversation
⚡ Try this PR in the Web FlasherNote Building this pull request… the flash button, badges and supported-board |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (59)
💤 Files with no reviewable changes (57)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughThe PR removes ChangesCI matrix unification
Estimated code review effort: 3 (Moderate) | ~20 minutes Possibly related PRs
Suggested labels: Suggested reviewers: 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@bin/generate_ci_matrix.py`:
- Around line 68-77: Update the conditional block that filters environments in
the CI matrix generation logic to use four-space indentation consistently,
including the nested comments, conditions, and outlist.append calls, so it
passes Flake8 E111 without changing behavior.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro Plus
Run ID: 8ef2cbf3-1c38-47db-a0cd-a19bcf0d556f
📒 Files selected for processing (59)
.github/workflows/main_matrix.ymlbin/generate_ci_matrix.pyvariants/esp32/diy/v1/platformio.inivariants/esp32/m5stack_coreink/platformio.inivariants/esp32/rak11200/platformio.inivariants/esp32/tbeam/platformio.inivariants/esp32/tlora_v2_1_16/platformio.inivariants/esp32s2/nugget_s2_lora/platformio.inivariants/esp32s3/elecrow_panel/platformio.inivariants/esp32s3/hackaday-communicator/platformio.inivariants/esp32s3/heltec_capsule_sensor_v3/platformio.inivariants/esp32s3/heltec_sensor_hub/platformio.inivariants/esp32s3/heltec_v3/platformio.inivariants/esp32s3/heltec_v4/platformio.inivariants/esp32s3/heltec_v4_r8/platformio.inivariants/esp32s3/icarus/platformio.inivariants/esp32s3/m5stack_cardputer_adv/platformio.inivariants/esp32s3/m5stack_cores3/platformio.inivariants/esp32s3/mini-epaper-s3/platformio.inivariants/esp32s3/picomputer-s3/platformio.inivariants/esp32s3/rak3312/platformio.inivariants/esp32s3/rak_wismesh_tap_v2/platformio.inivariants/esp32s3/seeed-sensecap-indicator/platformio.inivariants/esp32s3/seeed_xiao_s3/platformio.inivariants/esp32s3/station-g2/platformio.inivariants/esp32s3/station-g3/platformio.inivariants/esp32s3/t-beam-1w/platformio.inivariants/esp32s3/t-beam-bpf/platformio.inivariants/esp32s3/t-deck-pro-v1_1/platformio.inivariants/esp32s3/t-deck-pro/platformio.inivariants/esp32s3/t-deck/platformio.inivariants/esp32s3/t-eth-elite/platformio.inivariants/esp32s3/t-watch-s3/platformio.inivariants/esp32s3/t5s3_epaper/platformio.inivariants/esp32s3/tbeam-s3-core/platformio.inivariants/esp32s3/tlora-pager/platformio.inivariants/esp32s3/tlora_t3s3_epaper/platformio.inivariants/esp32s3/tlora_t3s3_v1/platformio.inivariants/esp32s3/visualizer-hub75/platformio.inivariants/nrf52840/ELECROW-ThinkNode-M1/platformio.inivariants/nrf52840/ELECROW-ThinkNode-M3/platformio.inivariants/nrf52840/ELECROW-ThinkNode-M4/platformio.inivariants/nrf52840/ELECROW-ThinkNode-M6/platformio.inivariants/nrf52840/ELECROW-ThinkNode-M8/platformio.inivariants/nrf52840/gat562_mesh_trial_tracker/platformio.inivariants/nrf52840/heltec_mesh_node_t114-inkhud/platformio.inivariants/nrf52840/meshlink/platformio.inivariants/nrf52840/r1-neo/platformio.inivariants/nrf52840/rak2560/platformio.inivariants/nrf52840/rak3401_1watt/platformio.inivariants/nrf52840/rak4631/platformio.inivariants/nrf52840/rak4631_eth_gw/platformio.inivariants/nrf52840/rak4631_nomadstar_meteor_pro/platformio.inivariants/nrf52840/rak_wismeshtag/platformio.inivariants/nrf52840/t-echo-lite/platformio.inivariants/nrf52840/t-echo-plus/platformio.inivariants/nrf52840/t-echo/platformio.inivariants/rp2040/rpipicow/platformio.inivariants/rp2350/rpipico2w/platformio.ini
💤 Files with no reviewable changes (57)
- variants/esp32/rak11200/platformio.ini
- variants/esp32/diy/v1/platformio.ini
- variants/esp32s3/station-g2/platformio.ini
- variants/esp32s3/icarus/platformio.ini
- variants/esp32s3/m5stack_cardputer_adv/platformio.ini
- variants/esp32s3/station-g3/platformio.ini
- variants/nrf52840/ELECROW-ThinkNode-M4/platformio.ini
- variants/esp32s3/t-eth-elite/platformio.ini
- variants/nrf52840/ELECROW-ThinkNode-M3/platformio.ini
- variants/esp32s3/tlora-pager/platformio.ini
- variants/esp32s3/heltec_capsule_sensor_v3/platformio.ini
- variants/esp32s3/t-beam-1w/platformio.ini
- variants/esp32s3/tlora_t3s3_v1/platformio.ini
- variants/esp32s3/heltec_v4_r8/platformio.ini
- variants/esp32s3/seeed-sensecap-indicator/platformio.ini
- variants/esp32s3/rak3312/platformio.ini
- variants/nrf52840/rak3401_1watt/platformio.ini
- variants/esp32/m5stack_coreink/platformio.ini
- variants/esp32s3/heltec_sensor_hub/platformio.ini
- variants/esp32s3/t-deck/platformio.ini
- variants/esp32/tlora_v2_1_16/platformio.ini
- variants/esp32s3/tlora_t3s3_epaper/platformio.ini
- variants/rp2350/rpipico2w/platformio.ini
- variants/rp2040/rpipicow/platformio.ini
- variants/nrf52840/ELECROW-ThinkNode-M8/platformio.ini
- variants/nrf52840/t-echo-lite/platformio.ini
- variants/esp32s3/rak_wismesh_tap_v2/platformio.ini
- variants/esp32s3/t-deck-pro-v1_1/platformio.ini
- variants/nrf52840/rak4631_nomadstar_meteor_pro/platformio.ini
- variants/esp32/tbeam/platformio.ini
- variants/esp32s3/seeed_xiao_s3/platformio.ini
- variants/nrf52840/gat562_mesh_trial_tracker/platformio.ini
- variants/esp32s3/mini-epaper-s3/platformio.ini
- variants/esp32s3/hackaday-communicator/platformio.ini
- variants/nrf52840/rak_wismeshtag/platformio.ini
- variants/esp32s2/nugget_s2_lora/platformio.ini
- variants/nrf52840/ELECROW-ThinkNode-M6/platformio.ini
- variants/nrf52840/rak4631/platformio.ini
- variants/nrf52840/t-echo/platformio.ini
- variants/nrf52840/r1-neo/platformio.ini
- variants/esp32s3/tbeam-s3-core/platformio.ini
- variants/esp32s3/visualizer-hub75/platformio.ini
- variants/esp32s3/elecrow_panel/platformio.ini
- variants/esp32s3/heltec_v4/platformio.ini
- variants/esp32s3/m5stack_cores3/platformio.ini
- variants/nrf52840/ELECROW-ThinkNode-M1/platformio.ini
- variants/nrf52840/heltec_mesh_node_t114-inkhud/platformio.ini
- variants/esp32s3/picomputer-s3/platformio.ini
- variants/nrf52840/t-echo-plus/platformio.ini
- variants/esp32s3/heltec_v3/platformio.ini
- variants/nrf52840/rak2560/platformio.ini
- variants/nrf52840/meshlink/platformio.ini
- variants/esp32s3/t-deck-pro/platformio.ini
- variants/esp32s3/t5s3_epaper/platformio.ini
- variants/nrf52840/rak4631_eth_gw/platformio.ini
- variants/esp32s3/t-beam-bpf/platformio.ini
- variants/esp32s3/t-watch-s3/platformio.ini
dc46408 to
8e51c5e
Compare
8e51c5e to
d6428ee
Compare
This was being misused / misunderstood (most were a no-op already).
d6428ee to
2bd1286
Compare
This was being misused / misunderstood (most were a no-op already).
Forward-ported from #11151 (WIP)
This was being misused / misunderstood (most were a no-op already).
Depends on fixes in:
Summary by CodeRabbit
CI Improvements
Configuration