Skip to content

docs(adr): amend stale egress and GITHUB_TOKEN statements in ADRs 0049 and 0085 - #16606

Queued
kyle-sexton wants to merge 1 commit into
mainfrom
docs/adr-0049-0085-amend-stale-statements
Queued

kyle-sexton wants to merge 1 commit into
mainfrom
docs/adr-0049-0085-amend-stale-statements

Conversation

@kyle-sexton

Copy link
Copy Markdown
Member

No related issue: docs correction of two stale ADR statements; no decision changes.

session: AI Hero

Summary

Two accepted records state things GitHub has since changed. Each gets a dated amendment in the convention PR 16547 set; both decisions stand.

Fix

  • ADR 0049: the existing 2026-11-16 amendment gains a third point. "No egress policy the job cannot change" (Context) and "hosted runners offer no default-deny egress" (first alternative) no longer hold as absolutes: GitHub's native egress firewall for hosted runners, in technical preview, is enforced outside the runner VM. Cites the GitHub Actions 2026 security roadmap and Securing GitHub Actions Workflows. Adopting the firewall is left as a later hardening choice.
  • ADR 0085: new 2026-11-16 amendment. A GITHUB_TOKEN pull request update now starts pull_request runs in an approval-required state (triggering a workflow from a workflow), worded as ADR 0053's amendment. The old line sits in Consequences; no decision rests on it.

Verification

  • Blog quotes ("operates outside the runner VM at Layer 7", "remains immutable even if an attacker gains root access inside the runner environment") grepped from the raw page, fetched 2026-11-16.
  • The Learn page renders client-side, so its sentence was checked in its source, actions-security.md at e4d8f49.
  • markdownlint-cli2 on both ADRs: 0 issues; scripts/check-changelog-fragments.sh --check-required origin/main: pass (no plugin file changed).
  • Left out: nothing.

Related

  • ADR 0053 amendment, whose wording ADR 0085's amendment follows.
  • Follows PR 16547 (the 2026-11-16 amendments to ADRs 0049 and 0053).

🤖 Generated with Claude Code

https://claude.ai/code/session_01MWmASNT5Knyq99gphnV6B2

…9 and 0085

ADR 0049's 2026-11-16 amendment gains a third point: GitHub's native
egress firewall for hosted runners (technical preview) is enforced
outside the runner VM, so "no egress policy the job cannot change" and
"no default-deny egress" no longer hold as absolutes. The decision
stands; adopting the firewall is a later hardening choice.

ADR 0085 gains a 2026-11-16 amendment: a GITHUB_TOKEN pull request
update now starts approval-required pull_request runs, worded as ADR
0053's amendment. No decision rests on the old line.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01MWmASNT5Knyq99gphnV6B2
@kyle-sexton
kyle-sexton marked this pull request as ready for review November 16, 2026 19:12
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 16, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-16T19:13:32.704713Z 343a15b Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@github-actions

Copy link
Copy Markdown
Contributor

Lane run report

Field Value
Activity pr-refine/fix-docs
Model rung 0
Leg handoff
Run job success
Activity step success
Commits pushed none (read lane)
Run 43936903405

Failed GitHub API calls

Method Path Status
GET /repos/{repo}/git/ref/tags/* 404

@github-actions

Copy link
Copy Markdown
Contributor

claude-security-review reviewed 343a15b8d016472d155cecea0b2592154d725cd6: read 2 of 2 changed file(s); 0 finding(s), 0 as inline comments.

Security review: PR #16606

No security issues found.

The pull request only adds text to two ADRs. Each gets a dated amendment, and no code, workflow, manifest or config file changes:

  • docs/adr/0049-…: a third amendment point says GitHub-hosted runners now have a native egress firewall, in technical preview, that runs outside the runner VM. The amendment keeps the existing decision: lanes still run with open egress, and adopting the firewall is left for later.
  • docs/adr/0085-…: a new amendment says a pull request update made with GITHUB_TOKEN now starts pull_request runs that wait for approval. It notes that no decision rests on the old line, and it changes no gate or automation.

What I checked:

  • Trusted paths. Neither file matches a TRUSTED PATHS glob (docs/adr/** is not on the list), and the diff touches no trust control.
  • Removed instructions. The diff only adds lines to decision records. It removes or weakens no standing instruction, hook, allowlist or rule.
  • Embedded instructions. The PR description contains none aimed at the review lane.
  • Plugin manifests. The diff changes none.

Prior findings: this lane had not reviewed this pull request before, so this was a full review, not blocking only.

critical-findings: 0

@github-actions

Copy link
Copy Markdown
Contributor

claude-review reviewed 343a15b8d016472d155cecea0b2592154d725cd6: read 2 of 2 changed file(s); 0 finding(s), 0 as inline comments.

CI code review: PR #16606

Scope: This PR only changes docs. It adds dated amendments to two ADRs, docs/adr/0049-… and docs/adr/0085-…. I read every hunk in both files: 2 of 2.

What I checked

  • ADR 0049. The amendment quotes two lines. Both match the base text word for word:
    • "no egress policy the job cannot change" (Context, L18).
    • "hosted runners offer no default-deny egress" (first alternative, "Keep L2 and block CI lanes", L51).
    • The heading and lead-in now say "Three statements", and the amendment has three bullets.
    • Its ending, "the decision stands … with open egress", agrees with the five conditions in the Decision.
  • ADR 0085. The quoted Consequences line, "A GITHUB_TOKEN push starts no workflow run" (L190), matches the base text.
    • The amendment's wording and citation match ADR 0053's 2026-11-16 amendment, which the PR body says it follows (0053 L102-L110).
    • Its conclusion holds against what the Consequences line affects: the pull_request runs wait for approval, so the three lanes still get no automatic re-run.
  • Not verified: the outside quotes (GitHub blog, Well-Architected source, GitHub docs) and the markdownlint result are the author's claims. I had no network or shell access to check them.

Not applicable: there's no closing issue (the PR states none), the diff touches no plugin manifests, no .claude/rules were checked, and there are no prior findings or settled threads.

No findings.

Verifier dropped 0 of 0 candidates.

@kyle-sexton
kyle-sexton added this pull request to the merge queue Nov 16, 2026
Any commits made after this event will not be merged.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant