Repository navigation
docs(adr): amend stale egress and GITHUB_TOKEN statements in ADRs 0049 and 0085 - #16606
kyle-sexton wants to merge 1 commit into
Conversation
…9 and 0085 ADR 0049's 2026-11-16 amendment gains a third point: GitHub's native egress firewall for hosted runners (technical preview) is enforced outside the runner VM, so "no egress policy the job cannot change" and "no default-deny egress" no longer hold as absolutes. The decision stands; adopting the firewall is a later hardening choice. ADR 0085 gains a 2026-11-16 amendment: a GITHUB_TOKEN pull request update now starts approval-required pull_request runs, worded as ADR 0053's amendment. No decision rests on the old line. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01MWmASNT5Knyq99gphnV6B2
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Lane run report
Failed GitHub API calls
|
|
claude-security-review reviewed Security review: PR #16606No security issues found. The pull request only adds text to two ADRs. Each gets a dated amendment, and no code, workflow, manifest or config file changes:
What I checked:
Prior findings: this lane had not reviewed this pull request before, so this was a full review, not blocking only. critical-findings: 0 |
|
claude-review reviewed CI code review: PR #16606Scope: This PR only changes docs. It adds dated amendments to two ADRs, What I checked
Not applicable: there's no closing issue (the PR states none), the diff touches no plugin manifests, no No findings. Verifier dropped 0 of 0 candidates. |
No related issue: docs correction of two stale ADR statements; no decision changes.
session: AI Hero
Summary
Two accepted records state things GitHub has since changed. Each gets a dated amendment in the convention PR 16547 set; both decisions stand.
Fix
GITHUB_TOKENpull request update now startspull_requestruns in an approval-required state (triggering a workflow from a workflow), worded as ADR 0053's amendment. The old line sits in Consequences; no decision rests on it.Verification
actions-security.mdate4d8f49.markdownlint-cli2on both ADRs: 0 issues;scripts/check-changelog-fragments.sh --check-required origin/main: pass (no plugin file changed).Related
🤖 Generated with Claude Code
https://claude.ai/code/session_01MWmASNT5Knyq99gphnV6B2