Skip to content

ci(dependabot): let Dependabot bump the ci-workflows action pins - #566

Merged
kyle-sexton merged 4 commits into
mainfrom
ci/dependabot-first-party-actions
Nov 15, 2026
Merged

kyle-sexton merged 4 commits into
mainfrom
ci/dependabot-first-party-actions

Conversation

@kyle-sexton

Copy link
Copy Markdown
Member

No related issue: the first-party action pin work, tracked in the owner's audit session.

Summary

Dependabot ignored this repository's melodic-software/ci-workflows action pins, and release/dependencies.json
held a second copy of the pinned commit that every bump had to edit by hand. After this change the workflow uses:
lines are the only record of that pin, as they already are for every other Action, Dependabot keeps the pins on the
newest ci-workflows release, and the auto-merge caller merges that bump with no manual edit.

Fix

Tooling (first commit, green with the pins still on v0.73.0):

  • release/dependencies.json: the melodic-software/ci-workflows entry leaves repositoryPins (now []).
  • scripts/ReleasePinSources.ps1 (Get-WorkflowActionPins): ci-workflows composite actions are read like every other
    Action, so every use must name one commit and one # vX.Y.Z release. Two ci-workflows references are skipped: a
    reusable workflow called at @main, and the pin in a SYNC-MANAGED FILE.
  • scripts/Test-DependencyFreshness.ps1: one expression made safe for an empty repositoryPins under StrictMode.
  • .github/scripts/workflow-pin-metadata.test.cjs: the manifest-agreement test is removed; the caller inventory, the
    one-commit and the one-release assertions stay. .github/scripts/release-pins.test.cjs gains two cases: a grouped
    ci-workflows bump passes with no manifest edit, and two different ci-workflows releases fail with their locations.
  • docs/releases.md: states the rule as it now is.

Pins and Dependabot (second commit):

  • .github/workflows/pr-require-checks.yml: the sixteen ci-workflows action pins move from v0.73.0 to the v0.74.0
    release commit 944d346c487c79eaf85dff752586fb59b0f5c539. The pin in the sync-managed
    pr-check-managed-files-hosted.yml is unchanged.
  • .github/dependabot.yml, the github-actions entry: the ignore of melodic-software/ci-workflows/* becomes an
    ignore of that one sync-managed pin; first-party releases are excluded from the cooldown; a first-party-actions
    group moves every ci-workflows pin in one pull request.

What the release freshness gate checks for ci-workflows

  • Before: the repositoryPins commit had to be an ancestor of ci-workflows' default branch, and drift was counted
    from later commits on that branch. No tag or # v comment was checked.
  • After: as for every other Action, drift is measured against the newest stable release, exactly one release must
    exist for the pinned version, and that release's tag must map to the pinned commit.
  • Lost: the ancestry check and drift counted from unreleased commits. Gained: the release and tag-to-commit checks.

The published compatibility.json never recorded the ci-workflows commit, so no release artifact changes shape.
No other repository reads repositoryPins.

Verification

  • node --test .github/scripts/workflow-pin-metadata.test.cjs .github/scripts/release-pins.test.cjs: 10 pass, 0 fail.
  • pwsh -NoProfile -File scripts/Test-ReleasePins.ps1 -RepositoryRoot .: Release and workflow pins are internally consistent.
  • A copy of the tree with all sixteen pins rewritten to another commit and # v0.75.0, manifest untouched: both
    checks pass. With one pin rewritten and fifteen left: both fail.
  • standards components/dependabot-policy/dependabot-policy.mjs --root .: Dependabot policy passed.
  • Not run: Test-DependencyFreshness.ps1, which needs the network and Docker; ci-workflows v0.74.0 is a published
    release whose tag maps to 944d346c.

Related

🤖 Generated with Claude Code

kyle-sexton and others added 2 commits November 15, 2026 14:19
release/dependencies.json no longer records a ci-workflows repository pin.
The composite-action uses: lines are its only record, as for every other
Action: ReleasePinSources.ps1 requires them to name one commit and one
`# vX.Y.Z` release, skipping @main reusable callers and the sync-managed
pin, and the freshness gate checks the tag and its commit like other Actions.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The sixteen ci-workflows composite-action pins in pr-require-checks.yml move
to the v0.74.0 release commit with a `# v0.74.0` comment. Dependabot then
keeps them current: the blanket ignore of melodic-software/ci-workflows
becomes an ignore of the one pin in the sync-managed file, first-party
releases skip the cooldown, and they move together in a `first-party-actions`
group that the auto-merge caller arms from the synced Dependabot policy.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 15, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-15T19:50:04.589498Z cf9640d PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

Comment thread .github/dependabot.yml Resolved
Comment thread scripts/ReleasePinSources.ps1 Resolved
@github-actions

github-actions Bot commented Nov 15, 2026 •

Copy link
Copy Markdown

claude-security-review reviewed 5f34d4c4777fb5952df89c398ec1e2a6073db51f: 0 finding(s), 0 as inline comments.

Security review (incremental, head 5f34d4c, since 46f47c2)

No security findings.

Scope: .github/scripts/workflow-pin-metadata.test.cjs, the only file changed since the last review.

The change replaces the SYNC-MANAGED FILE substring check (source.includes) with an anchored, multiline regex (/^#\s*SYNC-MANAGED FILE/mu). The marker now counts only when it opens a comment line.

That marker switches the test to advisory pin checking for a workflow. Before, the string anywhere in a workflow, such as a step name or an echoed string, was enough to skip the stricter canonical pin check for that file. Now only a # SYNC-MANAGED FILE comment line does. The change tightens the control and widens nothing.

  • The file is a test and does not run in any workflow.
  • It is not on any trusted-path or hold-path glob and does not widen who is trusted, a token's scope, a kill switch, a merge hold, or what untrusted text reaches a lane.
  • No secrets, credentials, injection surface, or new input reach code that runs.

No manifest fields were touched, and no instruction-surface deletions are in the diff.

critical-findings: 0

@github-actions

github-actions Bot commented Nov 15, 2026 •

Copy link
Copy Markdown

claude-review reviewed 5f34d4c4777fb5952df89c398ec1e2a6073db51f: 0 finding(s), 0 as inline comments.

Incremental review of .github/scripts/workflow-pin-metadata.test.cjs (46f47c2 → 5f34d4c). No findings.

The change replaces the substring check for SYNC-MANAGED FILE with an anchored, multiline regex: /^#\s*SYNC-MANAGED FILE/mu. The check now matches only a comment line that starts with the marker, not the marker text anywhere in a workflow file.

  • The three sync-managed workflows (pr-review-hosted.yml, pr-review-security-hosted.yml, pr-check-managed-files-hosted.yml) all carry the marker on line 3 as # SYNC-MANAGED FILE: DO NOT EDIT…. The new pattern matches that form.
  • The regex has no g or y flag, so .test() keeps no lastIndex state between files.
  • \s* can also span a newline (# alone on a line, with the marker on the next). That is harmless here.
  • I did not run the test file. The sandbox refused the node --test command, so I have not confirmed the test passes. This review rests on reading the diff and grepping the marker lines.

Verifier dropped 0 of 0 candidates.

kyle-sexton and others added 2 commits November 15, 2026 14:52
The pin checks exempted a ci-workflows reference in any file containing
the text SYNC-MANAGED FILE anywhere. The marker must now start a comment
line, as it does in the three synced workflow files. The Dependabot group
comment also says where a first-party major goes: it stays in
first-party-actions, and the auto-merge lane does not arm it.

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
The test matched the marker anywhere in a workflow file, while the two
PowerShell checks now need it at the start of a comment line. All three
use the same anchored pattern.

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
@kyle-sexton
kyle-sexton merged commit 7d94a06 into main Nov 15, 2026
28 checks passed
@kyle-sexton
kyle-sexton deleted the ci/dependabot-first-party-actions branch November 15, 2026 20:00
kyle-sexton added a commit to melodic-software/agent-plugins that referenced this pull request Nov 15, 2026
…actions (#144)

No related issue: the first-party action pin work, tracked in the
owner's audit session.

## Summary

Two comments described the Dependabot auto-merge lane as it was before
the first-party pins moved to Dependabot.
This change corrects them. Comments only: no trigger, permission, group
or pin changes.

## Fix

- `.github/workflows/pr-automerge-dependabot.yml`, header: the lane also
arms `melodic-software/*` bumps, through
the synced Dependabot policy copy (`fastTrack.own`), not only the vendor
publishers.
- `.github/dependabot.yml`: a pull request the lane does not arm takes
the review tier (an AI review lane's `merge`
verdict), where the comment said a person merges it; and, where the
comment covers majors, a first-party major
stays in `first-party-actions` instead of falling through to the
catch-all group.

## Verification

- ci-workflows `pr-automerge-dependabot.yml` header on main: with the
synced copy at
`.github/standards/dependabot-policy/policy.json`, the allowlist is the
copy's `tier: auto` publishers plus its
`fastTrack` `github-actions` and `own` globs; "a grouped PR with one
major bump ... is skipped".
- standards `components/dependabot-policy/policy.json` on main:
`fastTrack.own` is `melodic-software/*`.
- standards `components/dependabot-policy/README.md:183` on main: "No
Dependabot pull request waits on a human."
- `git diff` touches comment lines only.

## Related

- melodic-software/ci-runner#566 (its `dependabot.yml` already carries
this wording)

🤖 Generated with [Claude Code](https://claude.com/claude-code)

---------

Co-authored-by: Claude Fable 5.2 <noreply@anthropic.com>
kyle-sexton added a commit to melodic-software/cursor-plugins that referenced this pull request Nov 15, 2026
…actions (#163)

No related issue: the first-party action pin work, tracked in the
owner's audit session.

## Summary

Two comments described the Dependabot auto-merge lane as it was before
the first-party pins moved to Dependabot.
This change corrects them. Comments only: no trigger, permission, group
or pin changes.

## Fix

- `.github/workflows/pr-automerge-dependabot.yml`, header: the lane also
arms `melodic-software/*` bumps, through
the synced Dependabot policy copy (`fastTrack.own`), not only the vendor
publishers.
- `.github/dependabot.yml`: a pull request the lane does not arm takes
the review tier (an AI review lane's `merge`
verdict), where the comment said a person merges it; and, where the
comment covers majors, a first-party major
stays in `first-party-actions` instead of falling through to the
catch-all group.

## Verification

- ci-workflows `pr-automerge-dependabot.yml` header on main: with the
synced copy at
`.github/standards/dependabot-policy/policy.json`, the allowlist is the
copy's `tier: auto` publishers plus its
`fastTrack` `github-actions` and `own` globs; "a grouped PR with one
major bump ... is skipped".
- standards `components/dependabot-policy/policy.json` on main:
`fastTrack.own` is `melodic-software/*`.
- standards `components/dependabot-policy/README.md:183` on main: "No
Dependabot pull request waits on a human."
- `git diff` touches comment lines only.

## Related

- melodic-software/ci-runner#566 (its `dependabot.yml` already carries
this wording)

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-authored-by: Claude Fable 5.2 <noreply@anthropic.com>
kyle-sexton added a commit to melodic-software/codex-plugins that referenced this pull request Nov 15, 2026
…actions (#194)

No related issue: the first-party action pin work, tracked in the
owner's audit session.

## Summary

Two comments described the Dependabot auto-merge lane as it was before
the first-party pins moved to Dependabot.
This change corrects them. Comments only: no trigger, permission, group
or pin changes.

## Fix

- `.github/workflows/pr-automerge-dependabot.yml`, header: the lane also
arms `melodic-software/*` bumps, through
the synced Dependabot policy copy (`fastTrack.own`), not only the vendor
publishers.
- `.github/dependabot.yml`: a pull request the lane does not arm takes
the review tier (an AI review lane's `merge`
verdict), where the comment said a person merges it; and, where the
comment covers majors, a first-party major
stays in `first-party-actions` instead of falling through to the
catch-all group.

## Verification

- ci-workflows `pr-automerge-dependabot.yml` header on main: with the
synced copy at
`.github/standards/dependabot-policy/policy.json`, the allowlist is the
copy's `tier: auto` publishers plus its
`fastTrack` `github-actions` and `own` globs; "a grouped PR with one
major bump ... is skipped".
- standards `components/dependabot-policy/policy.json` on main:
`fastTrack.own` is `melodic-software/*`.
- standards `components/dependabot-policy/README.md:183` on main: "No
Dependabot pull request waits on a human."
- `git diff` touches comment lines only.

## Related

- melodic-software/ci-runner#566 (its `dependabot.yml` already carries
this wording)

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-authored-by: Claude Fable 5.2 <noreply@anthropic.com>
kyle-sexton added a commit to melodic-software/claude-code-account-rotation that referenced this pull request Nov 15, 2026
…actions (#458)

No related issue: the first-party action pin work, tracked in the
owner's audit session.

## Summary

Two comments described the Dependabot auto-merge lane as it was before
the first-party pins moved to Dependabot.
This change corrects them. Comments only: no trigger, permission, group
or pin changes.

## Fix

- `.github/workflows/pr-automerge-dependabot.yml`, header: the lane also
arms `melodic-software/*` bumps, through
the synced Dependabot policy copy (`fastTrack.own`), not only the vendor
publishers.
- `.github/dependabot.yml`: a pull request the lane does not arm takes
the review tier (an AI review lane's `merge`
verdict), where the comment said a person merges it; and, where the
comment covers majors, a first-party major
stays in `first-party-actions` instead of falling through to the
catch-all group.

## Verification

- ci-workflows `pr-automerge-dependabot.yml` header on main: with the
synced copy at
`.github/standards/dependabot-policy/policy.json`, the allowlist is the
copy's `tier: auto` publishers plus its
`fastTrack` `github-actions` and `own` globs; "a grouped PR with one
major bump ... is skipped".
- standards `components/dependabot-policy/policy.json` on main:
`fastTrack.own` is `melodic-software/*`.
- standards `components/dependabot-policy/README.md:183` on main: "No
Dependabot pull request waits on a human."
- `git diff` touches comment lines only.

## Related

- melodic-software/ci-runner#566 (its `dependabot.yml` already carries
this wording)

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-authored-by: Claude Fable 5.2 <noreply@anthropic.com>
kyle-sexton added a commit that referenced this pull request Nov 15, 2026
…actions (#569)

No related issue: the first-party action pin work, tracked in the
owner's audit session.

## Summary

Two comments described the Dependabot auto-merge lane as it was before
the first-party pins moved to Dependabot.
This change corrects them. Comments only: no trigger, permission, group
or pin changes.

## Fix

- `.github/workflows/pr-automerge-dependabot.yml`, header: the lane also
arms `melodic-software/*` bumps, through
the synced Dependabot policy copy (`fastTrack.own`), not only the vendor
publishers.
- `.github/dependabot.yml`: a pull request the lane does not arm takes
the review tier (an AI review lane's `merge`
verdict), where the comment said a person merges it; and, where the
comment covers majors, a first-party major
stays in `first-party-actions` instead of falling through to the
catch-all group.

## Verification

- ci-workflows `pr-automerge-dependabot.yml` header on main: with the
synced copy at
`.github/standards/dependabot-policy/policy.json`, the allowlist is the
copy's `tier: auto` publishers plus its
`fastTrack` `github-actions` and `own` globs; "a grouped PR with one
major bump ... is skipped".
- standards `components/dependabot-policy/policy.json` on main:
`fastTrack.own` is `melodic-software/*`.
- standards `components/dependabot-policy/README.md:183` on main: "No
Dependabot pull request waits on a human."
- `git diff` touches comment lines only.

## Related

- #566 (its `dependabot.yml` already carries
this wording)

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-authored-by: Claude Fable 5.2 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant