Repository navigation
ci(dependabot): let Dependabot bump the ci-workflows action pins - #566
Conversation
release/dependencies.json no longer records a ci-workflows repository pin. The composite-action uses: lines are its only record, as for every other Action: ReleasePinSources.ps1 requires them to name one commit and one `# vX.Y.Z` release, skipping @main reusable callers and the sync-managed pin, and the freshness gate checks the tag and its commit like other Actions. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The sixteen ci-workflows composite-action pins in pr-require-checks.yml move to the v0.74.0 release commit with a `# v0.74.0` comment. Dependabot then keeps them current: the blanket ignore of melodic-software/ci-workflows becomes an ignore of the one pin in the sync-managed file, first-party releases skip the cooldown, and they move together in a `first-party-actions` group that the auto-merge caller arms from the synced Dependabot policy. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
claude-security-review reviewed Security review (incremental, head 5f34d4c, since 46f47c2)No security findings. Scope: The change replaces the That marker switches the test to advisory pin checking for a workflow. Before, the string anywhere in a workflow, such as a step name or an echoed string, was enough to skip the stricter canonical pin check for that file. Now only a
No manifest fields were touched, and no instruction-surface deletions are in the diff. critical-findings: 0 |
|
claude-review reviewed Incremental review of The change replaces the substring check for
Verifier dropped 0 of 0 candidates. |
The pin checks exempted a ci-workflows reference in any file containing the text SYNC-MANAGED FILE anywhere. The marker must now start a comment line, as it does in the three synced workflow files. The Dependabot group comment also says where a first-party major goes: it stays in first-party-actions, and the auto-merge lane does not arm it. Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
The test matched the marker anywhere in a workflow file, while the two PowerShell checks now need it at the start of a comment line. All three use the same anchored pattern. Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
…actions (#144) No related issue: the first-party action pin work, tracked in the owner's audit session. ## Summary Two comments described the Dependabot auto-merge lane as it was before the first-party pins moved to Dependabot. This change corrects them. Comments only: no trigger, permission, group or pin changes. ## Fix - `.github/workflows/pr-automerge-dependabot.yml`, header: the lane also arms `melodic-software/*` bumps, through the synced Dependabot policy copy (`fastTrack.own`), not only the vendor publishers. - `.github/dependabot.yml`: a pull request the lane does not arm takes the review tier (an AI review lane's `merge` verdict), where the comment said a person merges it; and, where the comment covers majors, a first-party major stays in `first-party-actions` instead of falling through to the catch-all group. ## Verification - ci-workflows `pr-automerge-dependabot.yml` header on main: with the synced copy at `.github/standards/dependabot-policy/policy.json`, the allowlist is the copy's `tier: auto` publishers plus its `fastTrack` `github-actions` and `own` globs; "a grouped PR with one major bump ... is skipped". - standards `components/dependabot-policy/policy.json` on main: `fastTrack.own` is `melodic-software/*`. - standards `components/dependabot-policy/README.md:183` on main: "No Dependabot pull request waits on a human." - `git diff` touches comment lines only. ## Related - melodic-software/ci-runner#566 (its `dependabot.yml` already carries this wording) 🤖 Generated with [Claude Code](https://claude.com/claude-code) --------- Co-authored-by: Claude Fable 5.2 <noreply@anthropic.com>
…actions (#163) No related issue: the first-party action pin work, tracked in the owner's audit session. ## Summary Two comments described the Dependabot auto-merge lane as it was before the first-party pins moved to Dependabot. This change corrects them. Comments only: no trigger, permission, group or pin changes. ## Fix - `.github/workflows/pr-automerge-dependabot.yml`, header: the lane also arms `melodic-software/*` bumps, through the synced Dependabot policy copy (`fastTrack.own`), not only the vendor publishers. - `.github/dependabot.yml`: a pull request the lane does not arm takes the review tier (an AI review lane's `merge` verdict), where the comment said a person merges it; and, where the comment covers majors, a first-party major stays in `first-party-actions` instead of falling through to the catch-all group. ## Verification - ci-workflows `pr-automerge-dependabot.yml` header on main: with the synced copy at `.github/standards/dependabot-policy/policy.json`, the allowlist is the copy's `tier: auto` publishers plus its `fastTrack` `github-actions` and `own` globs; "a grouped PR with one major bump ... is skipped". - standards `components/dependabot-policy/policy.json` on main: `fastTrack.own` is `melodic-software/*`. - standards `components/dependabot-policy/README.md:183` on main: "No Dependabot pull request waits on a human." - `git diff` touches comment lines only. ## Related - melodic-software/ci-runner#566 (its `dependabot.yml` already carries this wording) 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-authored-by: Claude Fable 5.2 <noreply@anthropic.com>
…actions (#194) No related issue: the first-party action pin work, tracked in the owner's audit session. ## Summary Two comments described the Dependabot auto-merge lane as it was before the first-party pins moved to Dependabot. This change corrects them. Comments only: no trigger, permission, group or pin changes. ## Fix - `.github/workflows/pr-automerge-dependabot.yml`, header: the lane also arms `melodic-software/*` bumps, through the synced Dependabot policy copy (`fastTrack.own`), not only the vendor publishers. - `.github/dependabot.yml`: a pull request the lane does not arm takes the review tier (an AI review lane's `merge` verdict), where the comment said a person merges it; and, where the comment covers majors, a first-party major stays in `first-party-actions` instead of falling through to the catch-all group. ## Verification - ci-workflows `pr-automerge-dependabot.yml` header on main: with the synced copy at `.github/standards/dependabot-policy/policy.json`, the allowlist is the copy's `tier: auto` publishers plus its `fastTrack` `github-actions` and `own` globs; "a grouped PR with one major bump ... is skipped". - standards `components/dependabot-policy/policy.json` on main: `fastTrack.own` is `melodic-software/*`. - standards `components/dependabot-policy/README.md:183` on main: "No Dependabot pull request waits on a human." - `git diff` touches comment lines only. ## Related - melodic-software/ci-runner#566 (its `dependabot.yml` already carries this wording) 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-authored-by: Claude Fable 5.2 <noreply@anthropic.com>
…actions (#458) No related issue: the first-party action pin work, tracked in the owner's audit session. ## Summary Two comments described the Dependabot auto-merge lane as it was before the first-party pins moved to Dependabot. This change corrects them. Comments only: no trigger, permission, group or pin changes. ## Fix - `.github/workflows/pr-automerge-dependabot.yml`, header: the lane also arms `melodic-software/*` bumps, through the synced Dependabot policy copy (`fastTrack.own`), not only the vendor publishers. - `.github/dependabot.yml`: a pull request the lane does not arm takes the review tier (an AI review lane's `merge` verdict), where the comment said a person merges it; and, where the comment covers majors, a first-party major stays in `first-party-actions` instead of falling through to the catch-all group. ## Verification - ci-workflows `pr-automerge-dependabot.yml` header on main: with the synced copy at `.github/standards/dependabot-policy/policy.json`, the allowlist is the copy's `tier: auto` publishers plus its `fastTrack` `github-actions` and `own` globs; "a grouped PR with one major bump ... is skipped". - standards `components/dependabot-policy/policy.json` on main: `fastTrack.own` is `melodic-software/*`. - standards `components/dependabot-policy/README.md:183` on main: "No Dependabot pull request waits on a human." - `git diff` touches comment lines only. ## Related - melodic-software/ci-runner#566 (its `dependabot.yml` already carries this wording) 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-authored-by: Claude Fable 5.2 <noreply@anthropic.com>
…actions (#569) No related issue: the first-party action pin work, tracked in the owner's audit session. ## Summary Two comments described the Dependabot auto-merge lane as it was before the first-party pins moved to Dependabot. This change corrects them. Comments only: no trigger, permission, group or pin changes. ## Fix - `.github/workflows/pr-automerge-dependabot.yml`, header: the lane also arms `melodic-software/*` bumps, through the synced Dependabot policy copy (`fastTrack.own`), not only the vendor publishers. - `.github/dependabot.yml`: a pull request the lane does not arm takes the review tier (an AI review lane's `merge` verdict), where the comment said a person merges it; and, where the comment covers majors, a first-party major stays in `first-party-actions` instead of falling through to the catch-all group. ## Verification - ci-workflows `pr-automerge-dependabot.yml` header on main: with the synced copy at `.github/standards/dependabot-policy/policy.json`, the allowlist is the copy's `tier: auto` publishers plus its `fastTrack` `github-actions` and `own` globs; "a grouped PR with one major bump ... is skipped". - standards `components/dependabot-policy/policy.json` on main: `fastTrack.own` is `melodic-software/*`. - standards `components/dependabot-policy/README.md:183` on main: "No Dependabot pull request waits on a human." - `git diff` touches comment lines only. ## Related - #566 (its `dependabot.yml` already carries this wording) 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-authored-by: Claude Fable 5.2 <noreply@anthropic.com>
No related issue: the first-party action pin work, tracked in the owner's audit session.
Summary
Dependabot ignored this repository's
melodic-software/ci-workflowsaction pins, andrelease/dependencies.jsonheld a second copy of the pinned commit that every bump had to edit by hand. After this change the workflow
uses:lines are the only record of that pin, as they already are for every other Action, Dependabot keeps the pins on the
newest ci-workflows release, and the auto-merge caller merges that bump with no manual edit.
Fix
Tooling (first commit, green with the pins still on v0.73.0):
release/dependencies.json: themelodic-software/ci-workflowsentry leavesrepositoryPins(now[]).scripts/ReleasePinSources.ps1(Get-WorkflowActionPins): ci-workflows composite actions are read like every otherAction, so every use must name one commit and one
# vX.Y.Zrelease. Two ci-workflows references are skipped: areusable workflow called at
@main, and the pin in aSYNC-MANAGED FILE.scripts/Test-DependencyFreshness.ps1: one expression made safe for an emptyrepositoryPinsunder StrictMode..github/scripts/workflow-pin-metadata.test.cjs: the manifest-agreement test is removed; the caller inventory, theone-commit and the one-release assertions stay.
.github/scripts/release-pins.test.cjsgains two cases: a groupedci-workflows bump passes with no manifest edit, and two different ci-workflows releases fail with their locations.
docs/releases.md: states the rule as it now is.Pins and Dependabot (second commit):
.github/workflows/pr-require-checks.yml: the sixteen ci-workflows action pins move from v0.73.0 to the v0.74.0release commit
944d346c487c79eaf85dff752586fb59b0f5c539. The pin in the sync-managedpr-check-managed-files-hosted.ymlis unchanged..github/dependabot.yml, thegithub-actionsentry: the ignore ofmelodic-software/ci-workflows/*becomes anignore of that one sync-managed pin; first-party releases are excluded from the cooldown; a
first-party-actionsgroup moves every ci-workflows pin in one pull request.
What the release freshness gate checks for ci-workflows
repositoryPinscommit had to be an ancestor of ci-workflows' default branch, and drift was countedfrom later commits on that branch. No tag or
# vcomment was checked.exist for the pinned version, and that release's tag must map to the pinned commit.
The published
compatibility.jsonnever recorded the ci-workflows commit, so no release artifact changes shape.No other repository reads
repositoryPins.Verification
node --test .github/scripts/workflow-pin-metadata.test.cjs .github/scripts/release-pins.test.cjs: 10 pass, 0 fail.pwsh -NoProfile -File scripts/Test-ReleasePins.ps1 -RepositoryRoot .:Release and workflow pins are internally consistent.# v0.75.0, manifest untouched: bothchecks pass. With one pin rewritten and fifteen left: both fail.
components/dependabot-policy/dependabot-policy.mjs --root .:Dependabot policy passed.Test-DependencyFreshness.ps1, which needs the network and Docker; ci-workflows v0.74.0 is a publishedrelease whose tag maps to
944d346c.Related
🤖 Generated with Claude Code