Skip to content

ci(dependabot): correct the auto-merge lane comments for first-party actions - #144

Merged
kyle-sexton merged 3 commits into
mainfrom
ci/automerge-first-party-comments
Nov 15, 2026
Merged

kyle-sexton merged 3 commits into
mainfrom
ci/automerge-first-party-comments

Conversation

@kyle-sexton

@kyle-sexton kyle-sexton commented Nov 15, 2026 •

Copy link
Copy Markdown
Member

No related issue: the first-party action pin work, tracked in the owner's audit session.

Summary

Two comments described the Dependabot auto-merge lane as it was before the first-party pins moved to Dependabot.
This change corrects them. Comments only: no trigger, permission, group or pin changes.

Fix

  • .github/workflows/pr-automerge-dependabot.yml, header: the lane also arms melodic-software/* bumps, through
    the synced Dependabot policy copy (fastTrack.own), not only the vendor publishers.
  • .github/dependabot.yml: a pull request the lane does not arm takes the review tier (an AI review lane's merge
    verdict), where the comment said a person merges it; and, where the comment covers majors, a first-party major
    stays in first-party-actions instead of falling through to the catch-all group.

Verification

  • ci-workflows pr-automerge-dependabot.yml header on main: with the synced copy at
    .github/standards/dependabot-policy/policy.json, the allowlist is the copy's tier: auto publishers plus its
    fastTrack github-actions and own globs; "a grouped PR with one major bump ... is skipped".
  • standards components/dependabot-policy/policy.json on main: fastTrack.own is melodic-software/*.
  • standards components/dependabot-policy/README.md:183 on main: "No Dependabot pull request waits on a human."
  • git diff touches comment lines only.

Related

🤖 Generated with Claude Code

…actions

The auto-merge caller also arms melodic-software/* bumps when the base
holds the synced Dependabot policy copy, and a first-party major stays in
the first-party-actions group, where the lane does not arm it.

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
@github-actions

github-actions Bot commented Nov 15, 2026 •

Copy link
Copy Markdown

claude-security-review reviewed faf5160cd969b116f49a198023a2638a631127fb: 0 finding(s), 0 as inline comments.

No security findings in the incremental change (79c10e5 → faf5160).

The only change is one comment line in .github/dependabot.yml. It reads "reviewed by hand" and now reads "in the review tier". No updates: entry, group, patterns, update-types, schedule or ignore rule changed, so the grouping and the auto-merge lane scoping are the same as before. The wording still says a first-party major takes the review tier, and I took the lane's actual behaviour from the unchanged configuration, not from the comment.

I did not read pr-automerge-dependabot.yml, since the diff doesn't touch it.

The change doesn't widen any trust control: no trusted-actor list, token scope, kill switch, merge hold or plugin manifest is involved. It removes no standing instruction, because the comment is documentation and not a rule that anything enforces.

No manifests were touched, so there are no manifest <field> lines. Everything else in the PR was reviewed at 79c10e5 and is unchanged.

critical-findings: 0

@github-actions

github-actions Bot commented Nov 15, 2026 •

Copy link
Copy Markdown

claude-review reviewed faf5160cd969b116f49a198023a2638a631127fb: 0 finding(s), 0 as inline comments.

Incremental review of .github/dependabot.yml since 79c10e5. No findings.

The change replaces one comment phrase ("reviewed by hand" with "in the review tier"). It touches no keys, groups, or behavior. The new wording matches the next lines of the comment, which already say a first-party major "takes the review tier". It also matches the PR description's stated scope of comments only.

I did not review the rest of the pull request in this pass. The workflow-header comment change in pr-automerge-dependabot.yml was reviewed earlier and is unchanged. I did not check the PR's claims about ci-workflows or standards behavior (author-claimed, unverified).

The PR body states "No related issue" with a reason, so there are no closing-issue criteria to check. No manifests changed. No settled-thread or prior-finding files were supplied. No hold applies.

Verifier dropped 0 of 0 candidates.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 42198dcc1d

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread .github/dependabot.yml Resolved
@chatgpt-codex-connector

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-15T21:00:27.417157Z 42198dc PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

kyle-sexton and others added 2 commits November 15, 2026 16:01
REVIEW.md: no Dependabot pull request waits on a human; a major merges on
an AI review lane's verdict.

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
REVIEW.md: no Dependabot pull request waits on a human; a major merges on
an AI review lane's verdict.

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
@kyle-sexton
kyle-sexton merged commit 5556fd0 into main Nov 15, 2026
12 checks passed
@kyle-sexton
kyle-sexton deleted the ci/automerge-first-party-comments branch November 15, 2026 21:12
kyle-sexton added a commit that referenced this pull request Nov 16, 2026
…the cross-cutting record (#147)

Refs: melodic-software/claude-code-plugins#15725

## Summary

Since #137 and #139, #145 moved the check-managed-files pin to
ci-workflows v0.74.0 (`944d346`), and #144 added a header line to
`pr-automerge-dependabot.yml`. The cross-cutting record's notes still
named v0.71.0 and line ranges one line short. This change corrects those
three citations and nothing else.

## Fix

- `check-managed-files@8e1076f v0.71.0` becomes `@944d346 v0.74.0`,
matching `pr-check-managed-files-hosted.yml:118`.
- `pr-automerge-dependabot.yml:21-29` becomes `:22-30` (the job), and
`:3-7` becomes `:3-8` (the header sentence).

No command, version or checksum changes. #143 also moved the
lychee-offline composite to v0.74.0. I diffed it against v0.39.8
(`594987a`): its version (0.24.2), sha256 and argument defaults are
unchanged. It moved its run step into `run.sh` unchanged, and it now
falls back to a bundled `lychee.toml` only when the caller has none;
this repository has one. The other records' citations still hold: apart
from that header line, every CI edit since #139 changed lines in place.

## Verification

- Schema: `check-jsonschema --schemafile
docs/contracts/ecosystem-commands/ecosystem.schema.json`
(claude-code-plugins `origin/main`) over all four records printed `ok --
validation done`.
- Range: from #139's merge `455a89f` to this commit, covering #140
through #146 plus this fix: 8 files (workflows, dependabot, policy.json,
REVIEW.md, the record). Every tool runs with `env -C <checkout>`.
Toolchain skill text is 1.4.0.
- Run 1, `/toolchain:check all`, 11:38 PM to 11:39 PM EST 2026-11-15.
Overall line: `Overall: PASS (1 of 1 ecosystems passed)`.

| Ecosystem | Build | Test | Lint | Status |
|---|---|---|---|---|
| bash | — | — | pass | PASS |
| markdown | — | — | — | — |

- bash: `shellcheck .claude/cloud-bootstrap.sh .cursor/install.sh` and
`bash -n` on each exited 0.
  - markdown: every command is null.
  - No other ecosystem's files exist.
  - The output contains no `skip (unresolved`.
- Run noise: the first attempt ran in a clone nested under another
repository. With no `.shellcheckrc` here, shellcheck took that
repository's rc and reported 9 optional SC2310 infos. The record's
command run from this branch's own checkout exits 0, as on CI's runner.
- Run 2, `/toolchain:lint`, 11:39 PM EST. Overall line: `Overall: PASS
(1 of 1 ecosystems passed)`.
- cross-cutting passed: `jq empty` on both files, lychee with 0 errors,
and `gitleaks dir . --config .gitleaks.toml --no-banner --redact` with
no leaks.
  - markdown and yaml are all null.
  - The installed lychee 0.24.2 and gitleaks 8.30.1 match the pins.
- The verify gate passed on this commit: schema validation plus the
cross-cutting check-cmd.

## Remaining

melodic-software/claude-code-plugins#15725 stays open after this pull
request. Its baseline steps are still owed: a `/toolchain:check all` and
a `/toolchain:lint` with the bundled defaults (records removed) on one
range, then the comparison of their command lists with the record runs
above. This pass had a two-run budget, which went to the record runs.

## Related

- #137 and #139, which merged the records this change corrects
- melodic-software/claude-code-plugins#15725,
melodic-software/claude-code-plugins#15703 (parent)

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant