Skip to content

Avoid CodeQL false positives for Path_* types #980

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mauvilsa merged 1 commit into from
Sep 17, 2026
Merged

Avoid CodeQL false positives for Path_* types #980

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions jsonargparse/typing.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -245,8 +245,8 @@ def extend_base_type(
Raises:
ValueError: If the type has already been registered with a different name.
"""
if register_key in registered_types:
registered_type = registered_types[register_key]
registered_type = None if register_key is None else registered_types.get(register_key)
if registered_type is not None:
if registered_type.__name__ != name:
raise ValueError(f"Same type already registered with a different name: {registered_type.__name__}.")
return registered_type
Expand Down Expand Up @@ -411,8 +411,9 @@ def path_type(mode: str, docstring: str | None = None) -> TypeAlias:
key_name = "path " + "".join(sorted(mode))

register_key = (key_name, str)
if register_key in registered_types:
return registered_types[register_key]
registered_type = registered_types.get(register_key)
if registered_type is not None:
return registered_type

class PathType(Path):
_expression = name
Expand Down