Skip to content

Avoid CodeQL false positives for Path_* types - #980

Merged
mauvilsa merged 1 commit into
mainfrom
codeql-registry-subscript
Sep 17, 2026
Merged

mauvilsa merged 1 commit into
mainfrom
codeql-registry-subscript

Conversation

@mauvilsa

Copy link
Copy Markdown
Owner

Before submitting

  • Did you read the contributing guideline?
  • If you used a coding agent, did you fully understand and validate all generated code and ensure it follows the contributing guidelines?
  • [n/a] Did you update the documentation? (readme and public docstrings)
  • [n/a] Did you write unit tests such that there is 100% coverage on related code? (required for bug fixes and new features)
  • Did you verify that new and existing tests pass locally?
  • [n/a] If this is a bug fix, did you verify that the tests fail without the code fix?
  • Did you make sure that all changes preserve backward compatibility?
  • [n/a] Did you update the CHANGELOG including a pull request link? (not for typos, docs, test updates, or minor internal changes/refactors)

@mauvilsa mauvilsa added the refactor Improvements to the quality of the code label Sep 17, 2026
@greptile-apps

greptile-apps Bot commented Sep 17, 2026

Copy link
Copy Markdown

RetriggerConfidence Score: 5/5

The PR appears safe to merge with no actionable correctness, security, or maintainability issues identified.

Summary

This PR refactors registered-type lookups to avoid CodeQL false positives while preserving existing caching and duplicate-registration behavior.

  • Uses an explicit None result when extend_base_type has no registration key.
  • Replaces separate membership and indexed lookups with .get() for keyed registrations.
  • Preserves Path_* type identity reuse.

Reviews (1) · Last reviewed commit: "Avoid CodeQL false positives for Path_* ..."

@sonarqubecloud

Copy link
Copy Markdown

@codecov

codecov Bot commented Sep 17, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (53947c6) to head (ab0a55c).
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #980   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           27        27           
  Lines         9077      9078    +1     
=========================================
+ Hits          9077      9078    +1     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

@mauvilsa
mauvilsa merged commit 5e494f1 into main Sep 17, 2026
33 checks passed
@mauvilsa
mauvilsa deleted the codeql-registry-subscript branch September 17, 2026 06:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

refactor Improvements to the quality of the code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant