Skip to content

fix: update example tests failing on CI #11813

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
raymondfeng wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix: update example tests failing on CI #11813

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1fb76b2
fix(example-todo): update geopoint data in tests
raymondfeng Oct 2, 2026
f87cf2b
fix(example-webpack): allow more time to launch the browser in tests
raymondfeng Oct 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion examples/todo/src/__tests__/helpers.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ export function givenTodo(todo?: Partial<Todo>) {

export const aLocation = {
address: '1 New Orchard Road, Armonk, 10504',
geopoint: <GeoPoint>{y: 41.109728357749, x: -73.72462031805},
geopoint: <GeoPoint>{y: 41.109725723771, x: -73.724620709372},
get geostring() {
return `${this.geopoint.y},${this.geopoint.x}`;
},
Expand Down
3 changes: 2 additions & 1 deletion examples/webpack/src/__tests__/integration/bundle-web.integration.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,8 @@ skipIf<[(this: Suite) => void], void>(
let browser: Browser;
let html: string;
before(async function (this: Mocha.Context) {
this.timeout(15000);
// Launching the browser can be slow on CI
this.timeout(30000);
browser = await puppeteer.launch({
headless: true,
args: ['--no-sandbox'],
Expand Down
Loading