fix: update example tests failing on CI - #11813
Open
raymondfeng wants to merge 2 commits into
Open
raymondfeng wants to merge 2 commits into
raymondfeng wants to merge 2 commits into
Conversation
The US Census geocoder now returns slightly different coordinates for the test address, so `GeoLookupService` and `TodoApplication` tests fail on every platform, on master as well. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Raymond Feng <enjoyjava@gmail.com>
The hook that launches puppeteer and loads the page intermittently exceeds 15 seconds on the ubuntu-latest runners. It now gets 30 seconds, the same as the hook that generates the bundle. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Raymond Feng <enjoyjava@gmail.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the example test failures that make the
Testjobs fail on master and on every open PR.examples/todo: the US Census geocoder now returns slightly different coordinates for the test address, soGeoLookupServiceandTodoApplicationfail on all platforms. The fixture is updated to the values the service currently returns. This is the same kind of update as c2441cb.examples/webpack: thebundle-web.jshook that launches puppeteer and loads the page is flaky on the ubuntu-latest runners. This raises its timeout from 15s to 30s, but it still timed out at 30s on this PR, so the hook hangs rather than runs slow and this does not fix the flake. The same hook fails in about a third of recent CI runs, including renovate branches on master code, so it predates the open PRs. It needs a separate investigation.Verified locally:
examples/todo37 passing (against the live geocoder),examples/webpack4 passing.These two commits are also on #11810, #11811, #11793 and #11812 so their CI can pass. Rebasing drops the duplicates once this PR merges.
Checklist
npm testpasses on your machine: ran the two affected example suitespackages/cliwere updatedexamples/*were updated🤖 Generated with Claude Code